Skip to content

Commit 45dcc10

Browse files
committed
Allow IAB Programs to be listed in meeting request conflicts. Ready for merge. Fixes ietf-tools#3270.
- Legacy-Id: 19052
1 parent d8ec825 commit 45dcc10

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

ietf/secr/sreq/forms.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
# Helper Functions
2828
# -------------------------------------------------
2929
def allowed_conflicting_groups():
30-
return Group.objects.filter(type__in=['wg', 'ag', 'rg', 'rag'], state__in=['bof', 'proposed', 'active'])
30+
return Group.objects.filter(type__in=['wg', 'ag', 'rg', 'rag', 'program'], state__in=['bof', 'proposed', 'active'])
3131

3232
def check_conflict(groups, source_group):
3333
'''

ietf/secr/sreq/tests.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,8 @@ def test_edit(self):
8282
group2 = GroupFactory()
8383
group3 = GroupFactory()
8484
group4 = GroupFactory()
85+
iabprog = GroupFactory(type_id='program')
86+
8587
SessionFactory(meeting=meeting,group=mars,status_id='sched')
8688

8789
url = reverse('ietf.secr.sreq.views.edit', kwargs={'acronym':'mars'})
@@ -92,7 +94,7 @@ def test_edit(self):
9294
'length_session1':'3600',
9395
'length_session2':'3600',
9496
'attendees':'10',
95-
'conflict1':'',
97+
'conflict1':iabprog.acronym,
9698
'comments':'need lights',
9799
'session_time_relation': 'subsequent-days',
98100
'adjacent_with_wg': group2.acronym,
@@ -108,6 +110,8 @@ def test_edit(self):
108110
sessions = Session.objects.filter(meeting=meeting, group=mars)
109111
self.assertEqual(len(sessions), 2)
110112
session = sessions[0]
113+
114+
self.assertEqual(session.constraints().get(name='conflict').target.acronym, iabprog.acronym)
111115
self.assertEqual(session.constraints().get(name='time_relation').time_relation, 'subsequent-days')
112116
self.assertEqual(session.constraints().get(name='wg_adjacent').target.acronym, group2.acronym)
113117
self.assertEqual(

0 commit comments

Comments
 (0)