Skip to content

Commit 45b19a5

Browse files
committed
Fixed various issues with the interim approval request email text when used for non-WG groups (RGs, for instance). Added supporting template filter functions. Related to issues ietf-tools#1979 and ietf-tools#1980.
- Legacy-Id: 11581
1 parent 4537f91 commit 45b19a5

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

ietf/doc/templatetags/ietf_filters.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -630,4 +630,4 @@ def comma_separated_list(seq, end_word="and"):
630630

631631
@register.filter()
632632
def role_names(roles):
633-
return list(set([ r.name.name for r in roles ]))
633+
return list(set([ "%s %s" % (r.group.name, r.name.name) for r in roles ]))

ietf/templates/meeting/interim_approval_request.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{% load ams_filters %}
1+
{% load ams_filters %}{% load ietf_filters %}
22
A new interim meeting {% if is_series %}series {% endif %}request has just been submitted by {{ requester }}.
33

44
This request requires approval by the {{ group.interim_approval_roles|role_names|comma_separated_list:"or" }}
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
{% load ietf_filters %}
22
---------------------------------------------------------
3-
Working Group Name: {{ group.name|safe }}
4-
Area Name: {{ group.parent }}
5-
Session Requester: {{ requester }}
3+
{{ group.type.verbose_name }} Name: {{ group.name|safe }}
4+
{% if group.type.slug == "wg" or group.type.slug == "directorate" or group.type.slug == "team" %}Area Name: {{ group.parent }}
5+
{% endif %}Session Requester: {{ requester }}
66

77
{% if meeting.city %}City: {{ meeting.city }}
88
Country: {{ meeting.country }}
@@ -14,7 +14,7 @@ Timezone: {{ meeting.time_zone }}
1414
Date: {{ session.official_timeslotassignment.timeslot.time|date:"Y-m-d" }}
1515
Start Time: {{ session.official_timeslotassignment.timeslot.time|date:"H:i" }}
1616
Duration: {{ session.requested_duration|format_timedelta }}
17-
Remote Instructions: {{ session.remote_instructions }}
17+
Remote Participation Information: {{ session.remote_instructions }}
1818
Agenda Note: {{ session.agenda_note }}
1919
{% endfor %}
2020
---------------------------------------------------------

0 commit comments

Comments
 (0)