Skip to content

Commit 45a808d

Browse files
committed
Added more logging for submissions, to get timing information.
- Legacy-Id: 18635
1 parent 72c7018 commit 45a808d

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

ietf/submit/utils.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import os
88
import pathlib
99
import re
10+
import time
1011

1112
from typing import Callable, Optional # pyflakes:ignore
1213

@@ -671,6 +672,7 @@ def save_files(form):
671672
with io.open(name, 'wb+') as destination:
672673
for chunk in f.chunks():
673674
destination.write(chunk)
675+
log("saved file %s" % name)
674676
return file_name
675677

676678
def get_draft_meta(form, saved_files):
@@ -786,6 +788,7 @@ def apply_check(submission, checker, method, fn):
786788
symbol=checker.symbol)
787789
check.save()
788790

791+
mark = time.time()
789792
for checker_path in settings.IDSUBMIT_CHECKER_CLASSES:
790793
checker_class = import_string(checker_path)
791794
checker = checker_class()
@@ -795,6 +798,8 @@ def apply_check(submission, checker, method, fn):
795798
if hasattr(checker, method) and ext in file_name:
796799
apply_check(submission, checker, method, file_name[ext])
797800
break
801+
tau = time.time() - mark
802+
log("ran submission checks (%.3fs) for %s" % (tau, file_name))
798803

799804
def send_confirmation_emails(request, submission, requires_group_approval, requires_prev_authors_approval):
800805
docevent_from_submission(request, submission, desc="Uploaded new revision")

ietf/submit/views.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ def upload_submission(request):
5050
try:
5151
form = SubmissionManualUploadForm(request, data=request.POST, files=request.FILES)
5252
if form.is_valid():
53+
log('got valid submission form for %s' % form.filename)
5354
saved_files = save_files(form)
5455
authors, abstract, file_name, file_size = get_draft_meta(form, saved_files)
5556

@@ -97,7 +98,6 @@ def upload_submission(request):
9798
form._errors["__all__"] = form.error_class(["There was a failure processing your upload -- please verify that your draft passes idnits. (%s)" % e.message])
9899
if debug.debug:
99100
raise
100-
101101
else:
102102
form = SubmissionManualUploadForm(request=request)
103103

@@ -119,6 +119,7 @@ def err(code, text):
119119
try:
120120
form = SubmissionAutoUploadForm(request, data=request.POST, files=request.FILES)
121121
if form.is_valid():
122+
log('got valid submission form for %s' % form.filename)
122123
username = form.cleaned_data['user']
123124
user = User.objects.filter(username=username)
124125
if user.count() == 0:

0 commit comments

Comments
 (0)