Skip to content

Commit 44cd9e0

Browse files
committed
Moved the materials start, cutoff, and revision dates into the Meeting object
- Legacy-Id: 11760
1 parent 56c232e commit 44cd9e0

5 files changed

Lines changed: 24 additions & 9 deletions

File tree

ietf/doc/tests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -928,7 +928,7 @@ def setUp(self):
928928
self.other_group.role_set.create(name_id='chair',person=self.other_chair,email=self.other_chair.email())
929929

930930
today = datetime.date.today()
931-
cut_days = settings.MEETING_MATERIALS_SUBMISSION_CORRECTION_DAYS
931+
cut_days = settings.MEETING_MATERIALS_DEFAULT_SUBMISSION_CORRECTION_DAYS
932932
self.past_cutoff = SessionFactory.create(meeting__type_id='ietf',group=self.group,meeting__date=today-datetime.timedelta(days=1+cut_days))
933933
self.past = SessionFactory.create(meeting__type_id='ietf',group=self.group,meeting__date=today-datetime.timedelta(days=cut_days/2))
934934
self.inprog = SessionFactory.create(meeting__type_id='ietf',group=self.group,meeting__date=today-datetime.timedelta(days=1))

ietf/meeting/models.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,15 @@ class Meeting(models.Model):
7272
idsubmit_cutoff_warning_days = timedelta.fields.TimedeltaField(blank=True,
7373
default=settings.IDSUBMIT_DEFAULT_CUTOFF_WARNING_DAYS,
7474
help_text = "How long before the 00 cutoff to start showing cutoff warnings. Use for example 21 days or 3 weeks.")
75-
#
75+
submission_start_day_offset = models.IntegerField(blank=True,
76+
default=settings.MEETING_MATERIALS_DEFAULT_SUBMISSION_START_DAYS,
77+
help_text = "The number of days before the meeting start date after which meeting materials will be accepted.")
78+
submission_cutoff_day_offset = models.IntegerField(blank=True,
79+
default=settings.MEETING_MATERIALS_DEFAULT_SUBMISSION_CUTOFF_DAYS,
80+
help_text = "The number of days after the meeting start date in which new meeting materials will be accepted.")
81+
submission_correction_day_offset = models.IntegerField(blank=True,
82+
default=settings.MEETING_MATERIALS_DEFAULT_SUBMISSION_CORRECTION_DAYS,
83+
help_text = "The number of days after the meeting start date in which updates to existing meeting materials will be accepted.")
7684
venue_name = models.CharField(blank=True, max_length=255)
7785
venue_addr = models.TextField(blank=True)
7886
break_area = models.CharField(blank=True, max_length=255)
@@ -149,11 +157,11 @@ def get_materials_path(self):
149157

150158
# the various dates are currently computed
151159
def get_submission_start_date(self):
152-
return self.date + datetime.timedelta(days=settings.MEETING_MATERIALS_SUBMISSION_START_DAYS)
160+
return self.date - datetime.timedelta(days=self.submission_start_day_offset)
153161
def get_submission_cut_off_date(self):
154-
return self.date + datetime.timedelta(days=settings.MEETING_MATERIALS_SUBMISSION_CUTOFF_DAYS)
162+
return self.date + datetime.timedelta(days=self.submission_cutoff_day_offset)
155163
def get_submission_correction_date(self):
156-
return self.date + datetime.timedelta(days=settings.MEETING_MATERIALS_SUBMISSION_CORRECTION_DAYS)
164+
return self.date + datetime.timedelta(days=self.submission_correction_day_offset)
157165

158166
def get_schedule_by_name(self, name):
159167
return self.schedule_set.filter(name=name).first()

ietf/secr/meetings/tests.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,9 @@ def test_add_meeting(self):
7777
idsubmit_cutoff_day_offset_01=20,
7878
idsubmit_cutoff_time_utc =datetime.timedelta(hours=23, minutes=59, seconds=59),
7979
idsubmit_cutoff_warning_days =datetime.timedelta(days=21),
80+
submission_start_day_offset=90,
81+
submission_cutoff_day_offset=26,
82+
submission_correction_day_offset=50,
8083
)
8184
self.client.login(username='secretary', password='secretary+password')
8285
response = self.client.post(url, post_data, follow=True)
@@ -95,6 +98,9 @@ def test_edit_meeting(self):
9598
idsubmit_cutoff_day_offset_01=20,
9699
idsubmit_cutoff_time_utc =datetime.timedelta(hours=23, minutes=59, seconds=59),
97100
idsubmit_cutoff_warning_days =datetime.timedelta(days=21),
101+
submission_start_day_offset=90,
102+
submission_cutoff_day_offset=26,
103+
submission_correction_day_offset=50,
98104
)
99105
self.client.login(username="secretary", password="secretary+password")
100106
response = self.client.post(url, post_data,follow=True)

ietf/secr/proceedings/views.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,8 @@ def main(request):
394394
meetings = Meeting.objects.filter(type='ietf').order_by('-number')
395395
else:
396396
# select meetings still within the cutoff period
397-
meetings = Meeting.objects.filter(type='ietf',date__gt=datetime.datetime.today() - datetime.timedelta(days=settings.MEETING_MATERIALS_SUBMISSION_CORRECTION_DAYS)).order_by('number')
397+
today = datetime.datetime.today()
398+
meetings = [m for m in Meeting.objects.filter(type='ietf').order_by('-number') if m.get_submission_correction_date()>=today]
398399

399400
groups = get_my_groups(request.user)
400401
interim_meetings = Meeting.objects.filter(type='interim',session__group__in=groups,session__status='sched').order_by('-date')

ietf/settings.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -558,9 +558,9 @@ def skip_unreadable_post(record):
558558

559559
# === Meeting Related Settings =================================================
560560

561-
MEETING_MATERIALS_SUBMISSION_START_DAYS = -90
562-
MEETING_MATERIALS_SUBMISSION_CUTOFF_DAYS = 26
563-
MEETING_MATERIALS_SUBMISSION_CORRECTION_DAYS = 50
561+
MEETING_MATERIALS_DEFAULT_SUBMISSION_START_DAYS = 90
562+
MEETING_MATERIALS_DEFAULT_SUBMISSION_CUTOFF_DAYS = 26
563+
MEETING_MATERIALS_DEFAULT_SUBMISSION_CORRECTION_DAYS = 50
564564

565565
INTERNET_DRAFT_DAYS_TO_EXPIRE = 185
566566

0 commit comments

Comments
 (0)