Skip to content

Commit 4494367

Browse files
committed
Hide unapproved related liaison statement unless during approval it to prevent dead link
- Legacy-Id: 6839
1 parent f935577 commit 4494367

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

ietf/liaisons/views.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ def liaison_approval_list(request):
135135
def liaison_approval_detail(request, object_id):
136136
liaison = get_object_or_404(approvable_liaison_statements(request.user), pk=object_id)
137137

138-
if request.method=='POST' and request.POST.get('do_approval', False):
138+
if request.method == 'POST' and request.POST.get('do_approval', False):
139139
liaison.approved = datetime.datetime.now()
140140
liaison.save()
141141

@@ -144,6 +144,7 @@ def liaison_approval_detail(request, object_id):
144144

145145
return render_to_response('liaisons/approval_detail.html', {
146146
"liaison": liaison,
147+
"is_approving": True,
147148
}, context_instance=RequestContext(request))
148149

149150

ietf/templates/liaisons/detail.html

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,15 @@ <h1>Liaison Statement: {% include 'liaisons/liaison_title.html' %}</h1>
8686
{% endif %}
8787

8888
{% if liaison.related_to %}
89+
{% if liaison.related_to.approved or is_approving %}
8990
<tr>
9091
<td>Referenced liaison:</td>
9192
<td>
9293
<a href="{% url liaison_detail liaison.related_to.pk %}">{% if liaison.related_to.title %}{{ liaison.related_to.title }}{% else %}Liaison #{{ liaison.related_to.pk }}{% endif %}</a>
9394
</td>
9495
</tr>
9596
{% endif %}
97+
{% endif %}
9698

9799
<tr>
98100
<td>Attachments:</td>

0 commit comments

Comments
 (0)