Skip to content

Commit 42995fa

Browse files
committed
Merged in ^/branch/iola/meeting-improvement-r17214@17617, which provides a new meeting schedule editor.
- Legacy-Id: 17701
2 parents d55f0aa + 76b8554 commit 42995fa

17 files changed

Lines changed: 1643 additions & 100 deletions

docker/Dockerfile

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -139,15 +139,6 @@ RUN wget -q https://bootstrap.pypa.io/get-pip.py && python get-pip.py && rm get-
139139
RUN pip install certifi
140140
RUN pip install virtualenv
141141

142-
# Phantomjs
143-
WORKDIR /usr/local
144-
145-
RUN wget -qN https://tools.ietf.org/tar/phantomjs-1.9.8-linux-x86_64.tar.bz2
146-
RUN tar xjf phantomjs-1.9.8-linux-x86_64.tar.bz2
147-
148-
WORKDIR /usr/local/bin
149-
RUN ln -s /usr/local/phantomjs-1.9.8-linux-x86_64/bin/phantomjs .
150-
151142
# idnits and dependencies
152143
ADD https://tools.ietf.org/tools/idnits/idnits /usr/local/bin/
153144
RUN chmod +rx /usr/local/bin/idnits

docker/install-extras

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
#!/bin/bash
22

33
export DEBIAN_FRONTEND=noninteractive
4-
su - -c "apt-get update \
5-
&& apt-get install -qy graphviz ghostscript apache2-utils \
4+
sudo su - -c "apt-get update \
5+
&& apt-get install -qy graphviz ghostscript apache2-utils chromium-driver \
66
&& apt-get clean \
77
&& rm -rf /var/lib/apt/lists/*"
8-

ietf/meeting/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
import debug # pyflakes:ignore
1717

18-
from django.core.validators import MinValueValidator
18+
from django.core.validators import MinValueValidator, RegexValidator
1919
from django.db import models
2020
from django.db.models import Max
2121
from django.conf import settings
@@ -620,7 +620,7 @@ class Schedule(models.Model):
620620
schedule, others may copy it
621621
"""
622622
meeting = ForeignKey(Meeting, null=True, related_name='schedule_set')
623-
name = models.CharField(max_length=16, blank=False)
623+
name = models.CharField(max_length=16, blank=False, help_text="Letters, numbers and -:_ allowed.", validators=[RegexValidator(r'^[A-Za-z0-9-:_]*$')])
624624
owner = ForeignKey(Person)
625625
visible = models.BooleanField(default=True, help_text="Make this agenda available to those who know about it.")
626626
public = models.BooleanField(default=True, help_text="Make this agenda publically available.")

ietf/meeting/test_data.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,11 @@ def make_meeting_test_data(meeting=None):
9999
# slots
100100
session_date = meeting.date + datetime.timedelta(days=1)
101101
slot1 = TimeSlot.objects.create(meeting=meeting, type_id='regular', location=room,
102-
duration=datetime.timedelta(minutes=30),
102+
duration=datetime.timedelta(minutes=60),
103103
time=datetime.datetime.combine(session_date, datetime.time(9, 30)))
104104
slot2 = TimeSlot.objects.create(meeting=meeting, type_id='regular', location=room,
105-
duration=datetime.timedelta(minutes=30),
106-
time=datetime.datetime.combine(session_date, datetime.time(10, 30)))
105+
duration=datetime.timedelta(minutes=60),
106+
time=datetime.datetime.combine(session_date, datetime.time(10, 50)))
107107
breakfast_slot = TimeSlot.objects.create(meeting=meeting, type_id="lead", location=breakfast_room,
108108
duration=datetime.timedelta(minutes=90),
109109
time=datetime.datetime.combine(session_date, datetime.time(7,0)))
@@ -116,7 +116,7 @@ def make_meeting_test_data(meeting=None):
116116
# mars WG
117117
mars = Group.objects.get(acronym='mars')
118118
mars_session = Session.objects.create(meeting=meeting, group=mars,
119-
attendees=10, requested_duration=datetime.timedelta(minutes=20),
119+
attendees=10, requested_duration=datetime.timedelta(minutes=50),
120120
type_id='regular')
121121
SchedulingEvent.objects.create(session=mars_session, status_id='schedw', by=system_person)
122122
SchedTimeSessAssignment.objects.create(timeslot=slot1, session=mars_session, schedule=schedule)
@@ -125,7 +125,7 @@ def make_meeting_test_data(meeting=None):
125125
# ames WG
126126
ames_session = Session.objects.create(meeting=meeting, group=Group.objects.get(acronym="ames"),
127127
attendees=10,
128-
requested_duration=datetime.timedelta(minutes=20),
128+
requested_duration=datetime.timedelta(minutes=60),
129129
type_id='regular')
130130
SchedulingEvent.objects.create(session=ames_session, status_id='schedw', by=system_person)
131131
SchedTimeSessAssignment.objects.create(timeslot=slot2, session=ames_session, schedule=schedule)
@@ -134,7 +134,7 @@ def make_meeting_test_data(meeting=None):
134134
# IESG breakfast
135135
iesg_session = Session.objects.create(meeting=meeting, group=Group.objects.get(acronym="iesg"),
136136
name="IESG Breakfast", attendees=25,
137-
requested_duration=datetime.timedelta(minutes=20),
137+
requested_duration=datetime.timedelta(minutes=60),
138138
type_id="lead")
139139
SchedulingEvent.objects.create(session=iesg_session, status_id='schedw', by=system_person)
140140
SchedTimeSessAssignment.objects.create(timeslot=breakfast_slot, session=iesg_session, schedule=schedule)

0 commit comments

Comments
 (0)