Skip to content

Commit 4287b76

Browse files
committed
Merged in [15227] from rjsparks@nostrum.com:
Use factories for ietf.doc.tests_conflict_review. - Legacy-Id: 15241 Note: SVN reference [15227] has been migrated to Git commit 67df7bd
2 parents 05af647 + 67df7bd commit 4287b76

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

ietf/doc/tests_conflict_review.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
import debug # pyflakes:ignore
23
import os
34
import shutil
45

@@ -9,6 +10,7 @@
910
from django.conf import settings
1011
from django.urls import reverse as urlreverse
1112

13+
from ietf.doc.factories import IndividualDraftFactory, ConflictReviewFactory
1214
from ietf.doc.models import Document, DocEvent, NewRevisionDocEvent, BallotPositionDocEvent, TelechatDocEvent, State
1315
from ietf.doc.utils import create_ballot_if_not_open
1416
from ietf.doc.views_conflict_review import default_approval_text
@@ -17,7 +19,6 @@
1719
from ietf.name.models import StreamName
1820
from ietf.utils.test_utils import TestCase, unicontent
1921
from ietf.utils.mail import outbox, empty_outbox
20-
from ietf.utils.test_data import make_test_data
2122
from ietf.utils.test_utils import login_testing_unauthorized
2223

2324

@@ -308,7 +309,8 @@ def test_approve_noprob(self):
308309
self.approve_test_helper('appr-noprob')
309310

310311
def setUp(self):
311-
make_test_data()
312+
IndividualDraftFactory(name='draft-imaginary-independent-submission')
313+
ConflictReviewFactory(name='conflict-review-imaginary-irtf-submission',review_of=IndividualDraftFactory(name='draft-imaginary-irtf-submission',stream_id='irtf'),notify='notifyme@example.net')
312314

313315

314316
class ConflictReviewSubmitTests(TestCase):
@@ -387,7 +389,7 @@ def test_subsequent_submission(self):
387389
self.assertTrue(q('textarea')[0].text.strip().startswith("[Edit this page"))
388390

389391
def setUp(self):
390-
make_test_data()
392+
ConflictReviewFactory(name='conflict-review-imaginary-irtf-submission',review_of=IndividualDraftFactory(name='draft-imaginary-irtf-submission',stream_id='irtf'),notify='notifyme@example.net')
391393
self.test_dir = self.tempdir('conflict-review')
392394
self.saved_conflict_review_path = settings.CONFLICT_REVIEW_PATH
393395
settings.CONFLICT_REVIEW_PATH = self.test_dir

0 commit comments

Comments
 (0)