Skip to content

Commit 415768b

Browse files
committed
Fix double includes of jQuery 1.8.2 in meeting templates, make sure
script includes are put in the "js" block rather than the "scripts" block, the latter is for inline scripts, not script includes (this fixes a couple of weird syntax errors) - Legacy-Id: 6815
1 parent e63ac36 commit 415768b

4 files changed

Lines changed: 10 additions & 17 deletions

File tree

ietf/templates/meeting/agenda_list.html

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@
1313
<link rel='stylesheet' type='text/css' href='/css/agenda.css' />
1414
{% endblock pagehead %}
1515

16-
{% block scripts %}
17-
<script type='text/javascript' src='/js/lib/jquery-1.8.2.min.js'></script>
16+
{% block js %}
1817
<script type='text/javascript' src='/js/jquery-ui-1.9.0.custom/jquery-ui.custom.js'></script>
1918
<script type='text/javascript' src='/js/jquery-ui-1.9.0.custom/jquery.ui.widget.js'></script>
2019
<script type='text/javascript' src='/js/jquery-ui-1.9.0.custom/jquery.ui.droppable.js'></script>
@@ -28,7 +27,7 @@
2827
<script type='text/javascript' src='/js/agenda/agenda_helpers.js'></script>
2928
<script type='text/javascript' src='/js/agenda/agenda_property_utils.js'></script>
3029
<script type='text/javascript' src='/js/agenda/agendas_edit.js'></script>
31-
{% endblock scripts %}
30+
{% endblock js %}
3231

3332

3433
{% block start_content_table %}{% endblock %}

ietf/templates/meeting/landscape_edit.html

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
{# -*- html -*- #}
21
{% extends "base.html" %}
32
{% load ietf_filters %}
43
{# Copyright The IETF Trust 2007, All Rights Reserved #}
@@ -25,8 +24,7 @@
2524
<link rel='stylesheet' type='text/css' href='/css/agenda.css' />
2625
{% endblock pagehead %}
2726

28-
{% block scripts %}
29-
<script type='text/javascript' src='/js/lib/jquery-1.8.2.min.js'></script>
27+
{% block js %}
3028
<script type='text/javascript' src='/js/jquery-ui-1.9.0.custom/minified/jquery-ui.custom.min.js'></script>
3129
<script type='text/javascript' src='/js/jquery-ui-1.9.0.custom/minified/jquery.ui.widget.min.js'></script>
3230
<script type='text/javascript' src='/js/jquery-ui-1.9.0.custom/minified/jquery.ui.droppable.min.js'></script>
@@ -114,7 +112,7 @@
114112
<style type='text/css'>
115113

116114
</style>
117-
{% endblock scripts %}
115+
{% endblock js %}
118116

119117

120118
{% block start_content_table %}{% endblock %}

ietf/templates/meeting/properties_edit.html

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@
1313
<link rel='stylesheet' type='text/css' href='/css/agenda.css' />
1414
{% endblock pagehead %}
1515

16-
{% block scripts %}
17-
<script type='text/javascript' src='/js/lib/jquery-1.8.2.min.js'></script>
16+
{% block js %}
1817
<script type='text/javascript' src='/js/jquery-ui-1.9.0.custom/jquery-ui.custom.js'></script>
1918
<script type='text/javascript' src='/js/jquery-ui-1.9.0.custom/jquery.ui.widget.js'></script>
2019
<script type='text/javascript' src='/js/jquery-ui-1.9.0.custom/jquery.ui.droppable.js'></script>
@@ -28,7 +27,7 @@
2827
<script type='text/javascript' src='/js/agenda/agenda_helpers.js'></script>
2928
<script type='text/javascript' src='/js/agenda/agenda_property_utils.js'></script>
3029
<script type='text/javascript' src='/js/agenda/agenda_properties_edit.js'></script>
31-
{% endblock scripts %}
30+
{% endblock js %}
3231

3332
{% block start_content_table %}{% endblock %}
3433
{% block end_content_table %}{% endblock %}

ietf/templates/meeting/timeslot_edit.html

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,19 +13,16 @@
1313
<link rel='stylesheet' type='text/css' href='/css/agenda.css' />
1414
{% endblock pagehead %}
1515

16-
{% block scripts %}
17-
<script type='text/javascript' src='/js/lib/jquery-1.8.2.min.js'></script>
16+
{% block js %}
1817
<script type='text/javascript' src='/js/jquery-ui-1.9.0.custom/jquery-ui.custom.js'></script>
1918
<script type='text/javascript' src='/js/jquery-ui-1.9.0.custom/jquery.ui.widget.js'></script>
2019
<script type='text/javascript' src='/js/jquery-ui-1.9.0.custom/jquery.ui.droppable.js'></script>
2120
<script type='text/javascript' src='/js/jquery-ui-1.9.0.custom/jquery.ui.sortable.js'></script>
2221
<script type='text/javascript' src='/js/jquery-ui-1.9.0.custom/jquery.ui.accordion.js'></script>
2322
<script type='text/javascript' src='/js/jquery-ui-1.9.0.custom/jquery.ui.draggable.js'></script>
2423

25-
{% if server_mode %}
26-
{% ifnotequal server_mode "production" %}
27-
<script src="https://towtruck.mozillalabs.com/towtruck.js"></script>
28-
{% endifnotequal %}
24+
{% if server_mode and server_mode != "production" %}
25+
<script src="https://towtruck.mozillalabs.com/towtruck.js"></script>
2926
{% endif %}
3027

3128
{% dajaxice_js_import %}
@@ -67,7 +64,7 @@
6764
<style type='text/css'>
6865

6966
</style>
70-
{% endblock scripts %}
67+
{% endblock js %}
7168

7269

7370
{% block start_content_table %}{% endblock %}

0 commit comments

Comments
 (0)