Skip to content

Commit 3ecaf54

Browse files
committed
Pre-fill the review type when requesting a review
- Legacy-Id: 11798
1 parent 0e80851 commit 3ecaf54

1 file changed

Lines changed: 16 additions & 9 deletions

File tree

ietf/doc/views_review.py

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,15 @@ def request_review(request, name):
9696
if not can_request_review_of_doc(request.user, doc):
9797
return HttpResponseForbidden("You do not have permission to perform this action")
9898

99+
now = datetime.datetime.now()
100+
101+
lc_ends = None
102+
e = doc.latest_event(LastCallDocEvent, type="sent_last_call")
103+
if e and e.expires >= now:
104+
lc_ends = e.expires
105+
106+
scheduled_for_telechat = doc.telechat_date()
107+
99108
if request.method == "POST":
100109
form = RequestReviewForm(request.user, doc, request.POST)
101110

@@ -119,16 +128,14 @@ def request_review(request, name):
119128
return redirect('doc_view', name=doc.name)
120129

121130
else:
122-
form = RequestReviewForm(request.user, doc)
123-
124-
now = datetime.datetime.now()
125-
126-
lc_ends = None
127-
e = doc.latest_event(LastCallDocEvent, type="sent_last_call")
128-
if e and e.expires >= now:
129-
lc_ends = e.expires
131+
if lc_ends:
132+
review_type = "lc"
133+
elif scheduled_for_telechat:
134+
review_type = "telechat"
135+
else:
136+
review_type = "early"
130137

131-
scheduled_for_telechat = doc.telechat_date()
138+
form = RequestReviewForm(request.user, doc, initial={ "type": review_type })
132139

133140
return render(request, 'doc/review/request_review.html', {
134141
'doc': doc,

0 commit comments

Comments
 (0)