Skip to content

Commit 3c7d546

Browse files
committed
Swap order of event generation in previous commit.
- Legacy-Id: 4294
1 parent 6ef8b82 commit 3c7d546

1 file changed

Lines changed: 15 additions & 16 deletions

File tree

ietf/wgcharter/views.py

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -463,21 +463,6 @@ def approve(request, name):
463463

464464
close_open_ballots(charter, login)
465465

466-
# according to spec, 00-02 becomes 01, so copy file and record new revision
467-
try:
468-
old = os.path.join(charter.get_file_path(), '%s-%s.txt' % (charter.canonical_name(), charter.rev))
469-
new = os.path.join(charter.get_file_path(), '%s-%s.txt' % (charter.canonical_name(), next_approved_revision(charter.rev)))
470-
shutil.copy(old, new)
471-
except IOError:
472-
raise Http404("Charter text %s" % filename)
473-
474-
charter.rev = next_approved_revision(charter.rev)
475-
476-
e = NewRevisionDocEvent(doc=charter, by=login, type="new_revision")
477-
e.desc = "New version available: <b>%s-%s.txt</b>" % (charter.canonical_name(), charter.rev)
478-
e.rev = charter.rev
479-
e.save()
480-
481466
# approve
482467
e = DocEvent(doc=charter, by=login)
483468
e.type = "iesg_approved"
@@ -497,9 +482,23 @@ def approve(request, name):
497482

498483
e = log_state_changed(request, charter, login, prev_charter_state)
499484

485+
# according to spec, 00-02 becomes 01, so copy file and record new revision
486+
try:
487+
old = os.path.join(charter.get_file_path(), '%s-%s.txt' % (charter.canonical_name(), charter.rev))
488+
new = os.path.join(charter.get_file_path(), '%s-%s.txt' % (charter.canonical_name(), next_approved_revision(charter.rev)))
489+
shutil.copy(old, new)
490+
except IOError:
491+
raise Http404("Charter text %s" % filename)
492+
493+
e = NewRevisionDocEvent(doc=charter, by=login, type="new_revision")
494+
e.desc = "New version available: <b>%s-%s.txt</b>" % (charter.canonical_name(), charter.rev)
495+
e.rev = next_approved_revision(charter.rev)
496+
e.save()
497+
498+
charter.rev = e.rev
500499
charter.time = e.time
501500
charter.save()
502-
501+
503502
email_secretariat(request, wg, "state-%s" % new_charter_state.slug, change_description)
504503

505504
# send announcement

0 commit comments

Comments
 (0)