Skip to content

Commit 3bd2097

Browse files
committed
Customize mail sent to WG chairs requesting submission approval.
Added the domain of the tool to the url. Save the submitter info. Fixes ietf-tools#606 - Legacy-Id: 2876
1 parent c1c3781 commit 3bd2097

4 files changed

Lines changed: 30 additions & 7 deletions

File tree

ietf/submit/forms.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
from django import forms
88
from django.forms.fields import email_re
99
from django.conf import settings
10+
from django.contrib.sites.models import Site
1011
from django.template.loader import render_to_string
1112
from django.utils.html import mark_safe
1213

@@ -320,7 +321,7 @@ def send_confirmation_mail(self, request):
320321
{'draft': self.draft })
321322

322323
def save_submitter_info(self):
323-
TempIdAuthors.objects.create(
324+
return TempIdAuthors.objects.create(
324325
id_document_tag=self.draft.temp_id_document_tag,
325326
first_name=self.cleaned_data['first_name'],
326327
last_name=self.cleaned_data['last_name'],
@@ -465,4 +466,4 @@ def send_mail_to_secretariat(self, request):
465466
cc += [i.person.email()[1] for i in self.draft.group_acronym.wgchair_set.all()]
466467
cc = list(set(cc))
467468
send_mail(request, to_email, from_email, subject, 'submit/manual_post_mail.txt',
468-
{'form': self, 'draft': self.draft }, cc=cc)
469+
{'form': self, 'draft': self.draft, 'domain': Site.objects.get_current().domain }, cc=cc)

ietf/submit/views.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# Copyright The IETF Trust 2007, All Rights Reserved
22
from django.conf import settings
33
from django.core.urlresolvers import reverse
4+
from django.contrib.sites.models import Site
45
from django.http import HttpResponseRedirect, Http404, HttpResponseForbidden
56
from django.shortcuts import get_object_or_404
67
from django.shortcuts import render_to_response
@@ -91,6 +92,7 @@ def draft_status(request, submission_id, message=None):
9192
detail.save()
9293

9394
if detail.revision == '00' and not approved_detail:
95+
submitter = auto_post_form.save_submitter_info()
9496
subject = 'New draft waiting for approval: %s' % detail.filename
9597
from_email = settings.IDST_FROM_EMAIL
9698
to_email = []
@@ -99,8 +101,9 @@ def draft_status(request, submission_id, message=None):
99101
to_email = list(set(to_email))
100102
if to_email:
101103
metadata_form = MetaDataForm(draft=detail, validation=validation)
102-
send_mail(request, to_email, from_email, subject, 'submit/manual_post_mail.txt',
103-
{'form': metadata_form, 'draft': detail})
104+
send_mail(request, to_email, from_email, subject, 'submit/submission_approval.txt',
105+
{'submitter': submitter, 'form': metadata_form,
106+
'draft': detail, 'domain': Site.objects.get_current().domain})
104107
return HttpResponseRedirect(reverse(draft_status, None, kwargs={'submission_id': detail.submission_id}))
105108
else:
106109
auto_post_form.save(request)

ietf/templates/submit/manual_post_mail.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
Manual Posting Requested for following Internet-Draft:
1+
Manual Posting Requested for the following Internet-Draft:
22

3-
I-D Submission Tool URL: /submit/status/{{ draft.submission_id }}/
3+
I-D Submission Tool URL: http://{{ domain }}/submit/status/{{ draft.submission_id }}/
44

55
File name: {{ draft.filename }}
66
Submission date: {{ draft.submission_date }}
77
WG: {{ draft.wg|default:"Individual Submission" }}
8-
File size: {{ draft.filesize }}
8+
File size: {{ draft.filesize|filesizeformat }}
99

1010
Title: {{ draft.id_document_name }}
1111
Version: {{ draft.revision }}
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
WG chair approval is needed for posting of {{ draft.filename }}-{{ draft.revision }} draft
2+
3+
I-D Submission Tool URL: http://{{ domain }}/submit/status/{{ draft.submission_id }}/
4+
5+
File name: {{ draft.filename }}
6+
Submission date: {{ draft.submission_date }}
7+
WG: {{ draft.wg|default:"Individual Submission" }}
8+
File size: {{ draft.filesize|filesizeformat }}
9+
10+
Title: {{ draft.id_document_name }}
11+
Version: {{ draft.revision }}
12+
Creation date: {{ draft.id_document_name }}
13+
Pages: {{ draft.txt_page_count }}
14+
Abstract: {{ draft.abstract }}
15+
Submitter: {{ submitter.first_name }} {{ submitter.last_name }} <{{ submitter.email_address }}>
16+
17+
Author(s):
18+
{% for author in form.get_authors %}{{ author.first_name }} {{ author.last_name }} <{{ author.email.1 }}>
19+
{% endfor %}

0 commit comments

Comments
 (0)