Skip to content

Commit 38ee292

Browse files
committed
Remove some artificial updates of the document timestamp to ensure
that the code follows the protocol for dealing with history objects properly - Legacy-Id: 3304
1 parent e831dc3 commit 38ee292

1 file changed

Lines changed: 0 additions & 21 deletions

File tree

ietf/idrfc/views_ballot.py

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -313,9 +313,6 @@ def edit_positionREDESIGN(request, name):
313313
for e in added_events:
314314
e.save() # save them after the position is saved to get later id
315315

316-
doc.time = pos.time
317-
doc.save()
318-
319316
if request.POST.get("send_mail"):
320317
qstr = "?return_to_url=%s" % return_to_url
321318
if request.GET.get('ad'):
@@ -775,9 +772,6 @@ def lastcalltextREDESIGN(request, name):
775772
e.text = t
776773
e.save()
777774

778-
doc.time = e.time
779-
doc.save()
780-
781775
if "send_last_call_request" in request.POST:
782776
save_document_in_history(doc)
783777

@@ -800,9 +794,6 @@ def lastcalltextREDESIGN(request, name):
800794
if "regenerate_last_call_text" in request.POST:
801795
e = generate_last_call_announcement(request, doc)
802796

803-
doc.time = e.time
804-
doc.save()
805-
806797
# make sure form has the updated text
807798
form = LastCallTextForm(initial=dict(last_call_text=e.text))
808799

@@ -942,9 +933,6 @@ def ballot_writeupnotesREDESIGN(request, name):
942933
e.text = t
943934
e.save()
944935

945-
doc.time = e.time
946-
doc.save()
947-
948936
if "issue_ballot" in request.POST and approval:
949937
if has_role(request.user, "Area Director") and not doc.latest_event(BallotPositionDocEvent, ad=login, time__gte=started_process.time):
950938
# sending the ballot counts as a yes
@@ -966,9 +954,6 @@ def ballot_writeupnotesREDESIGN(request, name):
966954
e.desc = "Ballot has been issued by %s" % login.name
967955
e.save()
968956

969-
doc.time = e.time
970-
doc.save()
971-
972957
return render_to_response('idrfc/ballot_issued.html',
973958
dict(doc=doc,
974959
back_url=doc.get_absolute_url()),
@@ -1078,15 +1063,9 @@ def ballot_approvaltextREDESIGN(request, name):
10781063
e.text = t
10791064
e.save()
10801065

1081-
doc.time = e.time
1082-
doc.save()
1083-
10841066
if "regenerate_approval_text" in request.POST:
10851067
e = generate_approval_mail(request, doc)
10861068

1087-
doc.time = e.time
1088-
doc.save()
1089-
10901069
# make sure form has the updated text
10911070
form = ApprovalTextForm(initial=dict(approval_text=existing.text))
10921071

0 commit comments

Comments
 (0)