Skip to content

Commit 3854c83

Browse files
committed
Change things so that the reorder_by setting has an effect on the test ordering. It didn't before, as CoverageTest was a subclass of the earlier entries in the reorder_by setting.
- Legacy-Id: 12039
1 parent c11f3b5 commit 3854c83

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

ietf/utils/test_runner.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
import datetime
4646
import codecs
4747
import gzip
48+
import unittest
4849

4950
from coverage.report import Reporter
5051
from coverage.results import Numbers
@@ -53,7 +54,6 @@
5354

5455
from django.conf import settings
5556
from django.template import TemplateDoesNotExist
56-
from django.test import TestCase
5757
from django.test.runner import DiscoverRunner
5858
from django.core.management import call_command
5959
from django.core.urlresolvers import RegexURLResolver
@@ -226,7 +226,7 @@ def report(self):
226226
return result
227227

228228

229-
class CoverageTest(TestCase):
229+
class CoverageTest(unittest.TestCase):
230230

231231
def __init__(self, test_runner=None, **kwargs):
232232
self.runner = test_runner
@@ -507,7 +507,7 @@ def run_tests(self, test_labels, extra_tests=[], **kwargs):
507507
CoverageTest(test_runner=self, methodName='code_coverage_test'),
508508
]
509509

510-
self.reorder_by += (CoverageTest, ) # see to it that the coverage tests come last
510+
self.reorder_by += (unittest.TestCase, ) # see to it that the coverage tests come last
511511

512512
failures = super(IetfTestRunner, self).run_tests(test_labels, extra_tests=extra_tests, **kwargs)
513513

0 commit comments

Comments
 (0)