Skip to content

Commit 34cd150

Browse files
committed
Refactor templates inheritance
See ietf-tools#919 - Legacy-Id: 5160
1 parent 2a1f41e commit 34cd150

8 files changed

Lines changed: 28 additions & 25 deletions

File tree

ietf/nomcom/forms.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def get_group_or_404(year):
2828
nomcom__isnull=False)
2929

3030

31-
class BaseNomcomForm(forms.ModelForm):
31+
class BaseNomcomForm(object):
3232
def __unicode__(self):
3333
return self.as_div()
3434

@@ -172,12 +172,13 @@ def done(self, request, cleaned_data):
172172

173173

174174
class EditPublicKeyForm(forms.ModelForm):
175+
fieldsets = [('Edit the public key of NomCom', ('public_key',))]
176+
175177
class Meta:
176178
model = NomCom
177-
fields = ('public_key',)
178179

179180

180-
class NominateForm(BaseNomcomForm):
181+
class NominateForm(BaseNomcomForm, forms.ModelForm):
181182
comments = forms.CharField(label='Comments', widget=forms.Textarea())
182183

183184
fieldsets = [('Candidate Nomination', ('position', 'candidate_name', 'candidate_email', 'candidate_phone', 'comments'))]
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
{% extends "nomcom/nomcom_base.html" %}
1+
{% extends "nomcom/nomcom_public_base.html" %}
22

3-
{% block title %} {{ nomcom }} - Provide comments{% endblock %}
3+
{% block subtitle %} - Provide comments {% endblock %}

ietf/templates/nomcom/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{% extends "nomcom/nomcom_base.html" %}
1+
{% extends "nomcom/nomcom_public_base.html" %}
22

33
{% block subtitle %} - Home {% endblock %}
44

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,3 @@
11
{% extends "base.html" %}
22

33
{% block title %}Nomcom {{ year }}{% block subtitle %}{% endblock %}{% endblock %}
4-
5-
{% block content %}
6-
7-
<h1>Nomcom {{ year }} Pages</h1>
8-
9-
<div class="ietf-navset">
10-
{% if selected == "index" %}<span class="selected">Home</span>{% else %}<a href="{% url nomcom_index year %}">Home</a>{% endif %} |
11-
{% if selected == "nominate" %}<span class="selected">Nominate</span>{% else %}<a href="{% url nomcom_nominate year %}">Nominate</a>{% endif %} |
12-
{% if selected == "requirements" %}<span class="selected">Requirements</span>{% else %}<a href="{% url nomcom_requirements year %}">Requirements</a>{% endif %} |
13-
{% if selected == "questionnaires" %}<span class="selected">Questionnaires</span>{% else %}<a href="{% url nomcom_questionnaires year %}">Questionnaires</a>{% endif %} |
14-
{% if selected == "comments" %}<span class="selected">Provide Comments</span>{% else %}<a href="{% url nomcom_comments year %}">Provide Comments</a>{% endif %}
15-
</div>
16-
17-
{% block nomcom_content %}
18-
{% endblock %}
19-
{% endblock %}
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
{% extends "nomcom/nomcom_base.html" %}
2+
3+
{% block content %}
4+
5+
<h1>Nomcom {{ year }} Pages</h1>
6+
7+
<div class="ietf-navset">
8+
{% if selected == "index" %}<span class="selected">Home</span>{% else %}<a href="{% url nomcom_index year %}">Home</a>{% endif %} |
9+
{% if selected == "nominate" %}<span class="selected">Nominate</span>{% else %}<a href="{% url nomcom_nominate year %}">Nominate</a>{% endif %} |
10+
{% if selected == "requirements" %}<span class="selected">Requirements</span>{% else %}<a href="{% url nomcom_requirements year %}">Requirements</a>{% endif %} |
11+
{% if selected == "questionnaires" %}<span class="selected">Questionnaires</span>{% else %}<a href="{% url nomcom_questionnaires year %}">Questionnaires</a>{% endif %} |
12+
{% if selected == "comments" %}<span class="selected">Provide Comments</span>{% else %}<a href="{% url nomcom_comments year %}">Provide Comments</a>{% endif %}
13+
</div>
14+
15+
{% block nomcom_content %}
16+
{% endblock %}
17+
18+
{% endblock %}

ietf/templates/nomcom/nominate.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{% extends "nomcom/nomcom_base.html" %}
1+
{% extends "nomcom/nomcom_public_base.html" %}
22

33
{% block subtitle %} - Nominate{% endblock %}
44

ietf/templates/nomcom/questionnaires.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{% extends "nomcom/nomcom_base.html" %}
1+
{% extends "nomcom/nomcom_public_base.html" %}
22

33
{% block pagehead %}
44
{{ block.super }}

ietf/templates/nomcom/requirements.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{% extends "nomcom/nomcom_base.html" %}
1+
{% extends "nomcom/nomcom_public_base.html" %}
22

33
{% block pagehead %}
44
{{ block.super }}

0 commit comments

Comments
 (0)