Skip to content

Commit 341811e

Browse files
committed
Patched a bug in BeautifulSoup (discovered by PyFlakes) and quietened the remaining nonconsequential comments from PyFlakes regarding BeautifulSoup
- Legacy-Id: 290
1 parent 7c60b32 commit 341811e

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

ietf/contrib/BeautifulSoup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -835,7 +835,7 @@ def isString(s):
835835
"""Convenience method that works with all 2.x versions of Python
836836
to determine whether or not something is stringlike."""
837837
try:
838-
return isinstance(s, unicode) or isintance(s, basestring)
838+
return isinstance(s, unicode) or isinstance(s, basestring)
839839
except NameError:
840840
return isinstance(s, str)
841841

test/pyflakes.exclude

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,15 @@ ietf/urls.py:1: 'handler500' imported but unused
66
ietf/urls.py:1: 'handler404' imported but unused
77
ietf/ipr/views.py:6: 'new' imported but unused
88
ietf/contrib/__init__.py:1: 'form_decorator' imported but unused
9+
ietf/contrib/__init__.py:2: 'BeautifulSoup' imported but unused
910
ietf/utils/__init__.py:1: 'flattenl' imported but unused
1011
ietf/utils/__init__.py:1: 'orl' imported but unused
1112
ietf/utils/__init__.py:2: 'log' imported but unused
1213
ietf/utils/__init__.py:3: 'FKAsOneToOne' imported but unused
1314
ietf/utils/__init__.py:5: 'TextSoup' imported but unused
1415
ietf/utils/__init__.py:5: 'soup2text' imported but unused
1516
ietf/idtracker/templatetags/ietf_filters.py:8: redefinition of unused 'emailutils' from line 6
17+
ietf/contrib/BeautifulSoup.py:59: redefinition of unused 'name2codepoint' from line 57
18+
ietf/contrib/BeautifulSoup.py:1497: redefinition of unused 'chardet' from line 1493
19+
ietf/contrib/BeautifulSoup.py:1504: 'cjkcodecs' imported but unused
20+
ietf/contrib/BeautifulSoup.py:1508: 'iconv_codec' imported but unused

0 commit comments

Comments
 (0)