Skip to content

Commit 3205b8f

Browse files
committed
Link to personal profile pages from group photo pages also when no photo is available -- the profile pages now contains more than just the photo.
- Legacy-Id: 15409
1 parent 2f771e1 commit 3205b8f

2 files changed

Lines changed: 28 additions & 28 deletions

File tree

ietf/templates/group/all_photos.html

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,18 @@ <h1>{{ group_type | upper }} {{ role }} Photos</h1>
2828
{% for person_with_groups in person_groups %}
2929
<li>
3030
<div class="well photo-thumbnail">
31-
{% if person_with_groups.grouper.photo %}<a href="{% url 'ietf.person.views.profile' email_or_name=person_with_groups.grouper.plain_name %}">{% endif %}
32-
<div>
33-
{% if person_with_groups.grouper.photo_thumb %}
34-
<img width=100 src="{{person_with_groups.grouper.photo_thumb.url}}" alt="Photo of {{person_with_groups.grouper.name}}"/>
35-
{% else %}
36-
<img width=100 src="{{ MEDIA_URL }}photo/nopictureavailable.jpg" alt="No picture available"/>
37-
{% endif %}
38-
</div>
39-
<div class="photo-name">
40-
<strong>{{person_with_groups.grouper.plain_name}}</strong>
41-
</div>
42-
{% if person_with_groups.grouper.photo %}</a>{% endif %}
31+
<a href="{% url 'ietf.person.views.profile' email_or_name=person_with_groups.grouper.plain_name %}">
32+
<div>
33+
{% if person_with_groups.grouper.photo_thumb %}
34+
<img width=100 src="{{person_with_groups.grouper.photo_thumb.url}}" alt="Photo of {{person_with_groups.grouper.name}}"/>
35+
{% else %}
36+
<img width=100 src="{{ MEDIA_URL }}photo/nopictureavailable.jpg" alt="No picture available"/>
37+
{% endif %}
38+
</div>
39+
<div class="photo-name">
40+
<strong>{{person_with_groups.grouper.plain_name}}</strong>
41+
</div>
42+
</a>
4343
<div class="photo-role-list">
4444
{% for role in person_with_groups.list %}
4545
<a href="{% url 'ietf.group.views.group_home' acronym=role.group.acronym %}">{{role.group.acronym}}</a>

ietf/templates/group/group_photos.html

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -26,22 +26,22 @@ <h1>{{ group }} ({{group.acronym}}) Photos</h1>
2626
<ul class="list-inline">
2727
{% regroup role_name.list by person as person_groups %}
2828
{% for person_with_groups in person_groups %}
29-
<li>
30-
{% if person_with_groups.grouper.photo %}<a href="{% url 'ietf.person.views.profile' email_or_name=person_with_groups.grouper.plain_name %}">{% endif %}
31-
<div class="well photo-thumbnail">
32-
<div>
33-
{% if person_with_groups.grouper.photo_thumb %}
34-
<img width=100 src="{{person_with_groups.grouper.photo_thumb.url}}" alt="Photo of {{person_with_groups.grouper.name}}" />
35-
{% else %}
36-
<img width=100 src="{{ MEDIA_URL }}photo/nopictureavailable.jpg" alt="No picture available"/>
37-
{% endif %}
38-
</div>
39-
<div >
40-
<strong>{{person_with_groups.grouper.plain_name}}</strong>
41-
</div>
42-
</div>
43-
{% if person_with_groups.grouper.photo %}</a>{% endif %}
44-
</li>
29+
<li>
30+
<a href="{% url 'ietf.person.views.profile' email_or_name=person_with_groups.grouper.plain_name %}">
31+
<div class="well photo-thumbnail">
32+
<div>
33+
{% if person_with_groups.grouper.photo_thumb %}
34+
<img width=100 src="{{person_with_groups.grouper.photo_thumb.url}}" alt="Photo of {{person_with_groups.grouper.name}}" />
35+
{% else %}
36+
<img width=100 src="{{ MEDIA_URL }}photo/nopictureavailable.jpg" alt="No picture available"/>
37+
{% endif %}
38+
</div>
39+
<div >
40+
<strong>{{person_with_groups.grouper.plain_name}}</strong>
41+
</div>
42+
</div>
43+
</a>
44+
</li>
4545
{% endfor %}
4646
</ul>
4747
</div>

0 commit comments

Comments
 (0)