Skip to content

Commit 317c0ce

Browse files
committed
Fix bug in copying docs attribute when resetting charter milestones,
accidentally named the new milestone the same as the old - Legacy-Id: 4579
1 parent bcf6ef0 commit 317c0ce

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

ietf/wginfo/milestones.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -343,17 +343,17 @@ def reset_charter_milestones(request, acronym):
343343

344344
# add current
345345
for m in current_milestones.filter(id__in=milestone_ids):
346-
m = GroupMilestone.objects.create(group=m.group,
347-
state_id="charter",
348-
desc=m.desc,
349-
due=m.due,
350-
resolved=m.resolved,
351-
)
352-
m.docs = m.docs.all()
346+
new = GroupMilestone.objects.create(group=m.group,
347+
state_id="charter",
348+
desc=m.desc,
349+
due=m.due,
350+
resolved=m.resolved,
351+
)
352+
new.docs = m.docs.all()
353353

354354
DocEvent.objects.create(type="changed_charter_milestone",
355355
doc=group.charter,
356-
desc='Added milestone "%s", due %s, from current group milestones' % (m.desc, m.due.strftime("%Y-%m-%d")),
356+
desc='Added milestone "%s", due %s, from current group milestones' % (new.desc, new.due.strftime("%Y-%m-%d")),
357357
by=login,
358358
)
359359

0 commit comments

Comments
 (0)