Submission check symbols should only be shown when the check returned a result, not otherwise.

 - Legacy-Id: 10995

Author: levkowetz

ietf/submit/admin.py

@@ -28,6 +28,7 @@ def draft_link(self, instance):
 class SubmissionCheckAdmin(admin.ModelAdmin):
     list_display = ['submission', 'time', 'checker', 'passed', 'errors', 'warnings', 'items']
     raw_id_fields = ['submission']
+    search_fields = ['submission__name']
 admin.site.register(SubmissionCheck, SubmissionCheckAdmin)
 
 class PreapprovalAdmin(admin.ModelAdmin):

ietf/templates/doc/document_draft.html

@@ -77,11 +77,13 @@
 	    (latest revision {{ latest_revision.time|date:"Y-m-d" }})
 	  {% endif %}
 	  {% for check in doc.submission.checks.all %}
-	     {% if check.errors or check.warnings %}
-		<span class="checker-warning" title="Submission {{check.checker|title}} returned warnings or errors.">{{ check.symbol|safe }}</span>
-	     {% else %}
-		<span class="checker-success" title="Submission {{check.checker|title}} passed">{{ check.symbol|safe }}</span>
-	     {% endif %}
+	     {% if check.passed != None and check.symbol.strip %}
+		 {% if check.errors or check.warnings %}
+		    <span class="checker-warning" title="Submission {{check.checker|title}} returned warnings or errors.">{{ check.symbol|safe }}</span>
+		 {% else %}
+		    <span class="checker-success" title="Submission {{check.checker|title}} passed">{{ check.symbol|safe }}</span>
+		 {% endif %}
+	      {% endif %}
 	  {% endfor %}
 	</td>
       </tr>

ietf/templates/doc/search/search_result_row.html

@@ -60,12 +60,12 @@
     </span>
 
     {% for check in doc.submission.checks.all %}
-      {% if check.symbol.strip %}
-       {% if check.errors or check.warnings %}
-	  <span class="checker-warning pull-right" title="{{check.checker|title}} returned warnings or errors.">{{ check.symbol|safe }}</span>
-       {% else %}
-	  <span class="checker-success pull-right" title="{{check.checker|title}} passed">{{ check.symbol|safe }}</span>
-       {% endif %}
+      {% if check.passed != None and check.symbol.strip %}
+	{% if check.errors or check.warnings %}
+	   <span class="checker-warning pull-right" title="{{check.checker|title}} returned warnings or errors.">{{ check.symbol|safe }}</span>
+	{% else %}
+	   <span class="checker-success pull-right" title="{{check.checker|title}} passed">{{ check.symbol|safe }}</span>
+	{% endif %}
       {% endif %}
     {% endfor %}