Skip to content

Commit 2bae863

Browse files
committed
Show session details for interims as well as ietf meetings. Commit ready for merge.
- Legacy-Id: 10733
1 parent a0457c7 commit 2bae863

4 files changed

Lines changed: 18 additions & 9 deletions

File tree

ietf/meeting/helpers.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -106,15 +106,18 @@ def get_wg_list(assignments):
106106
return Group.objects.filter(acronym__in = set(wg_name_list)).order_by('parent__acronym','acronym')
107107

108108

109-
def get_meetings(num=None):
109+
def get_meetings(num=None,type_in=['ietf',]):
110+
meetings = Meeting.objects
111+
if type_in:
112+
meetings = meetings.filter(type__in=type_in)
110113
if num == None:
111-
meetings = Meeting.objects.filter(type="ietf").order_by("-date")
114+
meetings = meetings.order_by("-date")
112115
else:
113-
meetings = Meeting.objects.filter(type="ietf", number=num)
116+
meetings = meetings.filter(number=num)
114117
return meetings
115118

116-
def get_meeting(num=None):
117-
meetings = get_meetings(num)
119+
def get_meeting(num=None,type_in=['ietf',]):
120+
meetings = get_meetings(num,type_in)
118121
if meetings.exists():
119122
return meetings.first()
120123
else:

ietf/meeting/urls.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
from ietf.meeting import ajax
88

99
safe_for_all_meeting_types = [
10+
url(r'^session/(?P<acronym>[A-Za-z0-9_\-\+]+)/$', views.session_details),
1011
]
1112

1213
type_ietf_only_patterns = [
@@ -37,7 +38,6 @@
3738
url(r'^sessions.json', ajax.sessions_json),
3839
url(r'^session/(?P<sessionid>\d+).json', ajax.session_json),
3940
url(r'^session/(?P<sessionid>\d+)/constraints.json', ajax.session_constraints),
40-
url(r'^session/(?P<acronym>[A-Za-z0-9_\-\+]+)/$', views.session_details),
4141
url(r'^constraint/(?P<constraintid>\d+).json', ajax.constraint_json),
4242
url(r'^json$', ajax.meeting_json),
4343
]
@@ -61,6 +61,7 @@
6161
url(r'^(?P<meeting_num>\d+)/materials.html$', views.materials),
6262
url(r'^requests.html$', RedirectView.as_view(url='/meeting/requests', permanent=True)),
6363
url(r'^(?P<num>\d+)/requests.html$', RedirectView.as_view(url='/meeting/%(num)s/requests', permanent=True)),
64+
url(r'^(?P<num>[A-Za-z0-9._+-]+)/', include(safe_for_all_meeting_types)),
6465
# The optionals have to go first, otherwise the agenda/(owner)/(name)/ patterns match things they shouldn't
6566
url(r'^(?:(?P<num>\d+)/)?', include(type_ietf_only_patterns_id_optional)),
6667
url(r'^(?P<num>\d+)/', include(type_ietf_only_patterns)),

ietf/meeting/views.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -826,7 +826,7 @@ def meeting_requests(request, num=None):
826826
"groups_not_meeting": groups_not_meeting})
827827

828828
def session_details(request, num, acronym ):
829-
meeting = get_meeting(num)
829+
meeting = get_meeting(num=num,type_in=None)
830830
sessions = Session.objects.filter(meeting=meeting,group__acronym=acronym,type__in=['session','plenary','other'])
831831

832832
if not sessions:
@@ -847,7 +847,12 @@ def sort_key(session):
847847
for session in sessions:
848848

849849
ss = session.timeslotassignments.filter(schedule=meeting.agenda).order_by('timeslot__time')
850-
session.time = ', '.join(x.timeslot.time.strftime("%A %b-%d %H%M") for x in ss) if ss else 'Not yet scheduled'
850+
if ss:
851+
session.time = ', '.join(x.timeslot.time.strftime("%A %b-%d-%Y %H%M") for x in ss)
852+
elif session.meeting.type_id=='interim':
853+
session.time = session.meeting.date.strftime("%A %b-%d-%Y")
854+
else:
855+
session.time = 'Not yet scheduled'
851856

852857
# TODO FIXME Deleted materials shouldn't be in the sessionpresentation_set
853858
session.filtered_sessionpresentation_set = [p for p in session.sessionpresentation_set.all() if p.document.get_state_slug(p.document.type_id)!='deleted']

ietf/templates/group/meetings-row.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
</td>
2222
<td>{% if s.minutes %}<a href="{{ s.minutes.get_absolute_url }}">Minutes</a>{% endif %}</td>
2323
<td>{% if s.agenda %}<a href="{{ s.agenda.get_absolute_url }}">Agenda</a>{% endif %}</td>
24-
<td>{% if s.meeting.type.slug == 'ietf' %}<a href="{% url 'ietf.meeting.views.session_details' num=s.meeting.number acronym=s.group.acronym %}">Materials</a>{% endif %}</td>
24+
<td><a href="{% url 'ietf.meeting.views.session_details' num=s.meeting.number acronym=s.group.acronym %}">Materials</a></td>
2525
{% endfor %}
2626
</tbody>
2727
</table>

0 commit comments

Comments
 (0)