Skip to content

Commit 2bacdd3

Browse files
committed
Merged in [13500] from rjsparks@nostrum.com:
Provide assigned dates on review team reviewers page. Fixes ietf-tools#2304. Related to ietf-tools#2305. - Legacy-Id: 13518 Note: SVN reference [13500] has been migrated to Git commit e422717
1 parent d31c589 commit 2bacdd3

3 files changed

Lines changed: 7 additions & 6 deletions

File tree

ietf/group/views_review.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ def reviewer_overview(request, acronym, group_type=None):
168168
latest_reqs = []
169169
for d in req_data:
170170
if d.state in ["requested", "accepted"] or len(latest_reqs) < MAX_CLOSED_REQS + open_reqs:
171-
latest_reqs.append((d.req_pk, d.doc, d.reviewed_rev, d.deadline,
171+
latest_reqs.append((d.req_pk, d.doc, d.reviewed_rev, d.assigned_time, d.deadline,
172172
review_state_by_slug.get(d.state),
173173
int(math.ceil(d.assignment_to_closure_days)) if d.assignment_to_closure_days is not None else None))
174174
person.latest_reqs = latest_reqs

ietf/review/utils.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ def days_needed_to_fulfill_min_interval_for_reviewers(team):
162162
return res
163163

164164
ReviewRequestData = namedtuple("ReviewRequestData", [
165-
"req_pk", "doc", "doc_pages", "req_time", "state", "deadline", "reviewed_rev", "result", "team", "reviewer",
165+
"req_pk", "doc", "doc_pages", "req_time", "state", "assigned_time", "deadline", "reviewed_rev", "result", "team", "reviewer",
166166
"late_days",
167167
"request_to_assignment_days", "assignment_to_closure_days", "request_to_closure_days"])
168168

@@ -225,7 +225,7 @@ def positive_days(time_from, time_to):
225225
assignment_to_closure_days = positive_days(assigned_time, closed_time)
226226
request_to_closure_days = positive_days(requested_time, closed_time)
227227

228-
d = ReviewRequestData(req_pk, doc, doc_pages, req_time, state, deadline, reviewed_rev, result, team, reviewer,
228+
d = ReviewRequestData(req_pk, doc, doc_pages, req_time, state, assigned_time, deadline, reviewed_rev, result, team, reviewer,
229229
late_days, request_to_assignment_days, assignment_to_closure_days,
230230
request_to_closure_days)
231231

@@ -241,7 +241,7 @@ def aggregate_raw_review_request_stats(review_request_data, count=None):
241241
assignment_to_closure_days_list = []
242242
assignment_to_closure_days_count = 0
243243

244-
for (req_pk, doc, doc_pages, req_time, state, deadline, reviewed_rev, result, team, reviewer,
244+
for (req_pk, doc, doc_pages, req_time, state, assigned_time, deadline, reviewed_rev, result, team, reviewer,
245245
late_days, request_to_assignment_days, assignment_to_closure_days, request_to_closure_days) in review_request_data:
246246
if count == "pages":
247247
c = doc_pages

ietf/templates/group/reviewer_overview.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ <h2>Reviewers</h2>
2929
<thead>
3030
<tr>
3131
<th>Reviewer</th>
32-
<th>Deadline/state/time between assignment and closure for latest assignments</th>
32+
<th>Assigned/Deadline/state/time between assignment and closure for latest assignments</th>
3333
<th>Settings</th>
3434
</tr>
3535
</thead>
@@ -42,8 +42,9 @@ <h2>Reviewers</h2>
4242
<td>{% if person.settings_url %}<a href="{{ person.settings_url }}">{% endif %}{{ person }}{% if person.settings_url %}</a>{% endif %}</td>
4343
<td>
4444
<table class="simple-table">
45-
{% for req_pk, doc_name, reviewed_rev, deadline, state, assignment_to_closure_days in person.latest_reqs %}
45+
{% for req_pk, doc_name, reviewed_rev, assigned_time, deadline, state, assignment_to_closure_days in person.latest_reqs %}
4646
<tr>
47+
<td>{{ assigned_time|date }}</td>
4748
<td><a href="{% url "ietf.doc.views_review.review_request" name=doc_name request_id=req_pk %}">{{ deadline|date }}</a></td>
4849
<td>
4950
<span class="label label-{% if state.slug == "completed" or state.slug == "part-completed" %}success{% elif state.slug == "no-response" %}danger{% elif state.slug == "overtaken" %}warning{% elif state.slug == "requested" or state.slug == "accepted" %}primary{% else %}default{% endif %}">{{ state.name }}</span>

0 commit comments

Comments
 (0)