Skip to content

Commit 2a1f902

Browse files
committed
Rewrite error handling in get_document_content to use a with statement
instead of finally - Legacy-Id: 7837
1 parent 88cf68d commit 2a1f902

1 file changed

Lines changed: 4 additions & 7 deletions

File tree

ietf/doc/utils.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -211,16 +211,13 @@ def add_links_in_new_revision_events(doc, events, diff_revisions):
211211

212212

213213
def get_document_content(key, filename, split=True, markup=True):
214-
f = None
215214
try:
216-
f = open(filename, 'rb')
217-
raw_content = f.read()
218-
except IOError:
215+
with open(filename, 'rb') as f:
216+
raw_content = f.read()
217+
except IOError as e:
219218
error = "Error; cannot read ("+key+")"
220219
return error
221-
finally:
222-
if f:
223-
f.close()
220+
224221
if markup:
225222
return markup_txt.markup(raw_content, split)
226223
else:

0 commit comments

Comments
 (0)