Skip to content

Commit 29567ad

Browse files
committed
Merged in [12835] from rcross@amsl.com:
Fixes ietf-tools#2202. Interim sessions appear unordered. Switch templates to use ordered assignments() related object manager. Also removed now unused template filters. - Legacy-Id: 12839 Note: SVN reference [12835] has been migrated to Git commit 8607be0
2 parents 3949616 + 8607be0 commit 29567ad

3 files changed

Lines changed: 9 additions & 19 deletions

File tree

ietf/doc/templatetags/ietf_filters.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -571,16 +571,6 @@ def document_content(doc):
571571
path = os.path.join(doc.get_file_path(),doc.filename_with_rev())
572572
return get_document_content(doc.name,path,markup=False)
573573

574-
@register.filter
575-
def session_start_time(session):
576-
timeslot = session.official_timeslotassignment().timeslot
577-
return timeslot.time
578-
579-
@register.filter
580-
def session_end_time(session):
581-
timeslot = session.official_timeslotassignment().timeslot
582-
return timeslot.time + timeslot.duration
583-
584574
@register.filter
585575
def format_timedelta(timedelta):
586576
s = timedelta.seconds

ietf/templates/meeting/interim_announcement.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{% load ietf_filters %}{% if is_change %}MEETING DETAILS HAVE CHANGED. SEE LATEST DETAILS BELOW.
22

33
{% endif %}The {{ group.name }} ({{ group.acronym }}) {% if group.type.slug == "rg" %}Research Group{% elif group.state.slug == "active" %}Working Group{% elif group.state.slug == 'bof' %}BOF{% endif %} will hold
4-
{% if meeting.session_set.count == 1 %}a{% if meeting.city %}n {% else %} virtual {% endif %}interim meeting on {{ meeting.date }} from {{ meeting.session_set.first | session_start_time | date:"H:i" }} to {{ meeting.session_set.first | session_end_time | date:"H:i" }} {{ meeting.time_zone }}.
4+
{% if meeting.session_set.count == 1 %}a{% if meeting.city %}n {% else %} virtual {% endif %}interim meeting on {{ meeting.date }} from {{ meeting.agenda.assignments.first.timeslot.time | date:"H:i" }} to {{ meeting.agenda.assignments.first.timeslot.end_time | date:"H:i" }} {{ meeting.time_zone }}.
55
{% else %}a multi-day {% if not meeting.city %}virtual {% endif %}interim meeting.
66

7-
{% for session in meeting.session_set.all %}Session {{ forloop.counter }}:
8-
{{ session | session_start_time | date:"Y-m-d" }} {{ session | session_start_time | date:"H:i" }} to {{ session | session_end_time | date:"H:i" }} {{ meeting.time_zone }}
7+
{% for assignment in meeting.agenda.assignments.all %}Session {{ forloop.counter }}:
8+
{{ assignment.timeslot.time | date:"Y-m-d" }} {{ assignment.timeslot.time | date:"H:i" }} to {{ assignment.timeslot.end_time | date:"H:i" }} {{ meeting.time_zone }}
99
{% endfor %}{% endif %}
1010
{% if meeting.city %}Meeting Location:
1111
{{ meeting.city }}, {{ meeting.country }}

ietf/templates/meeting/interim_request_details.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,18 @@ <h1>Interim Meeting Request Details</h1>
2626
<dd>{{ meeting.country }}</dd>
2727
<dt>Timezone</dt>
2828
<dd>{{ meeting.time_zone }}</dd>
29-
{% for session in sessions %}
29+
{% for assignment in meeting.agenda.assignments.all %}
3030
<br>
3131
<dt>Date</dt>
32-
<dd>{{ session.official_timeslotassignment.timeslot.time|date:"Y-m-d" }}
32+
<dd>{{ assignment.timeslot.time|date:"Y-m-d" }}
3333
<dt>Start Time</dt>
34-
<dd>{{ session.official_timeslotassignment.timeslot.time|date:"H:i" }}
34+
<dd>{{ assignment.timeslot.time|date:"H:i" }}
3535
<dt>Duration</dt>
36-
<dd>{{ session.requested_duration|format_timedelta }}
36+
<dd>{{ assignment.session.requested_duration|format_timedelta }}
3737
<dt>Remote Instructions</dt>
38-
<dd>{{ session.remote_instructions }}
38+
<dd>{{ assignment.session.remote_instructions }}
3939
<dt>Additional Info</dt>
40-
<dd>{{ session.agenda_note }}</dd>
40+
<dd>{{ assignment.session.agenda_note }}</dd>
4141
{% endfor %}
4242
</dl>
4343

0 commit comments

Comments
 (0)