Skip to content

Commit 27d9c18

Browse files
committed
Add personal review overview page to the menu
- Legacy-Id: 12083
1 parent a177dc6 commit 27d9c18

3 files changed

Lines changed: 9 additions & 4 deletions

File tree

ietf/ietfauth/utils.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,13 +69,14 @@ def has_role(user, role_names, *args, **kwargs):
6969
"Nomcom": Q(person=person, group__type="nomcom", group__acronym__icontains=kwargs.get('year', '0000')),
7070
"Liaison Manager": Q(person=person,name="liaiman",group__type="sdo",group__state="active", ),
7171
"Authorized Individual": Q(person=person,name="auth",group__type="sdo",group__state="active", ),
72+
"Reviewer": Q(person=person, name="reviewer", group__state="active"),
7273
}
7374

7475
filter_expr = Q()
7576
for r in role_names:
7677
filter_expr |= role_qs[r]
7778

78-
user.roles_check_cache[key] = bool(Role.objects.filter(filter_expr)[:1])
79+
user.roles_check_cache[key] = bool(Role.objects.filter(filter_expr).exists())
7980

8081
return user.roles_check_cache[key]
8182

ietf/templates/base/menu_user.html

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@
2525
<li><a href="{% url "ietf.ietfauth.views.create_account" %}">{% if request.user.is_authenticated %}Manage account{% else %}New account{% endif %}</a></li>
2626
<li><a href="{%url "ietf.cookies.views.preferences" %}" rel="nofollow">Preferences</a></li>
2727

28+
{% if user|has_role:"Reviewer" %}
29+
<li><a href="{% url "ietf.ietfauth.views.review_overview" %}">My reviews</a></li>
30+
{% endif %}
31+
2832
{% if user|has_role:"Area Director" %}
2933
{% if flavor == "top" %}<li class="divider hidden-xs"></li>{% endif %}
3034
<li {%if flavor == "top" %}class="dropdown-header hidden-xs"{% else %}class="nav-header"{% endif %}>AD dashboard</li>

ietf/templates/ietfauth/review_overview.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ <h2>Assigned reviews</h2>
4646
{% endif %}
4747

4848

49-
<h2>Latest closed requests</h2>
49+
<h2>Latest closed review requests</h2>
5050

5151
{% if closed_review_requests %}
5252
<table class="table table-condensed table-striped">
@@ -77,7 +77,7 @@ <h2>Latest closed requests</h2>
7777
</tbody>
7878
</table>
7979
{% else %}
80-
<p>Did not find any closed requests assigned to you.</p>
80+
<p>Did not find any closed review requests assigned to you.</p>
8181
{% endif %}
8282

8383

@@ -134,7 +134,7 @@ <h2>Settings for {{ t }}</h2>
134134
</tr>
135135
<tr>
136136
<th>Filter regexp</th>
137-
<td>{{ t.reviewer_settings.filter_re|default:"(None)" }}</td>
137+
<td><code>{{ t.reviewer_settings.filter_re|default:"(None)" }}</code></td>
138138
</tr>
139139
<tr>
140140
<th>Unavailable periods</th>

0 commit comments

Comments
 (0)