Skip to content

Commit 275f82d

Browse files
committed
normalize secr settings variable names
- Legacy-Id: 5449
1 parent 806c142 commit 275f82d

8 files changed

Lines changed: 41 additions & 41 deletions

File tree

ietf/secr/meetings/blue_sheets.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
'''
1717

1818
def create_blue_sheets(meeting, groups):
19-
file = open(settings.BLUE_SHEET_PATH, 'w')
19+
file = open(settings.SECR_BLUE_SHEET_PATH, 'w')
2020

2121
header = '''{\\rtf1\\ansi\\ansicpg1252\\uc1 \\deff0\\deflang1033\\deflangfe1033
2222
{\\fonttbl{\\f0\\froman\\fcharset0\\fprq2{\\*\\panose 02020603050405020304}Times New Roman;}}
@@ -85,4 +85,4 @@ def create_blue_sheets(meeting, groups):
8585
file.write(footer)
8686

8787
file.write('\n}')
88-
file.close()
88+
file.close()

ietf/secr/meetings/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ def blue_sheet(request, meeting_id):
259259
'''
260260
meeting = get_object_or_404(Meeting, number=meeting_id)
261261

262-
url = settings.BLUE_SHEET_URL
262+
url = settings.SECR_BLUE_SHEET_URL
263263

264264
if request.method == 'POST':
265265
form = UploadBlueSheetForm(request.POST,request.FILES)

ietf/secr/middleware/secauth.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,20 +9,20 @@
99
class SecAuthMiddleware(object):
1010
"""
1111
Middleware component that performs custom auth check for every
12-
request except those excluded by SEC_AUTH_UNRESTRICTED_URLS.
12+
request except those excluded by SECR_AUTH_UNRESTRICTED_URLS.
1313
1414
Since authentication is performed externally at the apache level
1515
REMOTE_USER should contain the name of the authenticated
1616
user. If the user is a secretariat than access is granted.
1717
Otherwise return a 401 error page.
1818
1919
To use, add the class to MIDDLEWARE_CLASSES and define
20-
SEC_AUTH_UNRESTRCITED_URLS in your settings.py.
20+
SECR_AUTH_UNRESTRICTED_URLS in your settings.py.
2121
2222
The following example allows access to anything under "/interim/"
2323
to non-secretariat users:
2424
25-
SEC_AUTH_UNRESTRCITED_URLS = (
25+
SECR_AUTH_UNRESTRICTED_URLS = (
2626
(r'^/interim/'),
2727
2828
Also sets custom request attributes:
@@ -35,7 +35,7 @@ class SecAuthMiddleware(object):
3535

3636
def __init__(self):
3737
self.unrestricted = [re.compile(pattern) for pattern in
38-
settings.SEC_AUTH_UNRESTRICTED_URLS]
38+
settings.SECR_AUTH_UNRESTRICTED_URLS]
3939

4040
def process_view(self, request, view_func, view_args, view_kwargs):
4141
# need to initialize user, it doesn't get set when running tests for example

ietf/secr/proceedings/forms.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ def clean_file(self):
5353
ext = os.path.splitext(file.name)[1].lower()
5454
if ext not in VALID_SLIDE_EXTENSIONS:
5555
raise forms.ValidationError('Only these file types supported for presentation slides: %s' % ','.join(VALID_SLIDE_EXTENSIONS))
56-
if file._size > settings.MAX_UPLOAD_SIZE:
57-
raise forms.ValidationError('Please keep filesize under %s. Current filesize %s' % (filesizeformat(settings.MAX_UPLOAD_SIZE), filesizeformat(file._size)))
56+
if file._size > settings.SECR_MAX_UPLOAD_SIZE:
57+
raise forms.ValidationError('Please keep filesize under %s. Current filesize %s' % (filesizeformat(settings.SECR_MAX_UPLOAD_SIZE), filesizeformat(file._size)))
5858
return file
5959

6060
class UnifiedUploadForm(forms.Form):
@@ -66,8 +66,8 @@ class UnifiedUploadForm(forms.Form):
6666

6767
def clean_file(self):
6868
file = self.cleaned_data['file']
69-
if file._size > settings.MAX_UPLOAD_SIZE:
70-
raise forms.ValidationError('Please keep filesize under %s. Current filesize %s' % (filesizeformat(settings.MAX_UPLOAD_SIZE), filesizeformat(file._size)))
69+
if file._size > settings.SECR_MAX_UPLOAD_SIZE:
70+
raise forms.ValidationError('Please keep filesize under %s. Current filesize %s' % (filesizeformat(settings.SECR_MAX_UPLOAD_SIZE), filesizeformat(file._size)))
7171
return file
7272

7373
def clean(self):

ietf/secr/proceedings/proc_utils.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ def create_interim_directory():
161161
page = 'proceedings.html'
162162
meetings = InterimMeeting.objects.order_by('-date')
163163
response = render_to_response('proceedings/interim_directory.html',{'meetings': meetings})
164-
path = os.path.join(settings.INTERIM_LISTING_DIR, page)
164+
path = os.path.join(settings.SECR_INTERIM_LISTING_DIR, page)
165165
f = open(path,'w')
166166
f.write(response.content)
167167
f.close()
@@ -171,7 +171,7 @@ def create_interim_directory():
171171
qs = InterimMeeting.objects.all()
172172
meetings = sorted(qs, key=lambda a: a.group().acronym)
173173
response = render_to_response('proceedings/interim_directory.html',{'meetings': meetings})
174-
path = os.path.join(settings.INTERIM_LISTING_DIR, page)
174+
path = os.path.join(settings.SECR_INTERIM_LISTING_DIR, page)
175175
f = open(path,'w')
176176
f.write(response.content)
177177
f.close()
@@ -357,7 +357,7 @@ def gen_areas(context):
357357
'index': counter}
358358
)
359359

360-
path = os.path.join(settings.PROCEEDINGS_DIR,meeting.number,'%s.html' % area.acronym)
360+
path = os.path.join(settings.SECR_PROCEEDINGS_DIR,meeting.number,'%s.html' % area.acronym)
361361
write_html(path,html.content)
362362

363363
def gen_acknowledgement(context):
@@ -367,7 +367,7 @@ def gen_acknowledgement(context):
367367
'meeting': meeting}
368368
)
369369

370-
path = os.path.join(settings.PROCEEDINGS_DIR,meeting.number,'acknowledgement.html')
370+
path = os.path.join(settings.SECR_PROCEEDINGS_DIR,meeting.number,'acknowledgement.html')
371371
write_html(path,html.content)
372372

373373
def gen_agenda(context):
@@ -385,13 +385,13 @@ def gen_agenda(context):
385385
'timeslots': sort2}
386386
)
387387

388-
path = os.path.join(settings.PROCEEDINGS_DIR,meeting.number,'agenda.html')
388+
path = os.path.join(settings.SECR_PROCEEDINGS_DIR,meeting.number,'agenda.html')
389389
write_html(path,html.content)
390390

391391
# get the text agenda from datatracker
392392
url = 'https://datatracker.ietf.org/meeting/%s/agenda.txt' % meeting.number
393393
text = urlopen(url).read()
394-
path = os.path.join(settings.PROCEEDINGS_DIR,meeting.number,'agenda.txt')
394+
path = os.path.join(settings.SECR_PROCEEDINGS_DIR,meeting.number,'agenda.txt')
395395
write_html(path,text)
396396

397397
def gen_attendees(context):
@@ -404,7 +404,7 @@ def gen_attendees(context):
404404
'attendees': attendees}
405405
)
406406

407-
path = os.path.join(settings.PROCEEDINGS_DIR,meeting.number,'attendee.html')
407+
path = os.path.join(settings.SECR_PROCEEDINGS_DIR,meeting.number,'attendee.html')
408408
write_html(path,html.content)
409409

410410
def gen_group_pages(context):
@@ -415,7 +415,7 @@ def gen_group_pages(context):
415415

416416
def gen_index(context):
417417
index = render_to_response('proceedings/index.html',context)
418-
path = os.path.join(settings.PROCEEDINGS_DIR,context['meeting'].number,'index.html')
418+
path = os.path.join(settings.SECR_PROCEEDINGS_DIR,context['meeting'].number,'index.html')
419419
write_html(path,index.content)
420420

421421
def gen_irtf(context):
@@ -425,7 +425,7 @@ def gen_irtf(context):
425425
html = render_to_response('proceedings/irtf.html',{
426426
'irtf_chair':irtf_chair}
427427
)
428-
path = os.path.join(settings.PROCEEDINGS_DIR,meeting.number,'irtf.html')
428+
path = os.path.join(settings.SECR_PROCEEDINGS_DIR,meeting.number,'irtf.html')
429429
write_html(path,html.content)
430430

431431
def gen_overview(context):
@@ -441,7 +441,7 @@ def gen_overview(context):
441441
'ads': sorted_ads}
442442
)
443443

444-
path = os.path.join(settings.PROCEEDINGS_DIR,meeting.number,'overview.html')
444+
path = os.path.join(settings.SECR_PROCEEDINGS_DIR,meeting.number,'overview.html')
445445
write_html(path,html.content)
446446

447447
def gen_plenaries(context):
@@ -462,7 +462,7 @@ def gen_plenaries(context):
462462
'slides': admin_slides,
463463
'minutes': admin_minutes}
464464
)
465-
path = os.path.join(settings.PROCEEDINGS_DIR,context['meeting'].number,'administrative-plenary.html')
465+
path = os.path.join(settings.SECR_PROCEEDINGS_DIR,context['meeting'].number,'administrative-plenary.html')
466466
write_html(path,admin.content)
467467
except Session.DoesNotExist:
468468
pass
@@ -478,7 +478,7 @@ def gen_plenaries(context):
478478
'slides': tech_slides,
479479
'minutes': tech_minutes}
480480
)
481-
path = os.path.join(settings.PROCEEDINGS_DIR,context['meeting'].number,'technical-plenary.html')
481+
path = os.path.join(settings.SECR_PROCEEDINGS_DIR,context['meeting'].number,'technical-plenary.html')
482482
write_html(path,tech.content)
483483
except Session.DoesNotExist:
484484
pass
@@ -504,7 +504,7 @@ def gen_progress(context, final=True):
504504

505505
html = render_to_response('proceedings/progress.html',data)
506506

507-
path = os.path.join(settings.PROCEEDINGS_DIR,meeting.number,'progress-report.html')
507+
path = os.path.join(settings.SECR_PROCEEDINGS_DIR,meeting.number,'progress-report.html')
508508
write_html(path,html.content)
509509

510510
def gen_research(context):
@@ -522,7 +522,7 @@ def gen_research(context):
522522
'groups': groups}
523523
)
524524

525-
path = os.path.join(settings.PROCEEDINGS_DIR,meeting.number,'rg_irtf.html')
525+
path = os.path.join(settings.SECR_PROCEEDINGS_DIR,meeting.number,'rg_irtf.html')
526526
write_html(path,html.content)
527527

528528
def gen_training(context):
@@ -538,6 +538,6 @@ def gen_training(context):
538538
'slides': slides,
539539
'minutes': minutes}
540540
)
541-
path = os.path.join(settings.PROCEEDINGS_DIR,meeting.number,'train-%s.html' % counter )
541+
path = os.path.join(settings.SECR_PROCEEDINGS_DIR,meeting.number,'train-%s.html' % counter )
542542
write_html(path,html.content)
543543

ietf/secr/proceedings/views.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ def ajax_generate_proceedings(request, meeting_num):
219219
proceedings_url = get_proceedings_url(meeting)
220220

221221
# the acknowledgement page can be edited manually so only produce if it doesn't already exist
222-
path = os.path.join(settings.PROCEEDINGS_DIR,meeting.number,'acknowledgement.html')
222+
path = os.path.join(settings.SECR_PROCEEDINGS_DIR,meeting.number,'acknowledgement.html')
223223
if not os.path.exists(path):
224224
gen_acknowledgement(context)
225225
gen_overview(context)
@@ -235,7 +235,7 @@ def ajax_generate_proceedings(request, meeting_num):
235235
gen_group_pages(context)
236236

237237
# get the time proceedings were generated
238-
path = os.path.join(settings.PROCEEDINGS_DIR,meeting.number,'index.html')
238+
path = os.path.join(settings.SECR_PROCEEDINGS_DIR,meeting.number,'index.html')
239239
last_run = datetime.datetime.fromtimestamp(os.path.getmtime(path))
240240

241241
return render_to_response('includes/proceedings_functions.html',{
@@ -550,7 +550,7 @@ def process_pdfs(request, meeting_num):
550550
for doc in itertools.chain(ppt,pptx):
551551
base,ext = os.path.splitext(doc.external_url)
552552
pdf_file = base + '.pdf'
553-
path = os.path.join(settings.PROCEEDINGS_DIR,meeting_num,'slides',pdf_file)
553+
path = os.path.join(settings.SECR_PROCEEDINGS_DIR,meeting_num,'slides',pdf_file)
554554
if os.path.exists(path):
555555
doc.external_url = pdf_file
556556
doc.save()
@@ -653,7 +653,7 @@ def select(request, meeting_num):
653653
proceedings_url = get_proceedings_url(meeting)
654654

655655
# get the time proceedings were generated
656-
path = os.path.join(settings.PROCEEDINGS_DIR,meeting.number,'index.html')
656+
path = os.path.join(settings.SECR_PROCEEDINGS_DIR,meeting.number,'index.html')
657657
if os.path.exists(path):
658658
last_run = datetime.datetime.fromtimestamp(os.path.getmtime(path))
659659
else:

ietf/secr/sreq/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
# Globals
2929
# -------------------------------------------------
3030
SESSION_REQUEST_EMAIL = 'session-request@ietf.org'
31-
LOCKFILE = os.path.join(settings.PROCEEDINGS_DIR,'session_request.lock')
31+
LOCKFILE = os.path.join(settings.SECR_PROCEEDINGS_DIR,'session_request.lock')
3232
# -------------------------------------------------
3333
# Helper Functions
3434
# -------------------------------------------------

ietf/settings.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@
161161
'ietf.liaisons',
162162
'ietf.mailinglists',
163163
'ietf.meeting',
164-
'ietf.proceedings',
164+
#'ietf.proceedings',
165165
'ietf.redirects',
166166
'ietf.idrfc',
167167
'ietf.wginfo',
@@ -178,7 +178,7 @@
178178
'ietf.secr.groups',
179179
'ietf.secr.ipradmin',
180180
'ietf.secr.meetings',
181-
#'ietf.secr.proceedings',
181+
'ietf.secr.proceedings',
182182
'ietf.secr.roles',
183183
'ietf.secr.rolodex',
184184
'ietf.secr.telechat',
@@ -326,19 +326,19 @@
326326
CHANGELOG_PATH = '/www/ietf-datatracker/web/changelog'
327327

328328
# Secretariat Tool
329-
BLUE_SHEET_PATH = '/a/www/ietf-datatracker/documents/blue_sheet.rtf'
330-
BLUE_SHEET_URL = 'https://datatracker.ietf.org/documents/blue_sheet.rtf'
331-
INTERIM_LISTING_DIR = '/a/www/www6/meeting/interim'
332-
MAX_UPLOAD_SIZE = 40960000
333-
PROCEEDINGS_DIR = '/a/www/www6s/proceedings/'
334329
# this is a tuple of regular expressions. if the incoming URL matches one of
335330
# these, than non secretariat access is allowed.
336-
SEC_AUTH_UNRESTRICTED_URLS = (
331+
SECR_AUTH_UNRESTRICTED_URLS = (
337332
#(r'^/$'),
338-
#(r'^/announcement/'),
339-
#(r'^/proceedings/'),
333+
(r'^/secr/announcement/'),
334+
(r'^/secr/proceedings/'),
340335
(r'^/secr/sreq/'),
341336
)
337+
SECR_BLUE_SHEET_PATH = '/a/www/ietf-datatracker/documents/blue_sheet.rtf'
338+
SECR_BLUE_SHEET_URL = 'https://datatracker.ietf.org/documents/blue_sheet.rtf'
339+
SECR_INTERIM_LISTING_DIR = '/a/www/www6/meeting/interim'
340+
SECR_MAX_UPLOAD_SIZE = 40960000
341+
SECR_PROCEEDINGS_DIR = '/a/www/www6s/proceedings/'
342342
SECR_STATIC_URL = '/secr-static/'
343343

344344
# Put SECRET_KEY in here, or any other sensitive or site-specific

0 commit comments

Comments
 (0)