Skip to content

Commit 269226a

Browse files
committed
Merged in [12099] from rjsparks@nostrum.com:
Changes interim announcements and interim cancellation announcements to use mailtriggers. Adds irtf-announce to announcements for IRTF groups. Fixes ietf-tools#2018. - Legacy-Id: 12100 Note: SVN reference [12099] has been migrated to Git commit 5b32cc2
2 parents e06ac44 + 5b32cc2 commit 269226a

6 files changed

Lines changed: 195 additions & 65 deletions

File tree

changelog

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,29 @@
1+
ietfdb (6.34.3) ietf; urgency=medium
2+
3+
* Merged in [12082] from rcross@amsl.com:
4+
Fixed an issue where interim meeting request form didn't list research
5+
groups when the logged-in user was both a working group chair and a
6+
research group chair.
7+
8+
* Made it possible to merge nominations with inactive email addresses.
9+
By default the SearchableEmail form field only displays active email
10+
addresses, but this use case needs all known email addresses.
11+
12+
* Fixed inclusion of tablesorter css and js for use when displaying the
13+
SQL query list in development mode.
14+
15+
* Added admin support for the DocumentAuthor model.
16+
17+
* Fixed a place where email addresses which were not all lowercase could
18+
slip in, which messed up some reverse table relationships. (This was
19+
found by running our check_referential_integrity management command.)
20+
21+
* Fixed a problem with the error message text for the nominee email edit
22+
form.
23+
24+
-- Henrik Levkowetz <henrik@levkowetz.com> 05 Oct 2016 11:56:01 -0700
25+
26+
127
ietfdb (6.34.2) ietf; urgency=medium
228

329
**Draft submission and document DOI fixes**
Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
# -*- coding: utf-8 -*-
2+
from __future__ import unicode_literals
3+
4+
from django.db import migrations
5+
6+
def forward(apps, schema_editor):
7+
MailTrigger=apps.get_model('mailtrigger','MailTrigger')
8+
Recipient=apps.get_model('mailtrigger','Recipient')
9+
10+
Recipient.objects.create(
11+
slug='group_stream_announce',
12+
desc="The group's stream's announce list",
13+
template="{% if group.type_id == 'wg' %}IETF-Announce <ietf-announce@ietf.org>{% elif group.type_id == 'rg' %}IRTF-Announce <irtf-announce@irtf.org>{% endif %}"
14+
)
15+
16+
annc = MailTrigger.objects.create(
17+
slug='interim_announced',
18+
desc='Recipients when an interim meeting is announced',
19+
)
20+
annc.to = Recipient.objects.filter(slug__in=['ietf_announce','stream_announce'])
21+
annc.cc = Recipient.objects.filter(slug__in=['group_mail_list',])
22+
23+
annc = MailTrigger.objects.create(
24+
slug='interim_cancelled',
25+
desc='Recipients when an interim meeting is cancelled',
26+
)
27+
annc.to = Recipient.objects.filter(slug__in=['ietf_announce','stream_aanounce'])
28+
annc.cc = Recipient.objects.filter(slug__in=['group_chairs','group_mail_list','logged_in_person'])
29+
30+
31+
def reverse(apps, schema_editor):
32+
MailTrigger=apps.get_model('mailtrigger','MailTrigger')
33+
Recipient=apps.get_model('mailtrigger','Recipient')
34+
35+
MailTrigger.objects.filter(slug__in=['interim_announced','interim_cancelled']).delete()
36+
Recipient.objects.filter(slug='group_stream_announce').delete()
37+
38+
39+
class Migration(migrations.Migration):
40+
41+
dependencies = [
42+
('mailtrigger', '0006_auto_20160707_1933'),
43+
]
44+
45+
operations = [
46+
migrations.RunPython(forward,reverse),
47+
]

ietf/meeting/helpers.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -409,8 +409,7 @@ def get_announcement_initial(meeting, is_change=False):
409409
group = meeting.session_set.first().group
410410
in_person = bool(meeting.city)
411411
initial = {}
412-
initial['to'] = settings.INTERIM_ANNOUNCE_TO_EMAIL
413-
initial['cc'] = group.list_email
412+
(initial['to'],initial['cc']) = gather_address_lists('interim_announced',group=group)
414413
initial['frm'] = settings.INTERIM_ANNOUNCE_FROM_EMAIL
415414
if in_person:
416415
desc = 'Interim'
@@ -585,8 +584,7 @@ def send_interim_cancellation_notice(meeting):
585584
"""Sends an email that a scheduled interim meeting has been cancelled."""
586585
session = meeting.session_set.first()
587586
group = session.group
588-
to_email = settings.INTERIM_ANNOUNCE_TO_EMAIL
589-
(_, cc_list) = gather_address_lists('session_request_cancelled',group=group)
587+
(to_email, cc_list) = gather_address_lists('interim_cancelled',group=group)
590588
from_email = settings.INTERIM_ANNOUNCE_FROM_EMAIL
591589
subject = '{group} ({acronym}) {type} Interim Meeting Cancelled (was {date})'.format(
592590
group=group.name,

ietf/meeting/test_data.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def make_meeting_test_data(meeting=None):
4747
room = Room.objects.create(meeting=meeting, name="Test Room", capacity=123, functional_name="Testing Ground")
4848
room.session_types.add("session")
4949
room.resources.add(projector)
50-
asname = RoomResourceName.objects.create(name='Audio Stream', slug='audiostream')
50+
asname = RoomResourceName.objects.get(slug='audiostream')
5151
UrlResource.objects.create(name=asname, room=room, url='http://ietf{number}streaming.dnsalias.net/ietf/ietf{number}1.m3u'.format(number=meeting.number))
5252

5353
# another room

0 commit comments

Comments
 (0)