Skip to content

Commit 24b8324

Browse files
committed
Tune the recipients when a teams settings or a reviewer indicate ADs should be notified about a review. Commit ready for merge.
- Legacy-Id: 15677
1 parent b76ea7b commit 24b8324

2 files changed

Lines changed: 15 additions & 1 deletion

File tree

ietf/mailtrigger/migrations/0003_add_review_notify_ad.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,16 @@ def forward(apps, schema_editor):
1313
desc = "The reviewed document's responsible area director",
1414
template = '{% if review_req.doc.ad %}{{review_req.doc.ad.email_address}}{% endif %}'
1515
)
16+
Recipient.objects.create(
17+
slug = 'review_team_ads',
18+
desc = "The ADs of the team reviewing the document"
19+
)
1620

1721
review_notify_ad = MailTrigger.objects.create(
1822
slug = 'review_notify_ad',
1923
desc = 'Recipients when a team notifies area directors when a review with one of a certain set of results (typically results indicating problem) is submitted',
2024
)
21-
review_notify_ad.to.set(Recipient.objects.filter(slug='review_doc_ad'))
25+
review_notify_ad.to.set(Recipient.objects.filter(slug__in=['review_doc_ad','review_team_ads']))
2226

2327

2428
def reverse(apps, schema_editor):
@@ -27,6 +31,7 @@ def reverse(apps, schema_editor):
2731

2832
MailTrigger.objects.filter(slug='review_notify_ad').delete()
2933
Recipient.objects.filter(slug='review_doc_ad').delete()
34+
Recipient.objects.filter(slug='review_team_ads').delete()
3035

3136
class Migration(migrations.Migration):
3237

ietf/mailtrigger/models.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -316,3 +316,12 @@ def gather_session_requester(self, **kwargs):
316316
session = kwargs['session']
317317
addrs.append(session.requested_by.role_email('chair').address)
318318
return addrs
319+
320+
def gather_review_team_ads(self, **kwargs):
321+
addrs=[]
322+
if 'review_req' in kwargs:
323+
review_req = kwargs['review_req']
324+
if review_req.team.parent:
325+
for role in review_req.team.parent.role_set.filter(name='ad'):
326+
addrs.append(role.email.address)
327+
return addrs

0 commit comments

Comments
 (0)