Skip to content

Commit 21b05d0

Browse files
committed
Populate interim approved email correctly. Fixes ietf-tools#3150. Commit ready for merge.
- Legacy-Id: 18748
1 parent c9f7b18 commit 21b05d0

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

ietf/meeting/helpers.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -585,6 +585,8 @@ def send_interim_approval(user, meeting):
585585
template = 'meeting/interim_approval.txt'
586586
context = {
587587
'meeting': meeting,
588+
'group': first_session.group,
589+
'requester': session_requested_by(first_session),
588590
}
589591
send_mail(None,
590592
to_email,

ietf/meeting/tests_views.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
from ietf.meeting.models import Session, TimeSlot, Meeting, SchedTimeSessAssignment, Schedule, SessionPresentation, SlideSubmission, SchedulingEvent, Room, Constraint, ConstraintName
3939
from ietf.meeting.test_data import make_meeting_test_data, make_interim_meeting, make_interim_test_data
4040
from ietf.meeting.utils import finalize, condition_slide_order
41-
from ietf.meeting.utils import add_event_info_to_session_qs
41+
from ietf.meeting.utils import add_event_info_to_session_qs, session_requested_by
4242
from ietf.meeting.views import session_draft_list, parse_agenda_filter_params
4343
from ietf.name.models import SessionStatusName, ImportantDateName, RoleName
4444
from ietf.utils.decorators import skip_coverage
@@ -2253,6 +2253,8 @@ def test_interim_request_single_virtual_settings_approval_not_required(self):
22532253
self.assertEqual(meeting.session_set.last().schedulingevent_set.last().status_id,'scheda')
22542254
self.assertIn('iesg-secretary@ietf.org', outbox[-1]['To'])
22552255
self.assertIn('interim meeting ready for announcement', outbox[-1]['Subject'])
2256+
self.assertIn(f'interim meeting for {meeting.session_set.first().group.acronym} has been approved',get_payload_text(outbox[-2]))
2257+
self.assertIn(f'Session Requester: { session_requested_by(meeting.session_set.first()) }', get_payload_text(outbox[-2]))
22562258

22572259
def test_interim_request_single_in_person(self):
22582260
make_meeting_test_data()

0 commit comments

Comments
 (0)