Skip to content

Commit 206f2f1

Browse files
committed
Merged [5005] from rjsparks@nostrum.com:
Enable diff on the conflict review history tab Fixes bug ietf-tools#882 - Legacy-Id: 5019 Note: SVN reference [5005] has been migrated to Git commit f3102cd
2 parents d136013 + f3102cd commit 206f2f1

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

ietf/idrfc/views_doc.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ def document_history(request, name):
209209
diff_revisions = []
210210
seen = set()
211211

212-
diffable = name.startswith("draft") or name.startswith("charter")
212+
diffable = name.startswith("draft") or name.startswith("charter") or name.startswith("conflict-review")
213213

214214
if diffable:
215215
for e in NewRevisionDocEvent.objects.filter(type="new_revision", doc__in=diff_documents).select_related('doc').order_by("-time", "-id"):
@@ -220,6 +220,9 @@ def document_history(request, name):
220220
if name.startswith("charter"):
221221
h = find_history_active_at(e.doc, e.time)
222222
url = settings.CHARTER_TXT_URL + ("%s-%s.txt" % ((h or doc).canonical_name(), e.rev))
223+
elif name.startswith("conflict-review"):
224+
h = find_history_active_at(e.doc, e.time)
225+
url = settings.CONFLICT_REVIEW_TXT_URL + ("%s-%s.txt" % ((h or doc).canonical_name(), e.rev))
223226
elif name.startswith("draft"):
224227
# rfcdiff tool has special support for IDs
225228
url = e.doc.name + "-" + e.rev

ietf/settings.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@
204204
CHARTER_PATH = '/a/www/ietf-ftp/charters/'
205205
CHARTER_TXT_URL = 'http://www.ietf.org/charter/'
206206
CONFLICT_REVIEW_PATH = '/a/www/ietf-ftp/conflict-reviews'
207+
CONFLICT_REVIEW_TXT_URL = 'http://www.ietf.org/cr/'
207208
AGENDA_PATH = '/a/www/www6s/proceedings/'
208209
AGENDA_PATH_PATTERN = '/a/www/www6s/proceedings/%(meeting)s/agenda/%(wg)s.%(ext)s'
209210
MINUTES_PATH_PATTERN = '/a/www/www6s/proceedings/%(meeting)s/minutes/%(wg)s.%(ext)s'

0 commit comments

Comments
 (0)