Skip to content

Commit 1f53532

Browse files
committed
Merged in [11698] from rcross@amsl.com:
Changed send_interim_announcement_request() to use new mailtrigger interim_approved. - Legacy-Id: 11709 Note: SVN reference [11698] has been migrated to Git commit 3da2d4f
2 parents ac31664 + 3da2d4f commit 1f53532

3 files changed

Lines changed: 60 additions & 2 deletions

File tree

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
# -*- coding: utf-8 -*-
2+
from __future__ import unicode_literals
3+
4+
from django.db import migrations
5+
6+
7+
def make_mailtriggers(apps):
8+
Recipient = apps.get_model('mailtrigger','Recipient')
9+
MailTrigger = apps.get_model('mailtrigger','MailTrigger')
10+
11+
def mt_factory(slug,desc,to_slugs,cc_slugs=[]):
12+
13+
# Try to protect ourselves from typos
14+
all_slugs = to_slugs[:]
15+
all_slugs.extend(cc_slugs)
16+
for recipient_slug in all_slugs:
17+
try:
18+
Recipient.objects.get(slug=recipient_slug)
19+
except Recipient.DoesNotExist:
20+
print "****Some rule tried to use",recipient_slug
21+
raise
22+
23+
m, _ = MailTrigger.objects.get_or_create(slug=slug, desc=desc)
24+
m.to = Recipient.objects.filter(slug__in=to_slugs)
25+
m.cc = Recipient.objects.filter(slug__in=cc_slugs)
26+
27+
mt_factory(slug='interim_approved',
28+
desc="Recipients when an interim meeting is approved "
29+
"and an announcement needs to be sent",
30+
to_slugs=['iesg_secretary'],
31+
cc_slugs=[]
32+
)
33+
34+
def forward(apps, schema_editor):
35+
make_mailtriggers(apps)
36+
37+
def reverse(apps, schema_editor):
38+
MailTrigger=apps.get_model('mailtrigger','MailTrigger')
39+
MailTrigger.objects.filter(slug='interim_approved').delete()
40+
41+
class Migration(migrations.Migration):
42+
dependencies = [
43+
('mailtrigger', '0004_auto_20160516_1659'),
44+
]
45+
46+
operations = [migrations.RunPython(forward, reverse)]

ietf/meeting/helpers.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -567,7 +567,7 @@ def send_interim_announcement_request(meeting):
567567
interim meeting which includes the link to send the official announcement"""
568568
group = meeting.session_set.first().group
569569
requester = meeting.session_set.first().requested_by
570-
(to_email, cc_list) = gather_address_lists('session_requested',group=group,person=requester)
570+
(to_email, cc_list) = gather_address_lists('interim_approved')
571571
from_email = ('"IETF Meeting Session Request Tool"','session_request_developers@ietf.org')
572572
subject = '{group} - Interim Meeting Approved'.format(group=group.acronym)
573573
template = 'meeting/interim_announcement_request.txt'
@@ -578,7 +578,8 @@ def send_interim_announcement_request(meeting):
578578
from_email,
579579
subject,
580580
template,
581-
context,)
581+
context,
582+
cc_list)
582583

583584
def send_interim_cancellation_notice(meeting):
584585
"""Sends an email that a scheduled interim meeting has been cancelled."""

ietf/name/fixtures/names.json

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6011,5 +6011,16 @@
60116011
},
60126012
"model": "mailtrigger.mailtrigger",
60136013
"pk": "sub_new_version"
6014+
},
6015+
{
6016+
"fields": {
6017+
"cc": [],
6018+
"to": [
6019+
"iesg_secretary"
6020+
],
6021+
"desc": "Recipients when an interim meeting is approved and an announcement needs to be sent"
6022+
},
6023+
"model": "mailtrigger.mailtrigger",
6024+
"pk": "interim_approved"
60146025
}
60156026
]

0 commit comments

Comments
 (0)