Skip to content

Commit 1de0c2a

Browse files
committed
Merged in [17480] from rjsparks@nostrum.com:
Show UTC times in interim announcements if the interim has a non-UTC timzone. Fixes ietf-tools#2922. - Legacy-Id: 17482 Note: SVN reference [17480] has been migrated to Git commit 091ac7e
2 parents 9de7c5c + 091ac7e commit 1de0c2a

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

ietf/meeting/tests_views.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
from ietf.meeting.views import session_draft_list
4343
from ietf.name.models import SessionStatusName, ImportantDateName
4444
from ietf.utils.decorators import skip_coverage
45-
from ietf.utils.mail import outbox, empty_outbox
45+
from ietf.utils.mail import outbox, empty_outbox, get_payload
4646
from ietf.utils.test_utils import TestCase, login_testing_unauthorized, unicontent
4747
from ietf.utils.text import xslugify
4848

@@ -1260,6 +1260,8 @@ def test_interim_skip_announcement(self):
12601260
def test_interim_send_announcement(self):
12611261
make_meeting_test_data()
12621262
meeting = add_event_info_to_session_qs(Session.objects.filter(meeting__type='interim', group__acronym='mars')).filter(current_status='apprw').first().meeting
1263+
meeting.time_zone = 'America/Los_Angeles'
1264+
meeting.save()
12631265
url = urlreverse("ietf.meeting.views.interim_send_announcement", kwargs={'number': meeting.number})
12641266
login_testing_unauthorized(self, "secretary", url)
12651267
r = self.client.get(url)
@@ -1271,6 +1273,8 @@ def test_interim_send_announcement(self):
12711273
self.assertRedirects(r, urlreverse('ietf.meeting.views.interim_announce'))
12721274
self.assertEqual(len(outbox), len_before + 1)
12731275
self.assertIn('WG Virtual Meeting', outbox[-1]['Subject'])
1276+
self.assertIn('09:00 to 09:20 America/Los_Angeles', get_payload(outbox[-1]))
1277+
self.assertIn('(17:00 to 17:20 UTC)', get_payload(outbox[-1]))
12741278

12751279
def test_interim_approve_by_ad(self):
12761280
make_meeting_test_data()

ietf/templates/meeting/interim_announcement.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{% load ietf_filters %}{% if is_change %}MEETING DETAILS HAVE CHANGED. SEE LATEST DETAILS BELOW.
22

33
{% endif %}The {{ group.name }} ({{ group.acronym }}) {% if group.type.slug == "rg" %}Research Group{% elif group.state.slug == "active" %}Working Group{% elif group.state.slug == 'bof' %}BOF{% endif %} will hold
4-
{% if meeting.session_set.count == 1 %}a{% if meeting.city %}n {% else %} virtual {% endif %}interim meeting on {{ meeting.date }} from {{ meeting.schedule.assignments.first.timeslot.time | date:"H:i" }} to {{ meeting.schedule.assignments.first.timeslot.end_time | date:"H:i" }} {{ meeting.time_zone }}.
4+
{% if meeting.session_set.count == 1 %}a{% if meeting.city %}n {% else %} virtual {% endif %}interim meeting on {{ meeting.date }} from {{ meeting.schedule.assignments.first.timeslot.time | date:"H:i" }} to {{ meeting.schedule.assignments.first.timeslot.end_time | date:"H:i" }} {{ meeting.time_zone}}{% if meeting.time_zone != 'UTC' %} ({{ meeting.schedule.assignments.first.timeslot.utc_start_time | date:"H:i" }} to {{ meeting.schedule.assignments.first.timeslot.utc_end_time | date:"H:i" }} UTC){% endif %}.
55
{% else %}a multi-day {% if not meeting.city %}virtual {% endif %}interim meeting.
66

77
{% for assignment in meeting.schedule.assignments.all %}Session {{ forloop.counter }}:
8-
{{ assignment.timeslot.time | date:"Y-m-d" }} {{ assignment.timeslot.time | date:"H:i" }} to {{ assignment.timeslot.end_time | date:"H:i" }} {{ meeting.time_zone }}
8+
{{ assignment.timeslot.time | date:"Y-m-d" }} {{ assignment.timeslot.time | date:"H:i" }} to {{ assignment.timeslot.end_time | date:"H:i" }} {{ meeting.time_zone }}{% if meeting.time_zone != 'UTC' %}({{ assignment.timeslot.utc_start_time | date:"H:i" }} to {{ assignment.timeslot.utc_end_time | date:"H:i" }} UTC){% endif %}
99
{% endfor %}{% endif %}
1010
{% if meeting.city %}Meeting Location:
1111
{{ meeting.city }}, {{ meeting.country }}

0 commit comments

Comments
 (0)