Skip to content

Commit 1d2883a

Browse files
committed
Summary: Fix some inconsistencies regarding whether to use
{% buttons %} or <div class="buttonlist"> for form buttons - Legacy-Id: 8992
1 parent 78e3a62 commit 1d2883a

9 files changed

Lines changed: 28 additions & 28 deletions

File tree

ietf/templates/doc/ballot/approve_ballot.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ <h1>Approve ballot<br><small>{{ doc }}</small></h1>
99
{% csrf_token %}
1010
<pre>{{ announcement }}</pre>
1111

12-
<div class="buttonlist">
13-
{% if action == "to_announcement_list" %}
12+
{% buttons %}
13+
{% if action == "to_announcement_list" %}
1414
<button class="btn btn-warning" type="submit">Notify RFC Editor, send announcement & close ballot</button>
1515
{% elif action == "to_rfc_editor" %}
1616
<button class="btn btn-warning" type="submit">Email RFC Editor & close ballot</button>
1717
{% elif action == "do_not_publish" %}
1818
<button class="btn btn-warning" type="submit">Email RFC Editor (DNP) & close ballot"/>
1919
{% endif %}
2020
<a class="btn btn-default pull-right" href="{% url "doc_ballot_approvaltext" name=doc.name %}">Back</a>
21-
</div>
21+
{% endbuttons %}
2222
</form>
2323
{% endblock %}

ietf/templates/doc/ballot/clear_ballot.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ <h1>Clear ballot<br><small>{{ doc }}</small></h1>
1313
This will clear all ballot positions and discuss entries.
1414
</p>
1515

16-
<div class="buttonlist">
17-
<button type="submit" class="btn btn-danger">Clear</button>
16+
{% buttons %}
17+
<button type="submit" class="btn btn-danger">Clear</button>
1818
<a class="btn btn-default pull-right" href="{{ back_url }}ballot/">Back</a>
19-
</div>
19+
{% endbuttons %}
2020
</form>
2121

2222
{% endblock %}

ietf/templates/doc/ballot/send_ballot_comment.html

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,10 @@ <h1>Send ballot position for {{ ad }}</h1>
4545
<pre>{{ body|wrap_text }}</pre>
4646
</div>
4747

48-
<div class="buttonlist">
49-
<input type="submit" class="btn btn-danger" value="Send">
48+
{% buttons %}
49+
<button type="submit" class="btn btn-danger">Send</button>
5050
<a class="btn btn-default pull-right" href="{{ back_url }}">Back</a>
51-
</div>
52-
51+
{% endbuttons %}
5352
</form>
5453

5554
{% endblock %}

ietf/templates/doc/charter/approve.html

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,11 @@ <h1>Approve {{ charter.canonical_name }}-{{ charter.rev }}</h1>
88
<form role="form" method="post">
99
{% csrf_token %}
1010
<pre>{{ announcement }}</pre>
11-
<div class="buttonlist">
12-
<button type="submit" class="btn btn-primary">Send announcement, close ballot & update revision</button>
13-
<a class="btn btn-default" href="{% url "charter_edit_announcement" name=charter.canonical_name ann="action" %}?next=approve">Edit/regenerate announcement</a>
14-
<a class="btn btn-default pull-right" href="{% url "doc_view" name=charter.name %}">Back</a>
15-
</div>
11+
12+
{% buttons %}
13+
<button type="submit" class="btn btn-primary">Send announcement, close ballot & update revision</button>
14+
<a class="btn btn-default" href="{% url "charter_edit_announcement" name=charter.canonical_name ann="action" %}?next=approve">Edit/regenerate announcement</a>
15+
<a class="btn btn-default pull-right" href="{% url "doc_view" name=charter.name %}">Back</a>
16+
{% endbuttons %}
1617
</form>
1718
{% endblock %}

ietf/templates/doc/draft/request_resurrect.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ <h1>Request resurrection<br><small>{{ doc }}</small></h1>
1212
<form role="form" method="post">
1313
{% csrf_token %}
1414

15-
<div class="buttonlist">
16-
<input class="btn btn-primary" type="submit" value="Request resurrection">
15+
{% buttons %}
16+
<input class="btn btn-primary" type="submit" value="Request resurrection">
1717
<a class="btn btn-default pull-right" href="{{ back_url }}">Back</a>
18-
</div>
18+
{% endbuttons %}
1919
</form>
2020

2121
{% endblock %}

ietf/templates/doc/draft/resurrect.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ <h1>Resurrect<br><small>{{ doc }}</small></h1>
1515
<form role="form" method="post">
1616
{% csrf_token %}
1717

18-
<div class="buttonlist">
19-
<input class="btn btn-primary" type="submit" value="Resurrect">
18+
{% buttons %}
19+
<input class="btn btn-primary" type="submit" value="Resurrect">
2020
<a class="btn btn-default pull-right" href="{{ back_url }}">Back</a>
21-
</div>
21+
{% endbuttons %}
2222
</form>
2323

2424
{% endblock %}

ietf/templates/doc/status_change/edit_relations.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ <h1>Edit RFCs affected by status change</h1>
1515
<div class="alert alert-danger">{{ form.non_field_errors }}</div>
1616
{% endif %}
1717

18-
<div class="buttonlist">
18+
{% buttons %}
1919
<button type="submit" class="btn btn-primary">Save</button>
2020
<a class="btn btn-default pull-right" href="{% url "doc_view" name=doc.name %}">Back</a>
21-
</div>
21+
{% endbuttons %}
2222
</form>
2323
{% endblock %}
2424

ietf/templates/doc/submit_to_iesg.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,10 @@ <h1>Publication request<br><small>{{doc.name}}-{{doc.rev}}</small></h1>
6767

6868
<form role="form" method="post">
6969
{% csrf_token %}
70-
<div class="buttonlist">
70+
{% buttons %}
7171
<input type="submit" class="btn btn-warning" name="confirm" value="Request publication">
7272
<input type="submit" class="btn btn-default pull-right" name="cancel" value="Back">
73-
</div>
73+
{% endbuttons %}
7474
</form>
7575

7676

ietf/templates/submit/cancel_preapproval.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ <h2>Cancel pre-approval</h2>
1515
{% csrf_token %}
1616
<input type="hidden" name="action" value="cancel">
1717

18-
<div class="buttonlist">
19-
<button type="submit" class="btn btn-danger">Cancel pre-approval</button>
18+
{% buttons %}
19+
<button type="submit" class="btn btn-danger">Cancel pre-approval</button>
2020
<a class="btn btn-default pull-right" href="{% url "submit_approvals" %}#preapprovals">Back</a>
21-
</div>
21+
{% endbuttons %}
2222
</form>
2323

2424
{% endblock %}

0 commit comments

Comments
 (0)