Skip to content

Commit 1825406

Browse files
committed
Added a presence check before removing a list element. Addresses a 500 in unassigned review form POST.
- Legacy-Id: 14642
1 parent ba8a173 commit 1825406

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

ietf/group/views.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1485,7 +1485,10 @@ def manage_review_requests(request, acronym, group_type=None, assignment_status=
14851485
while head_of_rotation in assignments_by_person:
14861486
review_req = assignments_by_person[head_of_rotation]
14871487
assign_review_request_to_reviewer(request, review_req, review_req.form.cleaned_data["reviewer"],review_req.form.cleaned_data["add_skip"])
1488-
reqs_to_assign.remove(review_req)
1488+
if review_req in reqs_to_assign:
1489+
# XXX FIXME: It's not clear how we could end up here, but
1490+
# it has happened. See traceback email dated 14 Feb 2018
1491+
reqs_to_assign.remove(review_req)
14891492
head_of_rotation = reviewer_rotation_list(group)[0]
14901493

14911494
for review_req in reqs_to_assign:

0 commit comments

Comments
 (0)