Skip to content

Commit 1343ab9

Browse files
committed
Merged in [19484] from lars@eggert.org:
Remove the Note Well from the datatracker and point to the IETF web site. One less thing to keep in sync if the Note Well changes. - Legacy-Id: 19520 Note: SVN reference [19484] has been migrated to Git commit 962253f
2 parents 8c62c05 + 962253f commit 1343ab9

7 files changed

Lines changed: 10 additions & 117 deletions

File tree

ietf/submit/tests.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1534,9 +1534,6 @@ def test_expire_submissions(self):
15341534
self.assertEqual(s.state_id, "cancel")
15351535

15361536
def test_help_pages(self):
1537-
r = self.client.get(urlreverse("ietf.submit.views.note_well"))
1538-
self.assertEqual(r.status_code, 200)
1539-
15401537
r = self.client.get(urlreverse("ietf.submit.views.tool_instructions"))
15411538
self.assertEqual(r.status_code, 200)
15421539

@@ -2916,4 +2913,4 @@ def test_draft_refs_identification(self):
29162913
self.assertEqual(refs['rfc8174'], 'norm')
29172914
self.assertEqual(refs['rfc8126'], 'info')
29182915
self.assertEqual(refs['rfc8175'], 'info')
2919-
2916+

ietf/submit/urls.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
url(r'^status/(?P<submission_id>\d+)/confirm/(?P<auth_token>[a-f\d]+)/$', views.confirm_submission),
1111
url(r'^status/(?P<submission_id>\d+)/edit/$', views.edit_submission),
1212
url(r'^status/(?P<submission_id>\d+)/(?P<access_token>[a-f\d]+)/edit/$', views.edit_submission),
13-
url(r'^note-well/$', views.note_well),
1413
url(r'^tool-instructions/$', views.tool_instructions),
1514

1615
url(r'^approvals/$', views.approvals),
@@ -26,4 +25,4 @@
2625
url(r'^manualpost/email/(?P<submission_id>\d+)/(?P<message_id>\d+)/(?P<access_token>[a-f\d]*)/$', views.show_submission_email_message),
2726
url(r'^manualpost/replyemail/(?P<submission_id>\d+)/(?P<message_id>\d+)/$', views.send_submission_email),
2827
url(r'^manualpost/sendemail/(?P<submission_id>\d+)/$', views.send_submission_email),
29-
]
28+
]

ietf/submit/views.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -199,9 +199,6 @@ def err(code, text):
199199
else:
200200
return err(405, "Method not allowed")
201201

202-
def note_well(request):
203-
return render(request, 'submit/note_well.html', {'selected': 'notewell'})
204-
205202
def tool_instructions(request):
206203
return render(request, 'submit/tool_instructions.html', {'selected': 'instructions'})
207204

@@ -926,4 +923,4 @@ def get_submission_or_404(submission_id, access_token=None):
926923
if access_token and not key_matched:
927924
raise Http404
928925

929-
return submission
926+
return submission

ietf/templates/submit/note_well.html

Lines changed: 0 additions & 100 deletions
This file was deleted.

ietf/templates/submit/submit_base.html

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,6 @@ <h1>Internet-Draft submission </h1>
2020
<li {% if selected == "instructions" %}class="active"{% endif %}>
2121
<a href="{% url "ietf.submit.views.tool_instructions" %}">Instructions</a>
2222
</li>
23-
<li {% if selected == "notewell" %}class="active"{% endif %}>
24-
<a href="{% url "ietf.submit.views.note_well" %}">Note Well</a>
25-
</li>
2623
<li {% if selected == "approvals" %}class="active"{% endif %}>
2724
<a href="{% url "ietf.submit.views.approvals" %}">Approvals</a>
2825
</li>
@@ -34,4 +31,4 @@ <h1>Internet-Draft submission </h1>
3431
{% block submit_content %}
3532
{% endblock %}
3633

37-
{% endblock %}
34+
{% endblock %}

ietf/templates/submit/tool_instructions.html

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,9 @@ <h3>Upload screen</h3>
4343

4444
<p>
4545
By submitting your I-D, you are granting some rights to the IETF Trust. Before you submit your I-D,
46-
review the information on the NOTE WELL tab and <a href="{% url 'ietf.doc.views_doc.document_html' name='rfc5378' %}">BCP 78</a>,
46+
review the information in the
47+
<a href="https://www.ietf.org/about/note-well/">Note Well</a> and
48+
<a href="{% url 'ietf.doc.views_doc.document_html' name='rfc5378' %}">BCP 78</a>,
4749
"Rights Contributors Provide to the IETF Trust".
4850
</p>
4951

@@ -168,4 +170,4 @@ <h3>Problem report</h3>
168170
The specification for this tool can be found in <a href="{% url 'ietf.doc.views_doc.document_html' name='rfc4228' %}">RFC 4228</a>.
169171
</p>
170172

171-
{% endblock %}
173+
{% endblock %}

ietf/templates/submit/upload_submission.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@
2424
{% if not form.shutdown or user|has_role:"Secretariat" %}
2525
<p class="alert alert-warning">
2626
By submitting your I-D, you are granting some rights to the IETF Trust.
27-
Before you submit your I-D, review the information on the NOTE WELL tab and
27+
Before you submit your I-D, review the information in the
28+
<a href="https://www.ietf.org/about/note-well/">Note Well</a> and
2829
<a href="{% url 'ietf.doc.views_doc.document_html' name='rfc5378' %}">BCP 78</a>,
2930
"Rights Contributors Provide to the IETF Trust".
3031
</p>

0 commit comments

Comments
 (0)