Made ietf/liaisons pyflakes-clean, which also fixed several places the code would crash. The IRTF chair can never have been able to use the liaison tool without getting a server 500 ...

 - Legacy-Id: 7471

Author: levkowetz

ietf/liaisons/__init__.py

@@ -2,7 +2,6 @@
 # coding: latin-1
 
 from types import ModuleType
-import urls, models, views, forms, admin, utils, widgets, sitemaps, feeds
 
 # These people will be sent a stack trace if there's an uncaught exception in
 # code any of the modules imported above:

ietf/liaisons/admin.py

@@ -1,6 +1,6 @@
 from django.contrib import admin
 
-from ietf.liaisons.models import *
+from ietf.liaisons.models import LiaisonStatement
 
 class LiaisonStatementAdmin(admin.ModelAdmin):
     list_display = ['id', 'title', 'from_name', 'to_name', 'submitted', 'purpose', 'related_to']

ietf/liaisons/feeds.py

@@ -1,8 +1,7 @@
 # Copyright The IETF Trust 2007, All Rights Reserved
 
-import re, datetime
+import re
 
-from django.conf import settings
 from django.contrib.syndication.views import Feed, FeedDoesNotExist
 from django.utils.feedgenerator import Atom1Feed
 from django.template.loader import render_to_string

ietf/liaisons/forms.py

@@ -3,7 +3,6 @@
 
 from django import forms
 from django.conf import settings
-from django.db.models import Q
 from django.forms.util import ErrorList
 from django.core.validators import validate_email, ValidationError
 from django.template.loader import render_to_string

ietf/liaisons/management/commands/check_liaison_deadlines.py

@@ -1,9 +1,6 @@
 import datetime
 
-from django.conf import settings
 from django.core.management.base import BaseCommand
-from django.template.loader import render_to_string
-from django.core.urlresolvers import reverse as urlreverse
 
 from ietf.liaisons.models import LiaisonStatement
 from ietf.liaisons.mails import possibly_send_deadline_reminder
@@ -20,4 +17,4 @@ def handle(self, *args, **options):
         for l in LiaisonStatement.objects.filter(action_taken=False, deadline__gte=cutoff).exclude(deadline=None):
             r = possibly_send_deadline_reminder(l)
             if r:
-                print 'Liaison %05s#: Deadline reminder sent!' % liaison.pk
+                print 'Liaison %05s#: Deadline reminder sent!' % l.pk

ietf/liaisons/management/commands/remind_update_sdo_list.py

@@ -1,9 +1,6 @@
 from optparse import make_option
 
-from django.conf import settings
-from django.core.mail import EmailMessage
 from django.core.management.base import BaseCommand
-from django.template.loader import render_to_string
 
 from ietf.group.models import Group
 from ietf.liaisons.mails import send_sdo_reminder

ietf/liaisons/sitemaps.py

@@ -1,7 +1,6 @@
 # Copyright The IETF Trust 2007, All Rights Reserved
 #
 from django.contrib.sitemaps import Sitemap
-from django.conf import settings
 
 from ietf.liaisons.models import LiaisonStatement
 

ietf/liaisons/tests.py

@@ -441,7 +441,7 @@ def test_add_outgoing_liaison(self):
 
     def test_send_sdo_reminder(self):
         make_test_data()
-        liaison = make_liaison_models()
+        make_liaison_models()
 
         mailbox_before = len(outbox)
         send_sdo_reminder(Group.objects.filter(type="sdo")[0])

ietf/liaisons/utils.py

@@ -1,12 +1,11 @@
 from django.db.models import Q
 
 from ietf.group.models import Group, Role
-from ietf.person.models import Person
 from ietf.liaisons.models import LiaisonStatement
 from ietf.ietfauth.utils import has_role, passes_test_decorator
 
-from ietf.liaisons.accounts import (is_ietfchair, is_iabchair, is_iab_executive_director,
-                                    get_ietf_chair, get_iab_chair, get_iab_executive_director,
+from ietf.liaisons.accounts import (is_ietfchair, is_iabchair, is_iab_executive_director, is_irtfchair,
+                                    get_ietf_chair, get_iab_chair, get_iab_executive_director, get_irtf_chair,
                                     is_secretariat, can_add_liaison, get_person_for_user, proxy_personify_role)
 
 can_submit_liaison_required = passes_test_decorator(

ietf/liaisons/views.py

@@ -1,17 +1,16 @@
 # Copyright The IETF Trust 2007, All Rights Reserved
-import datetime, json
+import datetime
+import json
 from email.utils import parseaddr
 
-from django.conf import settings
-from django.core.urlresolvers import reverse
 from django.core.validators import validate_email, ValidationError
-from django.http import HttpResponse, HttpResponseRedirect, HttpResponseForbidden
+from django.http import HttpResponse, HttpResponseForbidden
 from django.shortcuts import render_to_response, get_object_or_404, redirect
 from django.template import RequestContext
 
 from ietf.liaisons.models import LiaisonStatement
 from ietf.liaisons.accounts import (get_person_for_user, can_add_outgoing_liaison,
-                                    can_add_incoming_liaison, LIAISON_EDIT_GROUPS,
+                                    can_add_incoming_liaison, 
                                     is_ietfchair, is_iabchair, is_iab_executive_director,
                                     can_edit_liaison, is_secretariat)
 from ietf.liaisons.forms import liaison_form_factory