Improve secretariat rolodex roles section, sort and identify concluded groups. Commit ready for merge.

 - Legacy-Id: 10159

Author: rpcross

ietf/secr/rolodex/views.py

@@ -274,9 +274,11 @@ def view(request, id):
 
     # must filter for active emails only
     person.emails = person.email_set.filter(active=True)
+    roles = person.role_set.all().order_by('name__name','group__acronym')
 
     return render_to_response('rolodex/view.html', {
-        'person': person},
+        'person': person,
+        'roles': roles},
         RequestContext(request, {}),
     )
 

ietf/secr/templates/rolodex/view.html

@@ -39,18 +39,14 @@ <h2><b>Roles</b></h2>
           </tr>
         </thead>
         <tbody>
-          {% for role in person.role_set.all %}
+          {% for role in roles %}
             <tr>
                 <td>{{ role.name }} </td>
                 <td>
-                  {% if role.group.type.slug == "wg" %}
-                    <a href="{% url "groups_view" acronym=role.group.acronym %}">{{ role.group.acronym }}</a>
+                  {% if role.group.type.slug == "area" %}
+                      <a href="{% url "areas_view" name=role.group.acronym %}">{{ role.group.acronym }}{% if role.group.state.slug == "conclude" %} (concluded){% endif %}</a>
                   {% else %}
-                    {% if role.group.type.slug == "area" %}
-                      <a href="{% url "areas_view" name=role.group.acronym %}">{{ role.group.acronym }}</a>
-                    {% else %}
-                      {{ role.group }}
-                    {% endif %}
+                    <a href="{% url "groups_view" acronym=role.group.acronym %}">{{ role.group.acronym }}{% if role.group.state.slug == "conclude" %} (concluded){% endif %}</a>
                   {% endif %}
                 </td>
                 <td>{{ role.email }}</td>