Skip to content

Commit 1057dbf

Browse files
committed
Make comments optional on WG adoption and WG state changes.
- Legacy-Id: 5001
1 parent aba18e8 commit 1057dbf

4 files changed

Lines changed: 14 additions & 7 deletions

File tree

debug.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,15 @@
11
import sys
22
import time as timeutils
33
import inspect
4-
import syslog
5-
from pprint import pformat
4+
try:
5+
import syslog
6+
write = syslog.syslog
7+
except ImportError: # import syslog will fail on Windows boxes
8+
import sys
9+
write = lambda x: sys.stderr.write(x+"\n")
10+
except ImportError:
11+
from pprint import pformat
12+
613
import cProfile
714
try:
815
from django.conf import settings
@@ -137,4 +144,4 @@ def wrapper(*args, **kwargs):
137144
return decorator(wrapper, fn)
138145
else:
139146
return fn
140-
147+

ietf/ietfworkflows/forms.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def __unicode__(self):
5151

5252

5353
class NoWorkflowStateForm(StreamDraftForm):
54-
comment = forms.CharField(widget=forms.Textarea)
54+
comment = forms.CharField(widget=forms.Textarea, required=False)
5555
weeks = forms.IntegerField(required=False)
5656
wg = forms.ChoiceField(required=False)
5757

@@ -150,7 +150,7 @@ def save(self):
150150

151151
class DraftTagsStateForm(StreamDraftForm):
152152

153-
comment = forms.CharField(widget=forms.Textarea)
153+
comment = forms.CharField(widget=forms.Textarea, required=False)
154154
new_state = forms.ChoiceField()
155155
weeks = forms.IntegerField(required=False)
156156
tags = forms.MultipleChoiceField(widget=forms.CheckboxSelectMultiple, required=False)

ietf/templates/ietfworkflows/noworkflow_state_form.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<tr style="vertical-align: top;"><td style="width: 50%;">
77
<div class="field{% if form.errors.comment %} error{% endif %}">
88
{{ form.comment.errors }}
9-
Comment: <span class="required">*</span><br />
9+
Comment: <br/>
1010
<textarea name="comment">{{ form.data.comment }}</textarea>
1111
</div>
1212
<div class="field{% if form.errors.weeks %} error{% endif %}">

ietf/templates/ietfworkflows/state_form.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<tr style="vertical-align: top;"><td style="width: 50%;">
88
<div class="field{% if form.comment.errors %} error{% endif %}">
99
{{ form.comment.errors }}
10-
Comment: <span class="required">*</span><br />
10+
Comment: <br/>
1111
<textarea name="comment">{{ form.data.comment }}</textarea>
1212
</div>
1313
<div class="field{% if form.weeks.errors %} error{% endif %}">

0 commit comments

Comments
 (0)