Skip to content

Commit 104878a

Browse files
committed
Fix message formatting in IPR event history. Commit ready for merge
- Legacy-Id: 10079
1 parent 6c0f4b3 commit 104878a

2 files changed

Lines changed: 6 additions & 21 deletions

File tree

ietf/ipr/templatetags/ipr_filters.py

Lines changed: 5 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,22 @@
11
# Copyright The IETF Trust 2014, All Rights Reserved
22

33
from django import template
4-
from django.utils.safestring import mark_safe
5-
4+
from django.utils.html import format_html
65

76
register = template.Library()
87

98

10-
# @register.filter
11-
# def first_type(queryset, type):
12-
# first = queryset.filter(type_id=type).first()
13-
# return first.time if first else None
14-
159
@register.filter
1610
def render_message_for_history(msg):
1711
"""Format message for display in history. Suppress the 'To' line for incoming responses
1812
"""
1913
if msg.to.startswith('ietf-ipr+'):
20-
text = u'''Date: {}
21-
From: {}
22-
Subject: {}
23-
Cc: {}
24-
25-
<pre>{}</pre>'''.format(msg.time,msg.frm,msg.subject,msg.cc,msg.body)
14+
return format_html('Date: {}<br>From: {}<br>Subject: {}<br>Cc: {}<br><br>{}',
15+
msg.time,msg.frm,msg.subject,msg.cc,msg.body)
2616
else:
27-
text = u'''Date: {}
28-
From: {}
29-
To: {}
30-
Subject: {}
31-
Cc: {}
17+
return format_html('Date: {}<br>From: {}<br>To: {}<br>Subject: {}<br>Cc: {}<br><br>{}',
18+
msg.time,msg.frm,msg.to,msg.subject,msg.cc,msg.body)
3219

33-
<pre>{}</pre>'''.format(msg.time,msg.frm,msg.to,msg.subject,msg.cc,msg.body)
34-
return mark_safe(text)
3520

3621
@register.filter
3722
def to_class_name(value):

ietf/templates/ipr/details_history.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ <h1>History for IPR disclosure<br><small>{{ ipr.title }}</small></h1>
4141
</td>
4242
<td>{{ e.by }}</td>
4343
{% if e.message %}
44-
<td>{{ e.message|render_message_for_history|format_history_text:"100" }}
44+
<td>{{ e.message|render_message_for_history|format_history_text:"100"|safe }}
4545
{% if e.response_due %}
4646
<br>Response Due: {{ e.response_due|date:"Y-m-d" }}
4747
{% endif %}

0 commit comments

Comments
 (0)