Skip to content

Commit 0f6a886

Browse files
committed
Corrected the extent of a try/except block, moving more code inside the block. Fixes a submission exception that should just be a document error reported back to the user.
- Legacy-Id: 17411
1 parent ec13af6 commit 0f6a886

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

ietf/submit/forms.py

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -317,22 +317,22 @@ def format_messages(where, e, log):
317317
txt_file.seek(0)
318318
try:
319319
text = bytes.decode(self.file_info['txt'].charset)
320+
#
321+
self.parsed_draft = Draft(text, txt_file.name)
322+
if self.filename == None:
323+
self.filename = self.parsed_draft.filename
324+
elif self.filename != self.parsed_draft.filename:
325+
self.add_error('txt', "Inconsistent name information: xml:%s, txt:%s" % (self.filename, self.parsed_draft.filename))
326+
if self.revision == None:
327+
self.revision = self.parsed_draft.revision
328+
elif self.revision != self.parsed_draft.revision:
329+
self.add_error('txt', "Inconsistent revision information: xml:%s, txt:%s" % (self.revision, self.parsed_draft.revision))
330+
if self.title == None:
331+
self.title = self.parsed_draft.get_title()
332+
elif self.title != self.parsed_draft.get_title():
333+
self.add_error('txt', "Inconsistent title information: xml:%s, txt:%s" % (self.title, self.parsed_draft.get_title()))
320334
except (UnicodeDecodeError, LookupError) as e:
321335
self.add_error('txt', 'Failed decoding the uploaded file: "%s"' % str(e))
322-
#
323-
self.parsed_draft = Draft(text, txt_file.name)
324-
if self.filename == None:
325-
self.filename = self.parsed_draft.filename
326-
elif self.filename != self.parsed_draft.filename:
327-
self.add_error('txt', "Inconsistent name information: xml:%s, txt:%s" % (self.filename, self.parsed_draft.filename))
328-
if self.revision == None:
329-
self.revision = self.parsed_draft.revision
330-
elif self.revision != self.parsed_draft.revision:
331-
self.add_error('txt', "Inconsistent revision information: xml:%s, txt:%s" % (self.revision, self.parsed_draft.revision))
332-
if self.title == None:
333-
self.title = self.parsed_draft.get_title()
334-
elif self.title != self.parsed_draft.get_title():
335-
self.add_error('txt', "Inconsistent title information: xml:%s, txt:%s" % (self.title, self.parsed_draft.get_title()))
336336

337337
# The following errors are likely noise if we have previous field
338338
# errors:

0 commit comments

Comments
 (0)