Skip to content

Commit 0d6fe71

Browse files
committed
make sure that site_base_url has not got a trailing /, as that is harder to deal with in JS
- Legacy-Id: 6330
1 parent f064ec1 commit 0d6fe71

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

r6328/ietf/meeting/helpers.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,16 @@ def scheduledsessions_by_area(self):
126126
def slot_decor(self):
127127
return self.timeslot.slot_decor
128128

129+
def build_url_pair(request, meeting):
130+
meeting_base_url = request.build_absolute_uri(meeting.base_url())
131+
site_base_url = request.build_absolute_uri('/')
132+
133+
# remove trailing / from site_base_url.
134+
if site_base_url[-1:]=='/':
135+
site_base_url = site_base_url[:-1]
136+
137+
return site_base_url, meeting_base_url
138+
129139
def get_ntimeslots_from_ss(agenda, scheduledsessions):
130140
ntimeslots = []
131141
time_seen = set()

r6328/ietf/meeting/views.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
from ietf.meeting.models import Schedule, ScheduledSession, Room
4141
from ietf.group.models import Group
4242

43-
from ietf.meeting.helpers import NamedTimeSlot, get_ntimeslots_from_ss
43+
from ietf.meeting.helpers import NamedTimeSlot, get_ntimeslots_from_ss, build_url_pair
4444
from ietf.meeting.helpers import get_ntimeslots_from_agenda, agenda_info
4545
from ietf.meeting.helpers import get_areas, get_area_list_from_sessions, get_pseudo_areas
4646
from ietf.meeting.helpers import build_all_agenda_slices, get_wg_name_list
@@ -239,8 +239,7 @@ def edit_timeslots(request, num=None):
239239

240240
time_slices,date_slices,slots = meeting.build_timeslices()
241241

242-
meeting_base_url = request.build_absolute_uri(meeting.base_url())
243-
site_base_url =request.build_absolute_uri('/')
242+
site_base_url, meeting_base_url = build_url_pair(request, meeting)
244243
rooms = meeting.room_set.order_by("capacity")
245244
rooms = rooms.all()
246245

@@ -288,8 +287,7 @@ def edit_agenda(request, num=None, schedule_name=None):
288287
schedule = get_schedule(meeting, schedule_name)
289288
#sys.stdout.write("2 requestor: %u for sched owned by: %u \n" % ( requestor.id, schedule.owner.id ))
290289

291-
meeting_base_url = request.build_absolute_uri(meeting.base_url())
292-
site_base_url =request.build_absolute_uri('/')
290+
site_base_url, meeting_base_url = build_url_pair(request, meeting)
293291
rooms = meeting.room_set.order_by("capacity")
294292
rooms = rooms.all()
295293
saveas = SaveAsForm()

0 commit comments

Comments
 (0)