Skip to content

Commit 0d1c0b2

Browse files
committed
updates to announcements and groups view to match secretariat production branch
- Legacy-Id: 6140
1 parent 62f83fc commit 0d1c0b2

2 files changed

Lines changed: 20 additions & 17 deletions

File tree

ietf/secr/announcement/views.py

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ def check_access(user):
3838
group__acronym='iab',
3939
name='execdir'):
4040
return True
41-
41+
4242
return False
43-
43+
4444
# --------------------------------------------------
4545
# STANDARD VIEW FUNCTIONS
4646
# --------------------------------------------------
@@ -54,12 +54,16 @@ def main(request):
5454
'''
5555
if not check_access(request.user):
5656
return HttpResponseForbidden('Restricted to: Secretariat, IAD, or chair of IETF, IAB, RSOC, RSE, IAOC, NomCom.')
57-
57+
5858
form = AnnounceForm(request.POST or None,user=request.user)
59-
59+
6060
if form.is_valid():
61-
request.session['data'] = form.cleaned_data
62-
61+
# nomcom is a ModelChoice, store pk, not Group object
62+
data = form.cleaned_data
63+
if data['nomcom']:
64+
data['nomcom'] = data['nomcom'].pk
65+
request.session['data'] = data
66+
6367
url = reverse('announcement_confirm')
6468
return HttpResponseRedirect(url)
6569

@@ -70,40 +74,39 @@ def main(request):
7074

7175
@check_for_cancel('../')
7276
def confirm(request):
73-
74-
# testing
75-
#assert False, (request.session.get_expiry_age(),request.session.get_expiry_date())
76-
77+
7778
if request.method == 'POST':
7879
form = AnnounceForm(request.session['data'],user=request.user)
7980
message = form.save(user=request.user,commit=True)
80-
send_mail_text(None,
81+
extra = {'Reply-To':message.reply_to}
82+
send_mail_text(None,
8183
message.to,
8284
message.frm,
8385
message.subject,
8486
message.body,
8587
cc=message.cc,
86-
bcc=message.bcc)
88+
bcc=message.bcc,
89+
extra=extra)
8790

8891
# clear session
8992
request.session.clear()
90-
93+
9194
messages.success(request, 'The announcement was sent.')
9295
url = reverse('announcement')
9396
return HttpResponseRedirect(url)
94-
97+
9598
if request.session.get('data',None):
9699
data = request.session['data']
97100
else:
98101
messages.error(request, 'No session data. Your session may have expired or cookies are disallowed.')
99102
redirect_url = reverse('announcement')
100103
return HttpResponseRedirect(redirect_url)
101-
104+
102105
if data['to'] == 'Other...':
103106
to = ','.join(data['to_custom'])
104107
else:
105108
to = data['to']
106-
109+
107110
return render_to_response('announcement/confirm.html', {
108111
'message': data,
109112
'to': to},

ietf/secr/groups/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def add_legacy_fields(group):
5555
group.chairs = group.role_set.filter(name="chair")
5656
group.techadvisors = group.role_set.filter(name="techadv")
5757
group.editors = group.role_set.filter(name="editor")
58-
group.secretaries = group.role_set.filter(name="secretaries")
58+
group.secretaries = group.role_set.filter(name="secr")
5959

6060
#fill_in_charter_info(group)
6161

0 commit comments

Comments
 (0)