Skip to content

Commit 0d1be60

Browse files
committed
Only show links to web pages when they are valid (which many seem to
no be at the moment - fallout from the tools.ietf.org move?) Also move letter icons consistently after the name. Commit ready for merge. - Legacy-Id: 19472
1 parent 63f1df0 commit 0d1be60

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

ietf/templates/group/active_wgs.html

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,21 @@ <h3>{{ area.acronym }} Area Director{{ area.ads_and_pre_ads|pluralize }} (AD{{ a
2929
<ul class="list-unstyled">
3030
{% for ad in area.ads_and_pre_ads %}
3131
<li>
32-
<a href="mailto:{{ ad.email.address }}"><span class="fa fa-envelope-o tiny"></span></a>
3332
<a href="{% url 'ietf.person.views.profile' email_or_name=ad.person.name %}">{{ ad.person.plain_name }}</a>
33+
<a href="mailto:{{ ad.email.address }}"><span class="fa fa-envelope-o tiny"></span></a>
3434
{% if ad.name == "pre-ad" %} (Incoming AD){% endif %}
3535
</li>
3636
{% endfor %}
3737
</ul>
3838
{% endif %}
3939

40-
{% if area.urls %}
40+
{% if area.urls.is_valid %}
4141
<h3>{{ area.acronym }} area-specific web page{{ area.urls|pluralize}}</h3>
4242
<ul class="list-unstyled">
4343
{% for url in area.urls %}
44+
{% if url.is_valid %}
4445
<li><a href="{{ url.url }}">{{ url.name }}</a></li>
46+
{% endif %}
4547
{% endfor %}
4648
</ul>
4749
{% endif %}
@@ -63,8 +65,8 @@ <h3>{{ area.acronym }} active WG{{ area.groups|pluralize}} ({{area.groups.count}
6365
<td><div class="anchor-target" id="{{group.acronym}}"><a href="{% url "ietf.group.views.group_home" group_type=group.type_id acronym=group.acronym %}">{{ group.acronym }}</a></div></td>
6466
<td>
6567
{% if group.ad_role %}
66-
<a href="mailto:{{ group.ad_role.email.address }}"><span class="fa fa-envelope-o tiny"></span></a>
6768
<a href="{% url 'ietf.person.views.profile' email_or_name=group.ad_role.person.name %}">{{ group.ad_role.person.plain_name.split.0 }}</a>
69+
<a href="mailto:{{ group.ad_role.email.address }}"><span class="fa fa-envelope-o tiny"></span></a>
6870
{% endif %}
6971
</td>
7072
<td>{{ group.name }}</td>
@@ -97,4 +99,4 @@ <h3>No active {{ area.acronym }} WGs</h3>
9799

98100
{% block js %}
99101
<script src="{% static "jquery.tablesorter/js/jquery.tablesorter.combined.min.js" %}"></script>
100-
{% endblock %}
102+
{% endblock %}

0 commit comments

Comments
 (0)