Skip to content

Commit 097b936

Browse files
committed
Remove secauth middleware. Replace with role_required decorators. Commit ready for merge
- Legacy-Id: 8624
1 parent 882e0af commit 097b936

22 files changed

Lines changed: 139 additions & 71 deletions

File tree

ietf/secr/announcement/views.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from django.contrib import messages
2+
from django.contrib.auth.decorators import login_required
23
from django.http import HttpResponseForbidden
34
from django.shortcuts import render_to_response, redirect
45
from django.template import RequestContext
@@ -45,6 +46,7 @@ def check_access(user):
4546
# --------------------------------------------------
4647
# this seems to cause some kind of circular problem
4748
# @check_for_cancel(reverse('home'))
49+
@login_required
4850
@check_for_cancel('../')
4951
def main(request):
5052
'''
@@ -70,6 +72,7 @@ def main(request):
7072
RequestContext(request, {}),
7173
)
7274

75+
@login_required
7376
@check_for_cancel('../')
7477
def confirm(request):
7578

ietf/secr/areas/views.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
from ietf.group.models import Group, GroupEvent, GroupURL, Role, ChangeStateGroupEvent
1212
from ietf.group.utils import save_group_in_history
13+
from ietf.ietfauth.utils import role_required
1314
from ietf.person.models import Person
1415
from ietf.secr.areas.forms import AWPAddModelForm, AWPForm, AddAreaModelForm, AreaDirectorForm, AreaForm
1516

@@ -49,7 +50,7 @@ def getemails(request):
4950
# --------------------------------------------------
5051
# STANDARD VIEW FUNCTIONS
5152
# --------------------------------------------------
52-
53+
@role_required('Secretariat')
5354
def add(request):
5455
"""
5556
Add a new IETF Area
@@ -95,6 +96,7 @@ def add(request):
9596
RequestContext(request, {}),
9697
)
9798

99+
@role_required('Secretariat')
98100
def edit(request, name):
99101
"""
100102
Edit IETF Areas
@@ -159,6 +161,7 @@ def edit(request, name):
159161
RequestContext(request,{}),
160162
)
161163

164+
@role_required('Secretariat')
162165
def list_areas(request):
163166
"""
164167
List IETF Areas
@@ -180,6 +183,7 @@ def list_areas(request):
180183
RequestContext(request, {}),
181184
)
182185

186+
@role_required('Secretariat')
183187
def people(request, name):
184188
"""
185189
Edit People associated with Areas, Area Directors.
@@ -229,6 +233,7 @@ def people(request, name):
229233
RequestContext(request, {}),
230234
)
231235

236+
@role_required('Secretariat')
232237
def modify(request, name):
233238
"""
234239
Handle state changes of Area Directors (enable voting, retire)
@@ -285,6 +290,7 @@ def modify(request, name):
285290

286291
return redirect('areas_view', name=name)
287292

293+
@role_required('Secretariat')
288294
def view(request, name):
289295
"""
290296
View Area information.

ietf/secr/console/views.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
from django.template import RequestContext
44

55
from ietf.doc.models import DocEvent
6+
from ietf.ietfauth.utils import role_required
67

8+
@role_required('Secretariat')
79
def main(request):
810
'''
911
Main view for the Console

ietf/secr/drafts/views.py

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
from ietf.doc.models import Document, DocumentAuthor, DocAlias, DocRelationshipName, RelatedDocument, State
1616
from ietf.doc.models import DocEvent, NewRevisionDocEvent
1717
from ietf.doc.models import save_document_in_history
18+
from ietf.ietfauth.utils import role_required
1819
from ietf.meeting.models import Meeting
1920
from ietf.meeting.helpers import get_meeting
2021
from ietf.name.models import StreamName
@@ -484,6 +485,7 @@ def report_progress_report(start_date,end_date):
484485
# -------------------------------------------------
485486
# Standard View Functions
486487
# -------------------------------------------------
488+
@role_required('Secretariat')
487489
def abstract(request, id):
488490
'''
489491
View Internet Draft Abstract
@@ -503,6 +505,7 @@ def abstract(request, id):
503505
RequestContext(request, {}),
504506
)
505507

508+
@role_required('Secretariat')
506509
def add(request):
507510
'''
508511
Add Internet Draft
@@ -594,6 +597,7 @@ def add(request):
594597
RequestContext(request, {}),
595598
)
596599

600+
@role_required('Secretariat')
597601
def announce(request, id):
598602
'''
599603
Schedule announcement of new Internet-Draft to I-D Announce list
@@ -618,6 +622,7 @@ def announce(request, id):
618622
messages.success(request, 'Announcement scheduled successfully!')
619623
return redirect('drafts_view', id=id)
620624

625+
@role_required('Secretariat')
621626
def approvals(request):
622627
'''
623628
This view handles setting Initial Approval for drafts
@@ -632,6 +637,7 @@ def approvals(request):
632637
RequestContext(request, {}),
633638
)
634639

640+
@role_required('Secretariat')
635641
def author_delete(request, id, oid):
636642
'''
637643
This view deletes the specified author(email) from the draft
@@ -640,6 +646,7 @@ def author_delete(request, id, oid):
640646
messages.success(request, 'The author was deleted successfully')
641647
return redirect('drafts_authors', id=id)
642648

649+
@role_required('Secretariat')
643650
def authors(request, id):
644651
'''
645652
Edit Internet Draft Authors
@@ -687,6 +694,7 @@ def authors(request, id):
687694
RequestContext(request, {}),
688695
)
689696

697+
@role_required('Secretariat')
690698
def confirm(request, id):
691699
'''
692700
This view displays changes that will be made and calls appropriate
@@ -737,6 +745,7 @@ def confirm(request, id):
737745
RequestContext(request, {}),
738746
)
739747

748+
@role_required('Secretariat')
740749
def dates(request):
741750
'''
742751
Manage ID Submission Dates
@@ -756,6 +765,7 @@ def dates(request):
756765
RequestContext(request, {}),
757766
)
758767

768+
@role_required('Secretariat')
759769
def edit(request, id):
760770
'''
761771
Since there's a lot going on in this function we are summarizing in the docstring.
@@ -804,6 +814,7 @@ def edit(request, id):
804814
'draft': draft},
805815
)
806816

817+
@role_required('Secretariat')
807818
def email(request, id):
808819
'''
809820
This function displays the notification message and allows the
@@ -849,6 +860,7 @@ def email(request, id):
849860
RequestContext(request, {}),
850861
)
851862

863+
@role_required('Secretariat')
852864
def extend(request, id):
853865
'''
854866
This view handles extending the expiration date for an Internet-Draft
@@ -880,6 +892,7 @@ def extend(request, id):
880892
RequestContext(request, {}),
881893
)
882894

895+
@role_required('Secretariat')
883896
def makerfc(request, id):
884897
'''
885898
Make RFC out of Internet Draft
@@ -954,6 +967,7 @@ def makerfc(request, id):
954967
RequestContext(request, {}),
955968
)
956969

970+
@role_required('Secretariat')
957971
def nudge_report(request):
958972
'''
959973
This view produces the Nudge Report, basically a list of documents that are in the IESG
@@ -967,6 +981,7 @@ def nudge_report(request):
967981
RequestContext(request, {}),
968982
)
969983

984+
@role_required('Secretariat')
970985
def replace(request, id):
971986
'''
972987
This view handles replacing one Internet-Draft with another
@@ -998,6 +1013,7 @@ def replace(request, id):
9981013
RequestContext(request, {}),
9991014
)
10001015

1016+
@role_required('Secretariat')
10011017
def resurrect(request, id):
10021018
'''
10031019
This view handles resurrection of an Internet-Draft
@@ -1008,6 +1024,7 @@ def resurrect(request, id):
10081024
request.session['action'] = 'resurrect'
10091025
return redirect('drafts_email', id=id)
10101026

1027+
@role_required('Secretariat')
10111028
def revision(request, id):
10121029
'''
10131030
This function presents the input form for the New Revision action. If submitted
@@ -1047,6 +1064,7 @@ def revision(request, id):
10471064
RequestContext(request, {}),
10481065
)
10491066

1067+
@role_required('Secretariat')
10501068
def search(request):
10511069
'''
10521070
Search Internet Drafts
@@ -1118,6 +1136,7 @@ def search(request):
11181136
RequestContext(request, {}),
11191137
)
11201138

1139+
@role_required('Secretariat')
11211140
def update(request, id):
11221141
'''
11231142
This view handles the Update action for an Internet-Draft
@@ -1159,6 +1178,7 @@ def update(request, id):
11591178
RequestContext(request, {}),
11601179
)
11611180

1181+
@role_required('Secretariat')
11621182
def view(request, id):
11631183
'''
11641184
View Internet Draft
@@ -1219,6 +1239,7 @@ def view(request, id):
12191239
RequestContext(request, {}),
12201240
)
12211241

1242+
@role_required('Secretariat')
12221243
def withdraw(request, id):
12231244
'''
12241245
This view handles withdrawing an Internet-Draft

ietf/secr/groups/views.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
from ietf.group.models import Group, GroupMilestone, ChangeStateGroupEvent, GroupEvent, GroupURL, Role
77
from ietf.group.utils import save_group_in_history, get_charter_text
8+
from ietf.ietfauth.utils import role_required
89
from ietf.person.models import Person
910
from ietf.secr.groups.forms import GroupModelForm, GroupMilestoneForm, RoleForm, SearchForm
1011
from ietf.secr.areas.forms import AWPForm
@@ -69,6 +70,7 @@ def get_ads(request):
6970
# Standard View Functions
7071
# -------------------------------------------------
7172

73+
@role_required('Secretariat')
7274
def add(request):
7375
'''
7476
Add a new IETF or IRTF Group
@@ -119,6 +121,7 @@ def add(request):
119121
RequestContext(request, {}),
120122
)
121123

124+
@role_required('Secretariat')
122125
def blue_dot(request):
123126
'''
124127
This is a report view. It returns a text/plain listing of chairs for active and bof groups.
@@ -144,6 +147,7 @@ def blue_dot(request):
144147
RequestContext(request, {}), content_type="text/plain",
145148
)
146149

150+
@role_required('Secretariat')
147151
def charter(request, acronym):
148152
"""
149153
View Group Charter
@@ -171,6 +175,7 @@ def charter(request, acronym):
171175
RequestContext(request, {}),
172176
)
173177

178+
@role_required('Secretariat')
174179
def delete_role(request, acronym, id):
175180
"""
176181
Handle deleting roles for groups (chair, editor, advisor, secretary)
@@ -193,6 +198,7 @@ def delete_role(request, acronym, id):
193198
messages.success(request, 'The entry was deleted successfully')
194199
return redirect('groups_people', acronym=acronym)
195200

201+
@role_required('Secretariat')
196202
def edit(request, acronym):
197203
"""
198204
Edit Group details
@@ -269,6 +275,7 @@ def edit(request, acronym):
269275
RequestContext(request, {}),
270276
)
271277

278+
@role_required('Secretariat')
272279
def edit_gm(request, acronym):
273280
"""
274281
Edit IETF Group Goal and Milestone details
@@ -305,6 +312,7 @@ def edit_gm(request, acronym):
305312
RequestContext(request, {}),
306313
)
307314

315+
@role_required('Secretariat')
308316
def people(request, acronym):
309317
"""
310318
Edit Group Roles (Chairs, Secretary, etc)
@@ -348,6 +356,7 @@ def people(request, acronym):
348356
RequestContext(request, {}),
349357
)
350358

359+
@role_required('Secretariat')
351360
def search(request):
352361
"""
353362
Search IETF Groups
@@ -426,6 +435,7 @@ def search(request):
426435
RequestContext(request, {}),
427436
)
428437

438+
@role_required('Secretariat')
429439
def view(request, acronym):
430440
"""
431441
View IETF Group details
@@ -449,6 +459,7 @@ def view(request, acronym):
449459
RequestContext(request, {}),
450460
)
451461

462+
@role_required('Secretariat')
452463
def view_gm(request, acronym):
453464
"""
454465
View IETF Group Goals and Milestones details

0 commit comments

Comments
 (0)