Fix issue where reviewers that left the team would be included in LeastRecentlyUsed

 - Legacy-Id: 17086

Author: Sasha Romijn

ietf/review/policies.py

@@ -422,7 +422,8 @@ def default_reviewer_rotation_list(self, include_unavailable=False, dont_skip_pe
         reviewers = list(Person.objects.filter(role__name="reviewer", role__group=self.team))
         assignments = ReviewAssignment.objects.filter(
             review_request__team=self.team,
-            state__in=['accepted', 'assigned', 'completed'],   
+            state__in=['accepted', 'assigned', 'completed'],
+            reviewer__person__in=reviewers,
         ).order_by('assigned_on').select_related('reviewer')
 
         reviewers_with_assignment = [assignment.reviewer.person for assignment in assignments]

ietf/review/test_policies.py

@@ -4,6 +4,7 @@
 from ietf.group.factories import ReviewTeamFactory
 from ietf.group.models import Group, Role
 from ietf.name.models import ReviewerQueuePolicyName
+from ietf.person.factories import PersonFactory
 from ietf.person.fields import PersonEmailChoiceField
 from ietf.person.models import Email
 from ietf.review.factories import ReviewAssignmentFactory, ReviewRequestFactory
@@ -243,6 +244,9 @@ def test_default_reviewer_rotation_list(self):
             start_date='2000-01-01',
             availability='canfinish',
         )
+        # This reviewer has an assignment, but is no longer in the team and should not be in rotation.
+        out_of_team_reviewer = PersonFactory()
+        ReviewAssignmentFactory(review_request__team=team, reviewer=out_of_team_reviewer.email())
 
         # No known assignments
         rotation = policy.default_reviewer_rotation_list()