Skip to content

Commit 05870ad

Browse files
Refactor get_related_meeting to simplify / correctly handle recording doctype
- Legacy-Id: 19339
1 parent 0782ee0 commit 05870ad

1 file changed

Lines changed: 3 additions & 13 deletions

File tree

ietf/doc/models.py

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -447,19 +447,9 @@ def get_related_meeting(self):
447447
"""Get the meeting this document relates to"""
448448
if not self.meeting_related():
449449
return None # no related meeting if not meeting_related!
450-
elif self.type_id in ("agenda", "minutes", "slides", "bluesheets",):
451-
# session-related
452-
session = self.get_related_session()
453-
if session is not None:
454-
return session.meeting
455-
elif self.type_id == "procmaterials":
456-
# proceedings-related
457-
material = self.get_related_proceedings_material()
458-
if material is not None:
459-
return material.meeting
460-
else:
461-
log.unreachable('2021-08-29') # if meeting_related, there must be a way to retrieve the meeting!
462-
return None
450+
# get an item that links this doc to a meeting
451+
item = self.get_related_session() or self.get_related_proceedings_material()
452+
return getattr(item, 'meeting', None)
463453

464454
def relations_that(self, relationship):
465455
"""Return the related-document objects that describe a given relationship targeting self."""

0 commit comments

Comments
 (0)