Skip to content

Commit 02cbe98

Browse files
author
Michael Lee
committed
* Add javascripts to the first step
* Add a method areadirectors_set to idtracker/models.py * Edit templates to adopt same look and feel with the existing tool - Legacy-Id: 550
1 parent acd5129 commit 02cbe98

6 files changed

Lines changed: 53 additions & 11 deletions

File tree

ietf/idtracker/models.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@ def __str__(self):
8181
def active_area_choices():
8282
return [(area.area_acronym_id, area.area_acronym.acronym) for area in Area.objects.filter(status=1).select_related().order_by('acronym.acronym')]
8383
active_area_choices = staticmethod(active_area_choices)
84+
def areadirectors_set(self):
85+
return AreaDirector.objects.filter(area=self.area_acronym)
8486
class Meta:
8587
db_table = 'areas'
8688
verbose_name="area"

ietf/mailinglists/forms.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ class NonWgStep1(forms.Form):
1313
list_id_delete = forms.ChoiceField(required=False)
1414
def add_edit_fields(self):
1515
field = self['add_edit']
16-
return field.as_widget(field.field.widget)
16+
#return field.as_widget(field.field.widget)
17+
return [re.sub(r'input ','input onClick="activate_nwg_widgets()" ',str(i)) for i in field.as_widget(field.field.widget)]
1718
def __init__(self, *args, **kwargs):
1819
super(NonWgStep1, self).__init__(*args, **kwargs)
1920
choices=[('', '--Select a list here')] + NonWgMailingList.choices()

ietf/mailinglists/views.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,15 +97,15 @@ def process_step(self, request, form, step):
9797
self.form_list.append(forms.form_for_instance(NonWgMailingList.objects.get(pk=form.clean_data['list_id']), formfield_callback=nonwg_callback))
9898
elif form.clean_data['add_edit'] == 'delete':
9999
list = NonWgMailingList.objects.get(pk=form.clean_data['list_id_delete'])
100-
self.form_list.append(gen_approval([ad.person_id for ad in list.area.areadirectors_set.all()], DeletionPickApprover))
100+
self.form_list.append(gen_approval([ad.person_id for ad in list.area.areadirectors_set()], DeletionPickApprover))
101101
self.form_list.append(Preview)
102102
else:
103103
self.clean_forms.append(form)
104104
if step == 1:
105105
form0 = self.clean_forms[0]
106106
add_edit = form0.clean_data['add_edit']
107107
if add_edit == 'add' or add_edit == 'edit':
108-
self.form_list.append(gen_approval([ad.person_id for ad in Area.objects.get(area_acronym=form.clean_data['area']).areadirectors_set.all()], PickApprover))
108+
self.form_list.append(gen_approval([ad.person_id for ad in Area.objects.get(area_acronym=form.clean_data['area']).areadirectors_set()], PickApprover))
109109
self.form_list.append(Preview)
110110
super(NonWgWizard, self).process_step(request, form, step)
111111
def done(self, request, form_list):
Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,24 @@
11
{% extends "mailinglists/nwg_wizard_base.html" %}
22

33
{% block nwgcontent %}
4+
<a href="/mailinglists/nonwg_lists/"><b>View Current list</b></a><br>
5+
</p><p>
6+
<h2>Step 3</h2>
47
<form action="." method="POST">
5-
FORM( {{ step }} ):<table> {{ form }} </table>
6-
7-
step_info : <input type="hidden" name="{{ step_field }}" value="{{ step }}" />
8-
9-
previous_fields: {{ previous_fields }}
8+
<input type="hidden" name="{{ step_field }}" value="{{ step }}" />
9+
{{ previous_fields }}
10+
<table bgcolor="#88AED2" cellspacing="1" border="0">
11+
<tr valign="top"><td>
12+
<table bgcolor="#f3f8fd" cellpadding="3" cellspacing="0" border="0">
13+
<tr><td colspan="2">
14+
<h3>Please select approving Area Director: </h3>
15+
</td></tr>
1016

17+
{{ form }}
18+
</table>
19+
</td></tr></table>
1120
<input type="submit">
1221
</form>
1322

14-
clean_forms: {{ clean_forms|escape }}
1523

1624
{% endblock %}

ietf/templates/mailinglists/nwg_wizard_base.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
ul.errorlist { color: red; border: 1px solid red; }
77
{% block nwgcss %}{% endblock %}
88
{% endblock %}
9-
109
{% block head %}
10+
{% block javascript %}{% endblock %}
1111
<link rel="stylesheet" type="text/css" href="http://www.ietf.org/css/base.css" />
1212
{% endblock %}
1313

ietf/templates/mailinglists/nwg_wizard_step0.html

Lines changed: 32 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,35 @@
11
{% extends "mailinglists/nwg_wizard_base.html" %}
2+
{% block javascript %}
3+
<script language="javascript">
4+
function get_selected_val() {
5+
buttons = document.form_post["0-add_edit"]
6+
selected = ""
7+
for (i = 0; i < buttons.length; i++)
8+
if (buttons[i].checked)
9+
selected = buttons[i].value
10+
return selected
11+
}
12+
13+
14+
function activate_nwg_widgets() {
15+
selected = get_selected_val()
16+
if (selected == "") {
17+
return
18+
}
19+
if (selected == "add") {
20+
document.form_post["0-list_id"].disabled=true
21+
document.form_post["0-list_id_delete"].disabled=true
22+
}
23+
if (selected == "edit") {
24+
document.form_post["0-list_id"].disabled=false
25+
document.form_post["0-list_id_delete"].disabled=true
26+
} if (selected == "delete") {
27+
document.form_post["0-list_id"].disabled=true
28+
document.form_post["0-list_id_delete"].disabled=false
29+
}
30+
}
31+
</script>
32+
{% endblock %}
233

334
{% block nwgcontent %}
435
<h4>Please use this Web tool to add a new entry to the <a href="/mailinglists/nonwg_lists/">IETF Non-WG Mailing Lists</a> Web page, to update the information on an existing entry, or to delete an existing entry.</h4>
@@ -7,7 +38,7 @@ <h4>Please use this Web tool to add a new entry to the <a href="/mailinglists/no
738
</p><p>
839
<h2>Step 1</h2>
940
<h3>Please select one:</h3>
10-
<form action="." method="POST" name="aform">
41+
<form action="." method="POST" name="form_post">
1142
{{ form.add_edit_fields.0 }}<br>
1243
{{ form.add_edit_fields.1 }}{{ form.list_id }}<br>
1344
{{ form.add_edit_fields.2 }}{{ form.list_id_delete }}<br>

0 commit comments

Comments
 (0)