Skip to content

Commit 019ca2a

Browse files
committed
Merge changes from attic/shimfree into new branch to complete rebasing shimfree on trunk
- Legacy-Id: 6215
2 parents c52efca + a871d6e commit 019ca2a

76 files changed

Lines changed: 941 additions & 2813 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

bin/mkdiagram

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ trap 'echo "$program($LINENO): Command failed with error code $? ($0 $*)"; exit
99
if [ "$*" ]; then apps="$@"; graph="${1%.*}"; else apps=$(ls */models.py | sed 's!/models.py!!'); graph="models"; fi
1010

1111
newapps="doc group meeting message person name"
12-
legacyapps="announcements idindex idrfc idtracker iesg ietfauth ietfworkflows ipr liaisons mailinglists proceedings redirects submit wgchairs wgcharter wginfo"
12+
legacyapps="announcements idindex idrfc idtracker iesg ietfauth ietfworkflows ipr liaisons mailinglists proceedings redirects submit wgcharter wginfo"
1313

1414
proxy="$(grep ^class */proxy.py | tr '()' ' ' | awk '{printf $2 ","}')"
1515
names="$(grep ^class name/models.py | tr '()' ' ' | awk '{printf $2 ","}')"

ietf/doc/proxy.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -194,11 +194,6 @@ def idinternal(self):
194194
def authors(self):
195195
return IDAuthor.objects.filter(document=self)
196196

197-
@property
198-
def protowriteup_set(self):
199-
from ietf.wgchairs.models import ProtoWriteUpProxy
200-
return ProtoWriteUpProxy.objects.filter(doc=self, type="changed_protocol_writeup")
201-
202197
# methods from InternetDraft
203198
def displayname(self):
204199
return self.name

ietf/doc/templatetags/ietf_filters.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
from django.template import resolve_variable
1010
from django.utils.safestring import mark_safe, SafeData
1111
from django.utils import simplejson
12+
from django.utils.html import strip_tags
1213
try:
1314
from email import utils as emailutils
1415
except ImportError:
@@ -475,6 +476,14 @@ def state(doc, slug):
475476
slug = "%s-stream-%s" % (doc.type_id, doc.stream_id)
476477
return doc.get_state(slug)
477478

479+
@register.filter
480+
def statehelp(state):
481+
"Output help icon with tooltip for state."
482+
from django.core.urlresolvers import reverse as urlreverse
483+
tooltip = escape(strip_tags(state.desc))
484+
url = urlreverse("state_help", kwargs=dict(type=state.type_id)) + "#" + state.slug
485+
return mark_safe('<a class="state-help-icon" href="%s" title="%s">?</a>' % (url, tooltip))
486+
478487
def _test():
479488
import doctest
480489
doctest.testmod()
@@ -483,11 +492,10 @@ def _test():
483492
_test()
484493

485494
@register.filter
486-
def plural(text, list, arg=u's'):
495+
def plural(text, seq, arg=u's'):
487496
"Similar to pluralize, but looks at the text, too"
488497
from django.template.defaultfilters import pluralize
489498
if text.endswith('s'):
490499
return text
491500
else:
492-
return text + pluralize(len(list), arg)
493-
501+
return text + pluralize(len(seq), arg)

ietf/doc/views_help.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,14 @@
33
from django.template import RequestContext
44

55
from ietf.doc.models import *
6+
from ietf.doc.utils import get_tags_for_stream_id
67

78
def state_help(request, type):
89
slug, title = {
910
"draft-iesg": ("draft-iesg", "IESG States For Internet-Drafts"),
1011
"draft-rfceditor": ("draft-rfceditor", "RFC Editor States For Internet-Drafts"),
1112
"draft-iana-action": ("draft-iana-action", "IANA Action States For Internet-Drafts"),
13+
"draft-stream-ietf": ("draft-stream-ietf", "IETF Stream States For Internet-Drafts"),
1214
"charter": ("charter", "Charter States"),
1315
"conflict-review": ("conflrev", "Conflict Review States"),
1416
"status-change": ("statchg", "RFC Status Change States"),
@@ -35,12 +37,14 @@ def state_help(request, type):
3537
states.insert(0, fake_state)
3638

3739
tags = DocTagName.objects.filter(slug__in=IESG_SUBSTATE_TAGS)
40+
elif state_type.slug.startswith("draft-stream-"):
41+
possible = get_tags_for_stream_id(state_type.slug.replace("draft-stream-", ""))
42+
tags = DocTagName.objects.filter(slug__in=possible)
3843

3944
return render_to_response("doc/state_help.html", {
4045
"title": title,
4146
"state_type": state_type,
4247
"states": states,
4348
"has_next_states": has_next_states,
4449
"tags": tags,
45-
},
46-
context_instance=RequestContext(request))
50+
}, context_instance=RequestContext(request))

ietf/group/proxy.py

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,19 @@ def proxied_role_emails(emails):
9494
proxy_role_email(e)
9595
return emails
9696

97+
class WGDelegateProxy(Role):
98+
#person = models.ForeignKey(PersonOrOrgInfo) # same name
99+
#wg = models.ForeignKey(IETFWG)
100+
@property
101+
def wg(self):
102+
return self.group
103+
104+
def __unicode__(self):
105+
return u"%s" % self.person
106+
107+
class Meta:
108+
proxy = True
109+
97110
class IETFWG(Group):
98111
objects = TranslatingManager(dict(group_acronym="id",
99112
group_acronym__acronym="acronym",
@@ -211,8 +224,7 @@ class Dummy: pass
211224
return d
212225
@property
213226
def wgdelegate_set(self):
214-
from ietf.wgchairs.models import WGDelegate
215-
return WGDelegate.objects.filter(group=self, name="delegate")
227+
return WGDelegateProxy.objects.filter(group=self, name="delegate")
216228

217229
class Meta:
218230
proxy = True

ietf/ietfworkflows/forms.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
from workflows.utils import set_workflow_for_object
88

99
from ietf.idtracker.models import PersonOrOrgInfo, IETFWG, InternetDraft
10-
from ietf.wgchairs.accounts import get_person_for_user
1110
from ietf.ietfworkflows.models import Stream, StreamDelegate
1211
from ietf.ietfworkflows.utils import (get_workflow_for_draft, get_workflow_for_wg,
1312
get_state_for_draft, get_state_by_name,
@@ -33,7 +32,10 @@ class StreamDraftForm(forms.Form):
3332
def __init__(self, *args, **kwargs):
3433
self.draft = kwargs.pop('draft', None)
3534
self.user = kwargs.pop('user', None)
36-
self.person = get_person_for_user(self.user)
35+
try:
36+
self.person = self.user.get_profile()
37+
except:
38+
self.person = None
3739
self.workflow = get_workflow_for_draft(self.draft)
3840
self.message = {}
3941
super(StreamDraftForm, self).__init__(*args, **kwargs)

ietf/ietfworkflows/templatetags/ietf_streams.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
from ietf.idrfc.idrfc_wrapper import IdRfcWrapper, IdWrapper
66
from ietf.ietfworkflows.utils import (get_workflow_for_draft,
77
get_state_for_draft)
8-
from ietf.wgchairs.accounts import (can_manage_shepherd_of_a_document,
9-
can_manage_writeup_of_a_document)
108
from ietf.ietfworkflows.streams import get_stream_from_wrapper
119
from ietf.ietfworkflows.models import Stream
1210
from ietf.ietfworkflows.accounts import (can_edit_state, can_edit_stream,

ietf/ietfworkflows/templatetags/ietf_streams_redesign.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
from ietf.idrfc.idrfc_wrapper import IdRfcWrapper, IdWrapper
66
from ietf.ietfworkflows.utils import (get_workflow_for_draft,
77
get_state_for_draft)
8-
from ietf.wgchairs.accounts import (can_manage_shepherd_of_a_document,
9-
can_manage_writeup_of_a_document)
108
from ietf.ietfworkflows.streams import get_stream_from_wrapper
119
from ietf.ietfworkflows.models import Stream
1210
from ietf.ietfworkflows.accounts import (can_edit_state, can_edit_stream,

ietf/secr/announcement/forms.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
from ietf.message.models import Message
99
from ietf.ietfauth.decorators import has_role
10-
from ietf.wgchairs.accounts import get_person_for_user
1110

1211
# ---------------------------------------------
1312
# Globals
@@ -180,7 +179,7 @@ def clean(self):
180179
def save(self, *args, **kwargs):
181180
user = kwargs.pop('user')
182181
message = super(AnnounceForm, self).save(commit=False)
183-
message.by = get_person_for_user(user)
182+
message.by = user.get_profile()
184183
if self.cleaned_data['to'] == 'Other...':
185184
message.to = self.cleaned_data['to_custom']
186185
if kwargs['commit']:

ietf/secr/announcement/views.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
from ietf.ietfauth.decorators import has_role
88
from ietf.utils.mail import send_mail_text
9-
from ietf.wgchairs.accounts import get_person_for_user
109
from ietf.group.models import Group
1110
from ietf.secr.utils.group import current_nomcom
1211
from ietf.secr.utils.decorators import check_for_cancel
@@ -111,4 +110,4 @@ def confirm(request):
111110
'message': data,
112111
'to': to},
113112
RequestContext(request, {}),
114-
)
113+
)

0 commit comments

Comments
 (0)