Skip to content

Commit aacb3af

Browse files
committed
Better error and progress messages
1 parent 4fbb207 commit aacb3af

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

TODO

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
Binary packages
22
---------------
33

4-
* Better error messages
5-
* Show 'Downloading' and 'Installing' messages a la ruby-build
4+
X Better error messages
5+
X Show 'Downloading' and 'Installing' messages a la ruby-build
66
* Rewrite RbConfig::CONFIG['CC'] on install
77
* Patch rbx since the rewriter doesn't work there
88
* rbenv-install should check for binary packages before building

libexec/ruby-package-fetch

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ if [ -n "$check" ]; then
6464
} >&2
6565
else
6666
package_filename="${TMPDIR}/${package_name}.$$"
67+
echo "Downloading $package_url..." >&2
6768
download "$package_url" "$package_filename" || {
6869
echo "error: couldn't fetch package \`$package' ($package_url)"
6970
exit 1

libexec/ruby-package-install

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,5 +37,8 @@ fi
3737
trap cleanup_packages SIGINT SIGTERM EXIT
3838

3939
package_root="$(ruby-package unpack "$package_file")"
40+
package_name="$(cat "${package_root}/metadata/package")"
4041

42+
echo "Installing ${package_name}..." >&2
4143
"${package_root}/bin/ruby-package-install" "$destination"
44+
echo "Installed ${package_name} to ${destination}" >&2

0 commit comments

Comments
 (0)