Skip to content

Commit d8dcc07

Browse files
tomersrstoenescu
tomers
authored and
rstoenescu
committed
Add rel="noopener" to external links (quasarframework#4531)
* Add rel="noopener" to external links * Update DocPage.vue * Remove duplicate entry
1 parent e7a3594 commit d8dcc07

File tree

11 files changed

+54
-48
lines changed

11 files changed

+54
-48
lines changed

‎docs/src/components/AppExtensionDiscover.vue‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
tag="a"
3737
:href="item.links"
3838
target="_blank"
39+
rel="noopener"
3940
>
4041
<q-item-section>
4142
<q-item-label class="q-gutter-sm">

‎docs/src/components/Codepen.vue‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ form(
44
method="POST"
55
action="https://codepen.io/pen/define/"
66
target="_blank"
7+
rel="noopener"
78
class="hidden"
89
)
910
input(

‎docs/src/components/DocPage.vue‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,22 +50,22 @@ q-page.doc-page
5050
| Caught a mistake? <doc-link :to="editHref">Suggest an edit on GitHub</doc-link>
5151

5252
.doc-page-footer__icons.row.items-center
53-
a(href="https://github.com/quasarframework/quasar", target="_blank")
53+
a(href="https://github.com/quasarframework/quasar", target="_blank", rel="noopener")
5454
q-icon(name="fab fa-github")
5555

56-
a(href="https://twitter.com/quasarframework", target="_blank")
56+
a(href="https://twitter.com/quasarframework", target="_blank", rel="noopener")
5757
q-icon(name="fab fa-twitter")
5858

59-
a(href="https://medium.com/quasar-framework", target="_blank")
59+
a(href="https://medium.com/quasar-framework", target="_blank", rel="noopener")
6060
q-icon(name="fab fa-medium")
6161

62-
a(href="https://chat.quasar.dev", target="_blank")
62+
a(href="https://chat.quasar.dev", rel="noopener", target="_blank")
6363
q-icon(name="fab fa-discord")
6464

65-
a(href="https://forum.quasar.dev/", target="_blank")
65+
a(href="https://forum.quasar.dev/", rel="noopener", target="_blank")
6666
q-icon(name="fas fa-comments")
6767

68-
a(href="https://donate.quasar.dev", target="_blank")
68+
a(href="https://donate.quasar.dev", rel="noopener", target="_blank")
6969
q-icon(name="fas fa-medkit")
7070

7171
div.q-mt-md

‎docs/src/components/HeaderMenu.vue‎

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,17 @@ div
33
q-btn-dropdown.text-bold(:align="align", flat, no-caps, stretch, :label="`v${$q.version}`", auto-close)
44
q-list(dense padding)
55
q-item-label(header) Latest (v{{ $q.version }})
6-
q-item(clickable, tag="a", href="https://github.com/quasarframework/quasar/releases", target="_blank")
6+
q-item(clickable, tag="a", href="https://github.com/quasarframework/quasar/releases", target="_blank", rel="noopener")
77
q-item-section.text-teal(avatar)
88
q-icon(name="assignment")
99
q-item-section Release notes
1010

11-
q-item(clickable, tag="a", href="https://github.com/quasarframework/quasar/issues", target="_blank")
11+
q-item(clickable, tag="a", href="https://github.com/quasarframework/quasar/issues", target="_blank", rel="noopener")
1212
q-item-section.text-purple(avatar)
1313
q-icon(name="bug_report")
1414
q-item-section Report a bug
1515

16-
q-item(clickable, tag="a", href="https://github.com/quasarframework/quasar", target="_blank")
16+
q-item(clickable, tag="a", href="https://github.com/quasarframework/quasar", target="_blank", rel="noopener")
1717
q-item-section(avatar)
1818
q-icon(name="fab fa-github")
1919
q-item-section Repository
@@ -28,12 +28,13 @@ div
2828
tag="a"
2929
:href="`https://v0-${version}.quasar-framework.org/`"
3030
target="_blank"
31+
rel="noopener"
3132
)
3233
q-item-section {{ `v0.${version}` }} docs
3334

3435
q-btn-dropdown.text-bold(:align="align", flat, no-caps, stretch, label="Tools", auto-close)
3536
q-list(dense padding)
36-
q-item(clickable, tag="a", href="https://github.com/quasarframework/quasar-awesome", target="_blank")
37+
q-item(clickable, tag="a", href="https://github.com/quasarframework/quasar-awesome", rel="noopener", target="_blank")
3738
q-item-section.text-yellow-9(avatar)
3839
q-icon(name="flare")
3940
q-item-section Awesome List
@@ -62,64 +63,64 @@ div
6263

6364
q-item-label.q-mt-md(header) Playground
6465

65-
q-item(clickable, tag="a", href="https://codepen.quasar.dev", target="_blank")
66+
q-item(clickable, tag="a", href="https://codepen.quasar.dev", target="_blank", rel="noopener")
6667
q-item-section.text-brown-5(avatar)
6768
q-icon(name="fab fa-codepen")
6869
q-item-section Codepen
6970

70-
q-item(clickable, tag="a", href="https://jsfiddle.quasar.dev", target="_blank")
71+
q-item(clickable, tag="a", href="https://jsfiddle.quasar.dev", target="_blank", rel="noopener")
7172
q-item-section.text-primary(avatar)
7273
q-icon(name="fab fa-jsfiddle")
7374
q-item-section jsFiddle
7475

75-
q-item(clickable, tag="a", href="https://codesandbox.quasar.dev", target="_blank")
76+
q-item(clickable, tag="a", href="https://codesandbox.quasar.dev", target="_blank", rel="noopener")
7677
q-item-section.text-black(avatar)
7778
q-icon(name="fas fa-cubes")
7879
q-item-section Codesandbox
7980

8081
q-btn-dropdown.text-bold(:align="align", flat, no-caps, stretch, label="Support", auto-close)
8182
q-list(dense padding)
8283

83-
q-item(clickable, tag="a", href="https://chat.quasar.dev", target="_blank")
84+
q-item(clickable, tag="a", href="https://chat.quasar.dev", rel="noopener", target="_blank")
8485
q-item-section.text-primary(avatar)
8586
q-icon(name="fab fa-discord")
8687
q-item-section Discord Chat
8788

88-
q-item(clickable, tag="a", href="https://forum.quasar.dev/", target="_blank")
89+
q-item(clickable, tag="a", href="https://forum.quasar.dev/", rel="noopener", target="_blank")
8990
q-item-section.text-secondary(avatar)
9091
q-icon(name="fas fa-comments")
9192
q-item-section Forum
9293

93-
q-item(clickable, tag="a", href="https://stackoverflow.com/search?q=quasarframework", target="_blank")
94+
q-item(clickable, tag="a", href="https://stackoverflow.com/search?q=quasarframework", rel="noopener", target="_blank")
9495
q-item-section.text-red(avatar)
9596
q-icon(name="fab fa-stack-overflow")
9697
q-item-section Stack Overflow
9798

98-
q-item(clickable, tag="a", href="https://github.com/quasarframework", target="_blank")
99+
q-item(clickable, tag="a", href="https://github.com/quasarframework", rel="noopener", target="_blank")
99100
q-item-section(avatar)
100101
q-icon(name="fab fa-github")
101102
q-item-section Github Repositories
102103

103104
q-item-label.q-mt-md(header) Social
104105

105-
q-item(clickable, tag="a", href="https://blog.quasar.dev", target="_blank")
106+
q-item(clickable, tag="a", href="https://blog.quasar.dev", rel="noopener", target="_blank")
106107
q-item-section.text-primary(avatar)
107108
q-icon(name="fab fa-medium")
108109
q-item-section Blog
109110

110-
q-item(clickable, tag="a", href="https://forum.quasar.dev/category/1/announcements", target="_blank")
111+
q-item(clickable, tag="a", href="https://forum.quasar.dev/category/1/announcements", target="_blank", rel="noopener")
111112
q-item-section.text-purple(avatar)
112113
q-icon(name="announcement")
113114
q-item-section Announcements
114115

115-
q-item(clickable, tag="a", href="https://twitter.com/quasarframework", target="_blank")
116+
q-item(clickable, tag="a", href="https://twitter.com/quasarframework", target="_blank", rel="noopener")
116117
q-item-section.text-blue(avatar)
117118
q-icon(name="fab fa-twitter")
118119
q-item-section Twitter
119120

120121
q-item-label.q-mt-md(header) Donate
121122

122-
q-item(clickable, tag="a", href="https://github.com/users/rstoenescu/sponsorship", target="_blank")
123+
q-item(clickable, tag="a", href="https://github.com/users/rstoenescu/sponsorship", target="_blank", rel="noopener")
123124
q-item-section(avatar)
124125
q-icon(name="fab fa-github")
125126
q-item-section Github Sponsorship

‎docs/src/components/page-parts/layout/LayoutGalleryPage.vue‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
type="a"
1111
:href="sourceLink"
1212
target="_blank"
13+
rel="noopener"
1314
)
1415
</template>
1516

‎docs/src/components/page-parts/meet-the-team/TeamMember.vue‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@
1414

1515
q-card-actions(align="around")
1616
div(v-if="twitter")
17-
q-btn(type="a", :href="url.twitter", target="_blank", round, flat, icon="fab fa-twitter")
17+
q-btn(type="a", :href="url.twitter", target="_blank", rel="noopener", round, flat, icon="fab fa-twitter")
1818
div(v-if="github")
19-
q-btn(type="a", :href="url.github", target="_blank", round, flat, icon="fab fa-github")
19+
q-btn(type="a", :href="url.github", target="_blank", rel="noopener", round, flat, icon="fab fa-github")
2020
div(v-if="email")
21-
q-btn(type="a", :href="url.email", target="_blank", round, flat, icon="mail")
21+
q-btn(type="a", :href="url.email", target="_blank", rel="noopener", round, flat, icon="mail")
2222
</template>
2323

2424
<script>

‎docs/src/components/page-parts/sponsors-and-backers/DonatingButtons.vue‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
type="a"
99
href="https://github.com/users/rstoenescu/sponsorship"
1010
target="_blank"
11+
rel="noopener"
1112
>
1213
<div class="row items-center no-wrap">
1314
<q-icon left name="fab fa-github" />
@@ -28,9 +29,10 @@
2829
type="a"
2930
href="https://www.patreon.com/quasarframework"
3031
target="_blank"
32+
rel="noopener"
3133
/>
3234

33-
<form class="inline-block" action="https://www.paypal.com/cgi-bin/webscr" method="post" target="_blank">
35+
<form class="inline-block" action="https://www.paypal.com/cgi-bin/webscr" method="post" target="_blank" rel="noopener">
3436
<input type="hidden" name="cmd" value="_s-xclick">
3537
<input type="hidden" name="encrypted" value="-----BEGIN PKCS7-----MIIHRwYJKoZIhvcNAQcEoIIHODCCBzQCAQExggEwMIIBLAIBADCBlDCBjjELMAkGA1UEBhMCVVMxCzAJBgNVBAgTAkNBMRYwFAYDVQQHEw1Nb3VudGFpbiBWaWV3MRQwEgYDVQQKEwtQYXlQYWwgSW5jLjETMBEGA1UECxQKbGl2ZV9jZXJ0czERMA8GA1UEAxQIbGl2ZV9hcGkxHDAaBgkqhkiG9w0BCQEWDXJlQHBheXBhbC5jb20CAQAwDQYJKoZIhvcNAQEBBQAEgYC8Jxd/lV2NYjF4vdGeAkgItd+1dzoIVbvrR645qATrrEK+Rg8OKnb71T2AFLWfp3ROeEgvJzr6uFNrqQpjVt6ovUAP6dv1X/WTYEavvxblJZ6Mb/N6zjhPxHtv6hZTL/j4YEhAjqzg5IjcT3aF4U1E3B9YzvmW15ZhZgs1YeNPPzELMAkGBSsOAwIaBQAwgcQGCSqGSIb3DQEHATAUBggqhkiG9w0DBwQIrMOcJafXT5WAgaDJmlcq78MMlZuLG35WKOzD8Dz6kDPYApaNWEThEnaP96BeWIJONk4MavI+loWG4F3aNX8Zk8tWt+cbL/7Ck2qwm7i7T9zXDTqNwBVN1Bwzz/HKpg2yu5jBPsc7Nvhoo7yS14IQDULHNtGZF/Vn1PGH5Spv6hMEYTdkOru6G/Wk5YH5RvzMFwulkInq6XZytMjcxvibZLMA+uw92sVPhLeeoIIDhzCCA4MwggLsoAMCAQICAQAwDQYJKoZIhvcNAQEFBQAwgY4xCzAJBgNVBAYTAlVTMQswCQYDVQQIEwJDQTEWMBQGA1UEBxMNTW91bnRhaW4gVmlldzEUMBIGA1UEChMLUGF5UGFsIEluYy4xEzARBgNVBAsUCmxpdmVfY2VydHMxETAPBgNVBAMUCGxpdmVfYXBpMRwwGgYJKoZIhvcNAQkBFg1yZUBwYXlwYWwuY29tMB4XDTA0MDIxMzEwMTMxNVoXDTM1MDIxMzEwMTMxNVowgY4xCzAJBgNVBAYTAlVTMQswCQYDVQQIEwJDQTEWMBQGA1UEBxMNTW91bnRhaW4gVmlldzEUMBIGA1UEChMLUGF5UGFsIEluYy4xEzARBgNVBAsUCmxpdmVfY2VydHMxETAPBgNVBAMUCGxpdmVfYXBpMRwwGgYJKoZIhvcNAQkBFg1yZUBwYXlwYWwuY29tMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDBR07d/ETMS1ycjtkpkvjXZe9k+6CieLuLsPumsJ7QC1odNz3sJiCbs2wC0nLE0uLGaEtXynIgRqIddYCHx88pb5HTXv4SZeuv0Rqq4+axW9PLAAATU8w04qqjaSXgbGLP3NmohqM6bV9kZZwZLR/klDaQGo1u9uDb9lr4Yn+rBQIDAQABo4HuMIHrMB0GA1UdDgQWBBSWn3y7xm8XvVk/UtcKG+wQ1mSUazCBuwYDVR0jBIGzMIGwgBSWn3y7xm8XvVk/UtcKG+wQ1mSUa6GBlKSBkTCBjjELMAkGA1UEBhMCVVMxCzAJBgNVBAgTAkNBMRYwFAYDVQQHEw1Nb3VudGFpbiBWaWV3MRQwEgYDVQQKEwtQYXlQYWwgSW5jLjETMBEGA1UECxQKbGl2ZV9jZXJ0czERMA8GA1UEAxQIbGl2ZV9hcGkxHDAaBgkqhkiG9w0BCQEWDXJlQHBheXBhbC5jb22CAQAwDAYDVR0TBAUwAwEB/zANBgkqhkiG9w0BAQUFAAOBgQCBXzpWmoBa5e9fo6ujionW1hUhPkOBakTr3YCDjbYfvJEiv/2P+IobhOGJr85+XHhN0v4gUkEDI8r2/rNk1m0GA8HKddvTjyGw/XqXa+LSTlDYkqI8OwR8GEYj4efEtcRpRYBxV8KxAW93YDWzFGvruKnnLbDAF6VR5w/cCMn5hzGCAZowggGWAgEBMIGUMIGOMQswCQYDVQQGEwJVUzELMAkGA1UECBMCQ0ExFjAUBgNVBAcTDU1vdW50YWluIFZpZXcxFDASBgNVBAoTC1BheVBhbCBJbmMuMRMwEQYDVQQLFApsaXZlX2NlcnRzMREwDwYDVQQDFAhsaXZlX2FwaTEcMBoGCSqGSIb3DQEJARYNcmVAcGF5cGFsLmNvbQIBADAJBgUrDgMCGgUAoF0wGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMTYwNjExMTIxNDI3WjAjBgkqhkiG9w0BCQQxFgQUEgwqrR76Eazz9VYQUdwFEbyHyRswDQYJKoZIhvcNAQEBBQAEgYAA6Zlp5zXl1/jcCTeVAspsSfKtMOKXohrzkcKdoYacERc+02nzZcNDY7uSNWiG3Fa3iwHbpmyfUP9Hf87/2DQxJm5B3TS58FcOosvc9yRCHOSvEU9iBSt5PYv7wwp3+KMsfbBj6KX4g0nhvHbrTwyochdnAOLRsbtpm3I4lhjXqQ==-----END PKCS7-----
3638
">

‎docs/src/layouts/Layout.vue‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ q-layout.doc-layout(view="lHh LpR lff", @scroll="onScroll")
2929
type="a"
3030
href="https://github.com/users/rstoenescu/sponsorship"
3131
target="_blank"
32+
rel="noopener"
3233
size="13px"
3334
color="primary"
3435
icon="favorite_border"

‎docs/src/layouts/gallery/quasar-classic-dark.vue‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
>
2424
<q-list dark>
2525
<q-item-label header>Essential Links</q-item-label>
26-
<q-item clickable tag="a" target="_blank" href="http://quasar.dev">
26+
<q-item clickable tag="a" target="_blank" rel="noopener" href="http://quasar.dev">
2727
<q-item-section avatar>
2828
<q-icon name="school" />
2929
</q-item-section>
@@ -32,7 +32,7 @@
3232
<q-item-label caption>https://quasar.dev</q-item-label>
3333
</q-item-section>
3434
</q-item>
35-
<q-item clickable tag="a" target="_blank" href="https://github.com/quasarframework/">
35+
<q-item clickable tag="a" target="_blank" rel="noopener" href="https://github.com/quasarframework/">
3636
<q-item-section avatar>
3737
<q-icon name="code" />
3838
</q-item-section>
@@ -41,7 +41,7 @@
4141
<q-item-label caption>github.com/quasarframework</q-item-label>
4242
</q-item-section>
4343
</q-item>
44-
<q-item clickable tag="a" target="_blank" href="http://chat.quasar.dev">
44+
<q-item clickable tag="a" target="_blank" rel="noopener" href="http://chat.quasar.dev">
4545
<q-item-section avatar>
4646
<q-icon name="chat" />
4747
</q-item-section>
@@ -50,7 +50,7 @@
5050
<q-item-label caption>https://chat.quasar.dev</q-item-label>
5151
</q-item-section>
5252
</q-item>
53-
<q-item clickable tag="a" target="_blank" href="https://forum.quasar.dev">
53+
<q-item clickable tag="a" target="_blank" rel="noopener" href="https://forum.quasar.dev">
5454
<q-item-section avatar>
5555
<q-icon name="record_voice_over" />
5656
</q-item-section>
@@ -59,7 +59,7 @@
5959
<q-item-label caption>https://forum.quasar.dev</q-item-label>
6060
</q-item-section>
6161
</q-item>
62-
<q-item clickable tag="a" target="_blank" href="https://twitter.com/quasarframework">
62+
<q-item clickable tag="a" target="_blank" rel="noopener" href="https://twitter.com/quasarframework">
6363
<q-item-section avatar>
6464
<q-icon name="rss_feed" />
6565
</q-item-section>

‎docs/src/layouts/gallery/quasar-classic.vue‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
>
2525
<q-list>
2626
<q-item-label header>Essential Links</q-item-label>
27-
<q-item clickable tag="a" target="_blank" href="http://quasar.dev">
27+
<q-item clickable tag="a" target="_blank" rel="noopener" href="http://quasar.dev">
2828
<q-item-section avatar>
2929
<q-icon name="school" />
3030
</q-item-section>
@@ -33,7 +33,7 @@
3333
<q-item-label caption>https://quasar.dev</q-item-label>
3434
</q-item-section>
3535
</q-item>
36-
<q-item clickable tag="a" target="_blank" href="https://github.com/quasarframework/">
36+
<q-item clickable tag="a" target="_blank" rel="noopener" href="https://github.com/quasarframework/">
3737
<q-item-section avatar>
3838
<q-icon name="code" />
3939
</q-item-section>
@@ -42,7 +42,7 @@
4242
<q-item-label caption>github.com/quasarframework</q-item-label>
4343
</q-item-section>
4444
</q-item>
45-
<q-item clickable tag="a" target="_blank" href="http://chat.quasar.dev">
45+
<q-item clickable tag="a" target="_blank" rel="noopener" href="http://chat.quasar.dev">
4646
<q-item-section avatar>
4747
<q-icon name="chat" />
4848
</q-item-section>
@@ -51,7 +51,7 @@
5151
<q-item-label caption>https://chat.quasar.dev</q-item-label>
5252
</q-item-section>
5353
</q-item>
54-
<q-item clickable tag="a" target="_blank" href="https://forum.quasar.dev">
54+
<q-item clickable tag="a" target="_blank" rel="noopener" href="https://forum.quasar.dev">
5555
<q-item-section avatar>
5656
<q-icon name="record_voice_over" />
5757
</q-item-section>
@@ -60,7 +60,7 @@
6060
<q-item-label caption>https://forum.quasar.dev</q-item-label>
6161
</q-item-section>
6262
</q-item>
63-
<q-item clickable tag="a" target="_blank" href="https://twitter.com/quasarframework">
63+
<q-item clickable tag="a" target="_blank" rel="noopener" href="https://twitter.com/quasarframework">
6464
<q-item-section avatar>
6565
<q-icon name="rss_feed" />
6666
</q-item-section>

0 commit comments

Comments
 (0)