fix(cli): avoid nodejs side-effects for multiple var declarations in same statement

Author: rstoenescu

cli/lib/ask.js

@@ -1,9 +1,8 @@
 // Following is adapted from Vue CLI v2 "init" command
 
-const
-  async = require('async'),
-  inquirer = require('inquirer'),
-  evaluate = require('./eval')
+const async = require('async')
+const inquirer = require('inquirer')
+const evaluate = require('./eval')
 
 // Support types from prompt-for which was used before
 const promptMapping = {

cli/lib/ensure-outside-project.js

@@ -1,6 +1,5 @@
-const
-  { existsSync } = require('fs'),
-  { sep, normalize, join } = require('path')
+const { existsSync } = require('fs')
+const { sep, normalize, join } = require('path')
 
 module.exports = function () {
   let dir = process.cwd()

cli/lib/eval.js

@@ -10,9 +10,11 @@ const chalk = require('chalk')
 module.exports = function evaluate (exp, data) {
   /* eslint-disable no-new-func */
   const fn = new Function('data', 'with (data) { return ' + exp + '}')
+
   try {
     return fn(data)
-  } catch (e) {
+  }
+  catch (e) {
     console.error(chalk.red('Error when evaluating filter condition: ' + exp))
   }
 }

cli/lib/filter.js

@@ -1,8 +1,7 @@
 // Following is adapted from Vue CLI v2 "init" command
 
-const
-  match = require('minimatch'),
-  evaluate = require('./eval')
+const match = require('minimatch')
+const evaluate = require('./eval')
 
 module.exports = (files, filters, data, done) => {
   if (!filters) {

cli/lib/generate.js

@@ -1,19 +1,17 @@
 // Adapted from Vue CLI v2 "init" command
 
-const
-  chalk = require('chalk'),
-  Metalsmith = require('metalsmith'),
-  Handlebars = require('handlebars'),
-  async = require('async'),
-  render = require('consolidate').handlebars.render,
-  path = require('path'),
-  multimatch = require('multimatch')
-
-const
-  getOptions = require('./options'),
-  ask = require('./ask'),
-  filter = require('./filter'),
-  logger = require('./logger')
+const chalk = require('chalk')
+const Metalsmith = require('metalsmith')
+const Handlebars = require('handlebars')
+const async = require('async')
+const render = require('consolidate').handlebars.render
+const path = require('path')
+const multimatch = require('multimatch')
+
+const getOptions = require('./options')
+const ask = require('./ask')
+const filter = require('./filter')
+const logger = require('./logger')
 
 // register handlebars helper
 Handlebars.registerHelper('if_eq', function (a, b, opts) {

cli/lib/get-project-root.js

@@ -1,6 +1,5 @@
-const
-  { existsSync } = require('fs'),
-  { sep, normalize, join } = require('path')
+const { existsSync } = require('fs')
+const { sep, normalize, join } = require('path')
 
 module.exports = function () {
   let dir = process.cwd()

cli/lib/git-user.js

@@ -9,9 +9,11 @@ module.exports = () => {
   try {
     name = exec('git config --get user.name')
     email = exec('git config --get user.email')
-  } catch (e) {}
+  }
+  catch (e) {}
 
   name = name && JSON.stringify(name.toString().trim()).slice(1, -1)
   email = email && (' <' + email.toString().trim() + '>')
+
   return (name || '') + (email || '')
 }

cli/lib/logger.js

@@ -1,8 +1,7 @@
 // Adapted from Vue CLI v2 "init" command
 
-const
-  chalk = require('chalk'),
-  format = require('util').format
+const chalk = require('chalk')
+const format = require('util').format
 
 /**
  * Prefix.

cli/lib/net.js

@@ -1,11 +1,10 @@
-const
-  os = require('os'),
-  net = require('net')
+const os = require('os')
+const net = require('net')
 
 module.exports.getExternalNetworkInterface = function () {
   const
-    networkInterfaces = os.networkInterfaces(),
-    devices = []
+    networkInterfaces = os.networkInterfaces();
+    const devices = []
 
   for (let deviceName of Object.keys(networkInterfaces)) {
     const networkInterface = networkInterfaces[deviceName]

cli/lib/node-packager.js

@@ -1,10 +1,8 @@
-const
-  fs = require('fs'),
-  { join } = require('path'),
-  spawn = require('cross-spawn').sync
+const fs = require('fs')
+const { join } = require('path')
+const spawn = require('cross-spawn').sync
 
-const
-  { fatal } = require('./logger')
+const { fatal } = require('./logger')
 
 function isInstalled (cmd) {
   try {