Skip to content

Commit 32ddfd5

Browse files
committed
fix(TS): Object type instead of 'any' where appropriate quasarframework#5711
1 parent 2968f35 commit 32ddfd5

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

ui/build/build.types.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,10 @@ function convertTypeVal (type, def, required) {
4848
const propDefinitions = getPropDefinitions(def.definition, required, true)
4949
let lines = []
5050
propDefinitions.forEach(p => lines.push(...p.split('\n')))
51-
return propDefinitions && propDefinitions.length > 0 ? `{\n ${lines.join('\n ')} }` : 'any'
51+
return propDefinitions && propDefinitions.length > 0 ? `{\n ${lines.join('\n ')} }` : 'Object'
5252
}
5353

54-
return 'any'
54+
return 'Object'
5555
}
5656

5757
return t

ui/src/utils/web-storage.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,9 @@ export function getStorage (type) {
9696
getLength: () => webStorage.length,
9797
getItem: get,
9898
getIndex: index => {
99-
if (index < webStorage.length) {
100-
return get(webStorage.key(index))
101-
}
99+
return index < webStorage.length
100+
? get(webStorage.key(index))
101+
: null
102102
},
103103
getAll: () => {
104104
let result = {}, key, len = webStorage.length

ui/src/utils/web-storage.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@
4040
}
4141
},
4242
"returns": {
43-
"type": [ "Date", "RegExp", "Number", "Boolean", "Function", "Object", "String" ],
43+
"type": [ "Date", "RegExp", "Number", "Boolean", "Function", "Object", "String", "null" ],
4444
"desc": "Storage item value",
45-
"examples": [ "john12" ]
45+
"examples": [ "john12", 702 ]
4646
}
4747
},
4848

@@ -57,7 +57,7 @@
5757
}
5858
},
5959
"returns": {
60-
"type": "Number",
60+
"type": [ "Number", "null" ],
6161
"desc": "Storage item index",
6262
"examples": [ 7 ]
6363
}
@@ -85,7 +85,7 @@
8585
},
8686

8787
"value": {
88-
"type": [ "Date", "RegExp", "Number", "Boolean", "Function", "Object", "String" ],
88+
"type": [ "Date", "RegExp", "Number", "Boolean", "Function", "Object", "String", "null" ],
8989
"desc": "Entry value",
9090
"required": true,
9191
"examples": [ "john12" ]

0 commit comments

Comments
 (0)